Libguestfs - Jun 2020 - Re: [PATCH 3/3] nbdkit: add a --without-linuxdisk configure argument

I made some stylistic changes to the first two patches so they match
existing code, and I pushed them, along with your third patch
unmodified.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

Thanks.  I didn't realize that #include <config.h> must always come
first.
I'm used to the FreeBSD convention, where sys/* comes first.
-Alan

On Fri, Jun 19, 2020 at 8:29 AM Richard W.M. Jones <rjones@redhat.com>
wrote:
> I made some stylistic changes to the first two patches so they match
> existing code, and I pushed them, along with your third patch
> unmodified.
>
> Thanks,
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-top is 'top' for virtual machines.  Tiny program with many
> powerful monitoring features, net stats, disk stats, logging, etc.
> http://people.redhat.com/~rjones/virt-top
>
>

On Fri, Jun 19, 2020 at 10:44:36AM -0600, alan somers
wrote:
> Thanks.  I didn't realize that #include <config.h> must always
come first.
> I'm used to the FreeBSD convention, where sys/* comes first.
> -Alan
I believe the actual reason for this (beyond our preferences!) is that
config.h, generated by autoconf, can define symbols which affect what
is enabled by system headers.  The canonical example is _GNU_SOURCE,
defined by config.h on Linux, which enables glibc extensions in
subsequent header files.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org