search for: linuxdisk

...| 4 + TODO | 11 +- configure.ac | 2 + plugins/floppy/nbdkit-floppy-plugin.pod | 4 + plugins/iso/nbdkit-iso-plugin.pod | 6 +- plugins/linuxdisk/Makefile.am | 73 ++++++ plugins/linuxdisk/filesystem.c | 267 +++++++++++++++++++++ plugins/linuxdisk/linuxdisk.c | 229 ++++++++++++++++++ plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 180 ++++++++++++++ plugins/linuxdisk/part...

This time it should hopefully work. I tested all 3 combinations: autoconf ./configure [--disable-linuxdisk | --enable-linuxdisk | <nothing> ] make clean && make && make check and they all appear to do the right thing. Rich.

...| 2 +- TODO | 2 + configure.ac | 4 +- plugins/floppy/nbdkit-floppy-plugin.pod | 1 + plugins/iso/nbdkit-iso-plugin.pod | 6 +- plugins/linuxdisk/Makefile.am | 78 ++ plugins/linuxdisk/filesystem.c | 935 +++++++++++++++++++++ plugins/linuxdisk/linuxdisk.c | 236 ++++++ plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 197 +++++ plugins/linuxdisk/partition-gpt.c...

...++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index e6ca09de..376b1538 100644 --- a/configure.ac +++ b/configure.ac @@ -483,17 +483,17 @@ AS_IF([test "$GNUTLS_LIBS" != ""],[ LIBS="$old_LIBS" ]) -AC_ARG_WITH([linuxdisk], - [AS_HELP_STRING([--without-linuxdisk], +AC_ARG_ENABLE([linuxdisk], + [AS_HELP_STRING([--disable-linuxdisk], [disable linuxdisk plugin @<:@default=check@:>@])], [], - [with_linuxdisk=check]) + [enable_linuxdisk=check]) dnl Check for mke2fs -d (used by...

For v3 I reimplemented this using mke2fs -d. This obviously makes the implementation a whole lot simpler, but cannot support multiple directory merging. Patches 1-3 are the same as before. I've also reproduced the notes from v2 below. v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the

Another interesting thing you can do with this plugin: https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/ v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the temporary file and other cleanups along error paths. - fclose -> pclose, and check the return value for errors. - There's a...

...It's probably best to start with the commit message and the included man page. This is quick even for relatively large filesystems containing large numbers of small files. Here's an example for the nbdkit source code (including the .git directory): $ time ./nbdkit --filter=partition -U - linuxdisk . partition=1 --run 'qemu-img convert $nbd /var/tmp/ext2fs.img' real 0m1.314s user 0m0.424s sys 0m0.889s $ ls -lh /var/tmp/ext2fs.img -rw-r--r--. 1 rjones rjones 351M Feb 19 07:44 /var/tmp/ext2fs.img The tests + valgrind pass on Fedora 29 & RHEL 7. Rich.

From: Alan Somers <asomers@gmail.com> This can be used to disable the linuxdisk plugin, which otherwise is always built if a suitable mke2fs command is present. --- configure.ac | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index f24c3734..c93e822b 100644 --- a/configure.ac +++ b/configure.ac @@ -483,18 +483...

...test-cow.sh is still running (after 2+ hours) and there may be further tests to come. Results: 06:43:00 PASS: test-cache.sh 06:37:48 PASS: test-cache-on-read.sh [ test-cow.sh possibly here ] 00:35:41 PASS: test-partitioning3.sh 00:34:29 PASS: test-partitioning5.sh 00:34:03 PASS: test-linuxdisk-copy-out.sh 00:33:58 PASS: test-floppy.sh 00:30:45 PASS: test-partitioning2.sh 00:28:41 PASS: test-linuxdisk.sh 00:28:34 PASS: test-iso.sh 00:02:59 PASS: test-cache-max-size.sh 00:02:58 PASS: test-partitioning6.sh 00:02:55 PASS: test-partitioning4.sh 00:02:51 PASS: test-eflags.sh 00:01:11 PASS: tes...

...y signal %d", WTERMSIG (r)); > + return -1; > + } > + else if (WIFSTOPPED (r)) { > + nbdkit_error ("mke2fs command was stopped by signal %d", WSTOPSIG (r)); > + return -1; > + } > + WIFSTOPPED() branch is unreachable. > +=item nbdkit --filter=cow linuxdisk /path/to/directory > + > +Add a writable overlay (see L<nbdkit-cow-filter(1)>, allowing the disk > +to be written by the client. B<Multiple clients must not be allowed > +to connect at the same time> (even if they all mount it read-only) as > +this will cause disk corrup...

On Tue, Feb 19, 2019 at 09:21:10AM -0600, Eric Blake wrote: > Missing an unlink(). Also, does the caller properly use close(disk->fd) > on early exits like this, or does it not matter because we're just going > to exit()? Just about the early exits: I started off trying to get those paths right but it made the code ridiculously complicated so I gave up. As you say

I made some stylistic changes to the first two patches so they match existing code, and I pushed them, along with your third patch unmodified. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful

Thanks. I didn't realize that #include <config.h> must always come first. I'm used to the FreeBSD convention, where sys/* comes first. -Alan On Fri, Jun 19, 2020 at 8:29 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I made some stylistic changes to the first two patches so they match > existing code, and I pushed them, along with your third patch > unmodified.

...is EOF tells us if we are sparse, and a similar lseek(SEEK_DATA) returning ENXIO tells us if the entire file is a hole, with at most two lseek calls during open (rather than one lseek for each of .can_extents, .init_sparse, and .init_zero). The split plugin is similar to file. For partitioning and linuxdisk, we know we are exposing a sparse image. For other file-based plugins, like ext2, we do not yet expose .extents so it is not worth trying to expose .init_sparse or .init_zero. A successful test depends on whether the current file system creates sparse files, but it was easy enough to ensure the t...

From: Alan Somers <asomers@gmail.com> There was a missing #include. It only worked on Linux due to header pollution. --- plugins/ssh/ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c index ea199a93..a4007c40 100644 --- a/plugins/ssh/ssh.c +++ b/plugins/ssh/ssh.c @@ -30,6 +30,8 @@ * SUCH DAMAGE. */ +#include <sys/stat.h> +

Unfinished (needs tests). This is my attempt to make a "remote tmpfs" plugin as outlined in this prior email: https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html Although it would be possible to construct something a bit like this using existing plugins and filters (perhaps with some new features in those filters) I think it may be nicer to have a dedicated plugin for

...is double TCG which is the worst case for these tests and explains the excessively long times which wouldn't be seen on a normal build system. Updated results: 01:04:18 PASS: test-readahead 01:02:32 PASS: test-cow.sh 00:37:25 PASS: test-floppy.sh 00:34:57 PASS: test-shell 00:34:53 PASS: test-linuxdisk-copy-out.sh 00:33:57 PASS: test-partitioning3.sh 00:33:46 PASS: test-perl 00:33:38 PASS: test-partitioning5.sh 00:33:38 PASS: test-memory 00:33:28 PASS: test-ocaml 00:33:11 PASS: test-lua 00:32:33 PASS: test-tcl 00:32:16 PASS: test-offset 00:31:48 PASS: test-xz 00:31:47 PASS: test-xz-curl 00:30:19...

...e.c | 1 + plugins/floppy/floppy.c | 1 + plugins/full/full.c | 1 + plugins/guestfs/guestfs-plugin.c | 1 + plugins/gzip/gzip.c | 1 + plugins/iso/iso.c | 1 + plugins/libvirt/libvirt-plugin.c | 1 + plugins/linuxdisk/linuxdisk.c | 1 + plugins/memory/memory.c | 1 + plugins/nbd/nbd-standalone.c | 1 + plugins/nbd/nbd.c | 1 + plugins/null/null.c | 1 + plugins/partitioning/partitioning.c | 1 + plugins/pattern/pattern.c | 1 + plugins/r...

...es that would need to be implemented first. > --- > +++ b/plugins/floppy/nbdkit-floppy-plugin.pod > @@ -74,6 +74,7 @@ important, and it simplifies the implementation greatly. > L<nbdkit(1)>, > L<nbdkit-plugin(3)>, > L<nbdkit-file-plugin(1)>, > +L<nbdkit-linuxdisk-plugin(1)>, > L<nbdkit-iso-plugin(1)>. > > =head1 AUTHORS > diff --git a/plugins/iso/nbdkit-iso-plugin.pod b/plugins/iso/nbdkit-iso-plugin.pod > index 4d9cf41..90e26f0 100644 Should this have as much text pointing to the other disk plugins... > --- a/plugins/iso/nbd...

v2 was here: https://www.redhat.com/archives/libguestfs/2020-March/msg00154.html v3: - Micro-optimize tmpdir. - Quote $disk in default command shell fragment. - Don't redirect mkfs output to /dev/null. Instead use exec </dev/null >/dev/null before the shell fragment. We may want to do this in other places where we run external shell scripts, or more generally for all