search for: stylist

What are people''s opinions on which of these two styles is better to use? 1) before --------------------------- module UserSpecHelper include GenericSpecHelper def valid_sms_attributes(phone_number="12345") { :phone_number => phone_number } end end describe User, "with phone number" do include UserSpecHelper before(:each) do @user =

On 02/06/15 17:10, Richard W.M. Jones wrote: Hello, > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: >> + if (collect_coreos_inspection_info (g)) { >> + guestfs_int_free_inspect_info (g); >> + return NULL; >> + } > Although this is stylistic, I think it's easier to understand if > you change the if condition to: > > if (collect_coreos_inspection_info (g) == -1) { > ... > Since we 'll be using safe_realloc, I don't think there is a need for any of: * guestfs_int_merge_fs_inspections() * collect_coreo...

Hello, Here are a couple of small fixes for the virtio_console code, it's mostly stylistic fixes. Michael, can you push these to Linus? Thanks. Amit Shah (2): virtio: console: Fix type of 'len' as unsigned int virtio: console: Use better variable names for fill_queue operation drivers/char/virtio_console.c | 29 ++++++++++++++++------------- 1 files changed, 16 insert...

Hello, Here are a couple of small fixes for the virtio_console code, it's mostly stylistic fixes. Michael, can you push these to Linus? Thanks. Amit Shah (2): virtio: console: Fix type of 'len' as unsigned int virtio: console: Use better variable names for fill_queue operation drivers/char/virtio_console.c | 29 ++++++++++++++++------------- 1 files changed, 16 insert...

Another point of disparity between how I see others write Puppet manifests and the Best Practice that I''ve adopted at my institution is the use of quoting. In Puppet, you can get away with not quoting values or references if there isn''t a special character or a keyword being used (e.g. package { openssh: ...} or User[agirl]). However, even though that is possible, to make

...sion inspect.i_product_variant)) then ^^^ which makes me think this code can't possibly work. - Calling String.lowercase is unsafe (because the function is just broken in OCaml) and unnecessary. Just remove it. - (Stylistic) You don't need parentheses around if conditionals. - (Stylistic) You don't need parentheses around the arguments of && - (Stylistic) You don't need parentheses around the arguments of // Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjon...

...t;getValue(), >>> + AccessFunction, Size, >>> false), >>> +&Inst)); >>> + } >>> + } >>> } >>> >>> if (Functions.empty()) > > Yeah, there are quite a few stylistic problems actually, my bad!! I'll > get all the style problems fixed as fast as possible! Sorry for that. Alright. I failed on this myself, which is why Polly is not everywhere perfect. Still, we should try to follow the LLVM style guide. BTW, if you find any problems in patches I commit...

...nst *RI = dyn_cast<ReturnInst>(BI); + if (RI) { + if (RI->getReturnValue()==0 || + std::find(RI->op_begin(), RI->op_end(), + (Value*)&I) != RI->op_end()) { + IsNextInstRet=true; + } + } + } + return IsNextInstRet; +} + Some stylistic nitpicks. Please write the comments as: /// IsNextInstructionReturn - Check whether.. + assert(BI != BB->end() && "Woohooa"); Better assertion messages please. :-) Why not write it like this: +bool IsNextInstructionReturn(Instruction &I) { + BasicBlock *BB = I.getPar...

...                                           AccessFunction, Size, >>>> false), >>>> +&Inst)); >>>> +      } >>>> +    } >>>>    } >>>> >>>>    if (Functions.empty()) >> >> Yeah, there are quite a few stylistic problems actually, my bad!! I'll >> get all the style problems fixed as fast as possible! Sorry for that. > > Alright. I failed on this myself, which is why Polly is not everywhere > perfect. Still, we should try to follow the LLVM style guide. > > BTW, if you find any pr...

The patch is against revision 42247. -------------- next part -------------- A non-text attachment was scrubbed... Name: tailcall-src.patch Type: application/octet-stream Size: 62639 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20070923/4770302f/attachment.obj>

...COMPANY.NET <1C> GRUPPE 192.168.200.121 72 % NBTSTAT -n LAN-Verbindung: Knoten-IP-Adresse: [192.168.200.201] Bereichskennung: [] Lokale NetBIOS-Namentabelle Name Typ Status --------------------------------------------- STYLISTIC <00> EINDEUTIG Registriert INTRA.COMPANY.NET <00> GRUPPE Registriert STYLISTIC <20> EINDEUTIG Registriert INTRA.COMPANY.NET <1E> GRUPPE Registriert % NBTSTAT -a SERVER LAN-Verbindung: Knoten-IP-Adresse: [192.168.200.201] Be...

Here is a small doc patch based on answers from the list and from the links mentioned. For stylistic consistency I've followed the language in the va_arg description for the analogous situation. Dustin -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: LangRef.unwind.patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/2010...

Just stylistic change, no functional change. --- dib/dib.ml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dib/dib.ml b/dib/dib.ml index 06a1f67..35ae6b7 100644 --- a/dib/dib.ml +++ b/dib/dib.ml @@ -781,9 +781,8 @@ let main () = ) @ mkfs_options @ [ "-t"; cmdline.fs_typ...

I made some stylistic changes to the first two patches so they match existing code, and I pushed them, along with your third patch unmodified. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-t...

...about setting up the wakeup feature of Asterisk to NOT call an extension, but to call a phone number? My setup works great for wakeup on local extensions, but I'd like to set it up to call external phone numbers automatically and play a specific sound file (to remind people of upcoming hair stylist appointments). I suppose either there'd have to be a web interface to use for this (entering a time for the reminder - and a phone number to call) or change the voice prompt to ask for a phone number to use, if not the extension called from. I'm sure it's doable - but I am now kno...

Here's a list of cosmetic changes I'd be willing to make to the code in order to make it more consistent, which stylisticly it currently is not. - separate function definitions by 2 newlines - put spaces after commas in arg lists - put spaces around assignments - remove trailing spaces - change space indents to tabs - fix multiline comments - remove redundant /* dw */ comments (Deborah Weiss is already credited in...

Adds external weak symbols of constant pool to ExtWeakSymbols set. Lauro -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/1aaa0c7b/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 1021 bytes Desc: not available

Hi Lauro, Just a stylistic remark; In your "llvm.patch" file, there are tabs in these lines: + if (GV->hasExternalWeakLinkage()) { + ExtWeakSymbols.insert(GV); + } Others will need to review the patch for correctness, though. -bw On 12/20/06, Lauro Ramos Venancio <lauro.venancio at gmail.com> wrote...

without tabs Lauro 2006/12/20, Bill Wendling <isanbard at gmail.com>: > > Hi Lauro, > > Just a stylistic remark; In your "llvm.patch" file, there are tabs in > these lines: > > + if (GV->hasExternalWeakLinkage()) { > + ExtWeakSymbols.insert(GV); > + } > > Others will need to review the patch for correctness, though. > > -bw > > On 12/...

On Mon, Jul 7, 2008 at 11:10 AM, Rajika Kumarasiri <rajikacc at gmail.com> wrote: > hello everybody, > > I have added few improvements to my patch. Please review the new patch > directly. > Thanks! > Hi Rajika, A few stylistic comments. I'll let others comment on the algorithm for now: if ($VERBOSE) { print "( time -p $SVNCMD/llvm/trunk llvm; cd llvm/projects ; " . - "$SVNCMD/test-suite/trunk llvm-test ) > $COLog 2>&1\n"; + "$SVNCMD/test-suite/tr...