Martin Kletzander
2019-Sep-20 08:53 UTC
[Libguestfs] [PATCH] build: Move po subdir after everything else except po-docs
Otherwise it complains about missing files that it has no rules for, for example `builder/index-parser.c`. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- Another issue I found when compiling on CentOS 7. Not sure why it happens, but it only makes sense that the directory that uses files from other directories (which might be generated) is used after all the code ones. Makefile.am | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1cc21961ae89..e5a28d70c555 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,7 +41,7 @@ endif SUBDIRS += common/errnostring common/protocol common/qemuopts SUBDIRS += common/utils SUBDIRS += common/structs -SUBDIRS += lib docs examples po +SUBDIRS += lib docs examples # The daemon and the appliance. SUBDIRS += common/mlutils @@ -201,6 +201,9 @@ SUBDIRS += \ utils/qemu-boot \ utils/qemu-speed-test +# After all source files were used we can generate the translation strings +SUBDIRS += po + # po-docs must come after tools, inspector. if HAVE_PO4A SUBDIRS += po-docs -- 2.23.0
Richard W.M. Jones
2019-Sep-20 09:05 UTC
Re: [Libguestfs] [PATCH] build: Move po subdir after everything else except po-docs
On Fri, Sep 20, 2019 at 10:53:56AM +0200, Martin Kletzander wrote:> Otherwise it complains about missing files that it has no rules for, for example > `builder/index-parser.c`. > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > --- > Another issue I found when compiling on CentOS 7. Not sure why it happens, but > it only makes sense that the directory that uses files from other directories > (which might be generated) is used after all the code ones. > > Makefile.am | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 1cc21961ae89..e5a28d70c555 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -41,7 +41,7 @@ endif > SUBDIRS += common/errnostring common/protocol common/qemuopts > SUBDIRS += common/utils > SUBDIRS += common/structs > -SUBDIRS += lib docs examples po > +SUBDIRS += lib docs examples > > # The daemon and the appliance. > SUBDIRS += common/mlutils > @@ -201,6 +201,9 @@ SUBDIRS += \ > utils/qemu-boot \ > utils/qemu-speed-test > > +# After all source files were used we can generate the translation strings > +SUBDIRS += po > + > # po-docs must come after tools, inspector. > if HAVE_PO4A > SUBDIRS += po-docsI've pushed this, thanks. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v