search for: qemuopt

Since it does not make much sense, then forbid this situation outright: - change qemuopts_end_arg_list() to return an error if the current arg list has no elements - when creating the argv array, assert that each arg list is not empty --- common/qemuopts/qemuopts.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/common/qemuopts/qemuopts.c b/common...

...nerate a qemu command line in ‘lib/launch-direct.c’, and we might in future need to generate a ‘-readconfig’-compatible configuration file if we want to go beyond 10,000 drives for scalability testing. Therefore this patch series reimplements the qemu command line code as a small C library (common/qemuopts), extends it to support qemu config files, and then reimplements both ‘lib/launch-direct.c’ and ‘virt-v2v -o qemu’ to use it. It also fixes a few bugs. In particular we don't properly comma-quote qemu parameters in multiple places. This fixes all of those places properly. It also drops sup...

Call realloc() directly with the pointer to the old data, instead of assigning it to the destination variable, and using that one. The rest of the code is the same, already properly checking for the results of realloc(), so this mostly help static code analyzers. --- common/qemuopts/qemuopts.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/qemuopts/qemuopts.c b/common/qemuopts/qemuopts.c index c40d44783..b3e69e306 100644 --- a/common/qemuopts/qemuopts.c +++ b/common/qemuopts/qemuopts.c @@ -168,8 +168,7 @@ extend_options (struct qemuopts *qopt...

This option was removed from qemu for no apparent reason except to break existing consumers. It does the same as -no-user-config, added in May 2012, so use that instead. --- builder/test-console.sh | 2 +- common/qemuopts/qemuopts-tests.c | 6 +++--- common/qemuopts/qemuopts.c | 2 +- contrib/p2v/build-p2v-iso.sh | 2 +- contrib/p2v/test-p2v-iso.sh | 2 +- customize/test-firstboot.sh | 2 +- customize/test-password.pl...

Not a thing - tested on P9. --- common/qemuopts/qemuopts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/qemuopts/qemuopts.c b/common/qemuopts/qemuopts.c index 49550bb21..3a8dcae70 100644 --- a/common/qemuopts/qemuopts.c +++ b/common/qemuopts/qemuopts.c @@ -552,7 +552,7 @@ qemuopts_set_binary_by_arch (struct qemuopt...

...mlaugeas is not touched by this change, since it is a copy of a 3rd party library (and thus it will be fixed there first). --- common/mlpcre/pcre-c.c | 3 ++- common/mlprogress/progress-c.c | 3 ++- common/mlxml/xml-c.c | 9 ++++++--- ocaml/guestfs-c.c | 3 ++- v2v/qemuopts-c.c | 3 ++- 5 files changed, 14 insertions(+), 7 deletions(-) diff --git a/common/mlpcre/pcre-c.c b/common/mlpcre/pcre-c.c index 61af616be..da982025f 100644 --- a/common/mlpcre/pcre-c.c +++ b/common/mlpcre/pcre-c.c @@ -97,7 +97,8 @@ static struct custom_operations custom_operations...

GCC 9 gives this error which I believe is bogus: qemuopts.c: In function 'qemuopts_to_config_channel': qemuopts.c:987:29: error: '%.*s' directive output between 0 and 2147483647 bytes may exceed minimum required size of 4095 [-Werror=format-overflow=] 987 | fprintf (fp, " %.*s = ", (int) k, values[j]); |...

...| 1 + 43 files changed, 133 insertions(+), 52 deletions(-) diff --git a/.gitignore b/.gitignore index ef3b9997f..019b96da5 100644 --- a/.gitignore +++ b/.gitignore @@ -137,10 +137,10 @@ Makefile.in /common/protocol/guestfs_protocol.h /common/protocol/guestfs_protocol.x /common/qemuopts/qemuopts-tests -/common/utils/guestfs-internal-frontend-cleanups.h -/common/utils/structs-cleanup.c -/common/utils/structs-print.c -/common/utils/structs-print.h +/common/structs/structs-cleanups.c +/common/structs/structs-cleanups.h +/common/structs/structs-print.c +/common/structs/structs-print....

...-common/mlutils/dummy.c common/mlutils/unix_utils-c.c -common/mlvisit/dummy.c common/mlvisit/visit-c.c common/mlxml/xml-c.c common/options/config.c @@ -43,7 +35,6 @@ common/parallel/domains.c common/parallel/estimate-max-threads.c common/parallel/parallel.c common/progress/progress.c -common/qemuopts/qemuopts-tests.c common/qemuopts/qemuopts.c common/structs/structs-cleanups.c common/structs/structs-print.c @@ -54,9 +45,7 @@ common/utils/utils.c common/visit/visit.c common/windows/windows.c customize/crypt-c.c -customize/dummy.c customize/perl_edit-c.c -customize/test-password.pl daemo...

Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls were prodived to attach an exist tap file descriptor to the tun/tap device. So the patch let qemu to

Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls were prodived to attach an exist tap file descriptor to the tun/tap device. So the patch let qemu to

...(SCSIBus *bus, DriveInfo *dinfo, int unit); void scsi_bus_legacy_handle_cmdline(SCSIBus *bus); +int32_t scsi_build_sense(uint8_t *sense_buf, uint32_t sense); #endif diff --git a/qemu-config.c b/qemu-config.c index 4fb7898..8d7a137 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -18,7 +18,7 @@ QemuOptsList qemu_drive_opts = { },{ .name = "if", .type = QEMU_OPT_STRING, - .help = "interface (ide, scsi, sd, mtd, floppy, pflash, virtio)", + .help = "interface (ide, scsi, raid, sd, mtd, floppy, pflash, virtio)",...

...(SCSIBus *bus, DriveInfo *dinfo, int unit); void scsi_bus_legacy_handle_cmdline(SCSIBus *bus); +int32_t scsi_build_sense(uint8_t *sense_buf, uint32_t sense); #endif diff --git a/qemu-config.c b/qemu-config.c index 4fb7898..8d7a137 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -18,7 +18,7 @@ QemuOptsList qemu_drive_opts = { },{ .name = "if", .type = QEMU_OPT_STRING, - .help = "interface (ide, scsi, sd, mtd, floppy, pflash, virtio)", + .help = "interface (ide, scsi, raid, sd, mtd, floppy, pflash, virtio)",...

Hi all, I have few simple fixes for Xen for the next release: - the first one fixes a regression in qemu-char; - the second one is just a cleanup (that is needed to simplify preprocessor dependencies); - the last one avoids setting nonblocking on Xen (as is already done for KVM). The last two patches should be backported to older branches. Stefano Stabellini (3):

Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls were prodived to attach an exist tap file descriptor to the tun/tap device. So the patch let qemu to

Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls were prodived to attach an exist tap file descriptor to the tun/tap device. So the patch let qemu to

...ct.c > @@ -273,6 +273,26 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data, > return -1; > } > > +/** > + * Add the blockio elements of the C<-device> parameter. > + */ > +static int > +add_device_blockio_params (guestfs_h *g, struct qemuopts *qopts, > + struct drive *drv) > +{ > + if (drv->pblocksize) > + append_list_format ("physical_block_size=%d", drv->pblocksize); > + if (drv->lblocksize) > + append_list_format ("logical_block_size=%d", drv->lblock...

...- a/lib/launch-direct.c +++ b/lib/launch-direct.c @@ -273,6 +273,26 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data, return -1; } +/** + * Add the blockio elements of the C<-device> parameter. + */ +static int +add_device_blockio_params (guestfs_h *g, struct qemuopts *qopts, + struct drive *drv) +{ + if (drv->pblocksize) + append_list_format ("physical_block_size=%d", drv->pblocksize); + if (drv->lblocksize) + append_list_format ("logical_block_size=%d", drv->lblocksize); + + return 0; + + /*...

...is used after all the code ones. Makefile.am | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1cc21961ae89..e5a28d70c555 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,7 +41,7 @@ endif SUBDIRS += common/errnostring common/protocol common/qemuopts SUBDIRS += common/utils SUBDIRS += common/structs -SUBDIRS += lib docs examples po +SUBDIRS += lib docs examples # The daemon and the appliance. SUBDIRS += common/mlutils @@ -201,6 +201,9 @@ SUBDIRS += \ utils/qemu-boot \ utils/qemu-speed-test +# After all source files were used we can...

From: Nicholas Bellinger <nab at linux-iscsi.org> Hi Paolo, Stefan, & QEMU folks, The following is the second RFC series for vhost-scsi patches against mainline QEMU v1.1.0. The series is available from the following working branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-merge Apologies for the delayed follow-up on this series. The changes detailed