search for: errnostring

This commit, which is just code motion, moves the common XDR protocol code (libprotocol) and the common errno handling (liberrnostring) into libraries which are each built once and shared between the library and daemon. --- .gitignore | 20 +++++-------- Makefile.am | 1 + common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++ common/protocol/Makefile.am | 60 ++++++++++++++++...

On Wednesday, 25 January 2017 14:37:10 CET Richard W.M. Jones wrote: > This commit, which is just code motion, moves the common XDR protocol > code (libprotocol) and the common errno handling (liberrnostring) into > libraries which are each built once and shared between the library and > daemon. > --- > guestfsd_SOURCES = \ > + ../common/errnostring/errnostring.h \ > + ../common/protocol/guestfs_protocol.h \ > [...] > libguestfs_la_SOURCES = \ > + ../common/errnostring/er...

...new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol src/liberrnostring -> common/errnostring src/utils -> common/utils cat/visit -> common/visit fish/[various] -> common/options src -> lib I'm planning some other changes in future patches, assuming I have the energy as this is rather tedious work: df/parallel -> common/parallel df/d...

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

...rebuild the generated files. > touch stamp-generator > make[2]: Leaving directory `/tmp/libguestfs/generator' > Making all in src > make[2]: Entering directory `/tmp/libguestfs/src' > rm -f guestfs_protocol.c-t guestfs_protocol.c-t2 > rm -f guestfs_protocol.h-t > rm -f errnostring-gperf.c > rpcgen -DHAVE_XDR_UINT64_T=1 -c -o guestfs_protocol.c-t guestfs_protocol.x > gperf -t errnostring-gperf.gperf > errnostring-gperf.c-t > rpcgen -DHAVE_XDR_UINT64_T=1 -h -o guestfs_protocol.h-t guestfs_protocol.x > guestfs_protocol.x: No such file or directory > make[2]:...

...er/templates/' | \ + grep -v -E '.*_tests\.ml$$' | \ LC_ALL=C sort > $@-t mv $@-t $@ diff --git a/po/POTFILES b/po/POTFILES index 64eb3f9ce..3cd1ddd47 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -12,23 +12,15 @@ cat/log.c cat/ls.c cat/tail.c common/edit/file-edit.c -common/errnostring/errnostring-gperf.c common/errnostring/errnostring.c -common/mlcustomize/dummy.c -common/mlgettext/dummy.c -common/mlpcre/dummy.c common/mlpcre/pcre-c.c common/mlprogress/progress-c.c -common/mlstdutils/dummy.c common/mltools/JSON_parser-c.c -common/mltools/dummy.c common/mltools/getopt-c.c c...

...nged, 4 insertions(+), 4 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index ab3019cc1..25948dbe9 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -217,9 +217,6 @@ guestfsd_LDFLAGS = \ -L../bundled/ocaml-augeas \ -L../common/mlpcre guestfsd_LDADD = \ - ../common/errnostring/liberrnostring.la \ - ../common/protocol/libprotocol.la \ - ../common/utils/libutils.la \ camldaemon.o \ $(ACL_LIBS) \ $(CAP_LIBS) \ @@ -236,7 +233,10 @@ guestfsd_LDADD = \ $(TSK_LIBS) \ $(RPC_LIBS) \ $(YARA_LIBS) \ - $(OCAML_LIBS) + $(OCAML_LIBS) \ + ../common/errnostring/liberrnostrin...

...ts-print.c -/src/structs-print.h -/src/uefi.c /src/unit-tests /stamp-h1 /sysprep/.depend diff --git a/Makefile.am b/Makefile.am index 6049e64..5910a09 100644 --- a/Makefile.am +++ b/Makefile.am @@ -38,7 +38,7 @@ SUBDIRS += gnulib/tests endif # Basic source for the library. -SUBDIRS += common/errnostring common/protocol +SUBDIRS += common/errnostring common/protocol common/utils SUBDIRS += src docs examples po # The daemon and the appliance. diff --git a/align/Makefile.am b/align/Makefile.am index aaa0453..86975a3 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -39,6 +39,7 @@ virt_ali...

...(builder/index-parse\.|builder/index-scan\.|common/mllibvirt/libvirt_c\.c|examples/|gnulib/|gobject/|java/com_redhat_et_libguestfs|perl/|php/extension/config\.h|ruby/ext/guestfs/extconf\.h|tests/|test-data/|3rdparty/)' | \ grep -v -E '/(guestfs|rc)_protocol\.' | \ grep -v -E '.*/errnostring\.' | \ grep -v -E '.*-gperf\.' | \ @@ -328,7 +328,7 @@ po/POTFILES: configure.ac rm -f $@ $@-t cd $(srcdir); \ find $(DIST_SUBDIRS) -name '*.c' -o -name '*.pl' -o -name '*.pm' | \ - grep -v -E '^(examples|gnulib|perl/(blib|examples)|po-docs|tests|test...

Use interfaces files (*.mli files) instead of exporting all symbols randomly. Change the 'file is generated' warnings at the top of generated files so they accurately describe which source file generates each output file. Rich.

...ILES | 1 + docs/guestfs-hacking.pod | 5 + ocaml-dep.sh.in | 1 + 13 files changed, 559 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 4d738d10f..8446d3af5 100644 --- a/.gitignore +++ b/.gitignore @@ -123,6 +123,7 @@ Makefile.in /common/errnostring/errnostring-gperf.gperf /common/errnostring/errnostring.h /common/miniexpect/miniexpect.3 +/common/mlaugeas/.depend /common/mlpcre/.depend /common/mlpcre/pcre_tests /common/mlprogress/.depend diff --git a/Makefile.am b/Makefile.am index e71328a58..e62f2678e 100644 --- a/Makefile.am +++ b/Makef...

..._FILES | 1 - generator/daemon.ml | 8 +++---- 15 files changed, 53 insertions(+), 201 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 0d3dde516..db19594b8 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -49,6 +49,8 @@ endif guestfsd_SOURCES = \ ../common/errnostring/errnostring.h \ ../common/protocol/guestfs_protocol.h \ + ../common/utils/cleanups.h \ + ../common/utils/utils.h \ 9p.c \ acl.c \ actions.h \ @@ -62,7 +64,6 @@ guestfsd_SOURCES = \ cap.c \ checksum.c \ cleanups.c \ - cleanups.h \ cmp.c \ command.c \ command.h \ @@ -178,6 +179,7...

...ectories (which might be generated) is used after all the code ones. Makefile.am | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1cc21961ae89..e5a28d70c555 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,7 +41,7 @@ endif SUBDIRS += common/errnostring common/protocol common/qemuopts SUBDIRS += common/utils SUBDIRS += common/structs -SUBDIRS += lib docs examples po +SUBDIRS += lib docs examples # The daemon and the appliance. SUBDIRS += common/mlutils @@ -201,6 +201,9 @@ SUBDIRS += \ utils/qemu-boot \ utils/qemu-speed-test +# After al...

This is a simpler patch series to add symbol versioning. I have pushed patches 1-3 upstream. Rich.

This rather more complex patch series adds symbol versioning (7/7 shows it in action). This works for me, tested by running old and new virt-inspector binaries against the new library. Rich.

...+++++ generator/csharp.mli | 19 +++++++++++++++++++ generator/customize.mli | 22 ++++++++++++++++++++++ generator/daemon.mli | 23 +++++++++++++++++++++++ generator/docstrings.mli | 34 ++++++++++++++++++++++++++++++++++ generator/erlang.mli | 20 ++++++++++++++++++++ generator/errnostring.mli | 21 +++++++++++++++++++++ generator/events.mli | 20 ++++++++++++++++++++ generator/fish.mli | 28 ++++++++++++++++++++++++++++ generator/gobject.mli | 29 +++++++++++++++++++++++++++++ generator/golang.mli | 19 +++++++++++++++++++ generator/haskell.mli | 19 ++++++++...

[PATCH 1/7] mount: Add mount_vfs_nochroot This is significantly reworked from before. umount is gone as discussed, and variable motion is minimised. [PATCH 2/7] btrfs: Update btrfs_subvolume_list to take Already provisionally ACKed. Previous comment was that cleanup could be tidier. I looked into creating a new cleanup function for fs_buf, but it isn't possible (or simple, anyway) in this

...{ free (buf); return -1;}); r = command (NULL, &err, "umount", buf, NULL); free (buf); diff --git a/po/POTFILES b/po/POTFILES index 60f8d95..69291fa 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -27,6 +27,7 @@ daemon/du.c daemon/echo-daemon.c daemon/errnostring-gperf.c daemon/errnostring.c +daemon/errnostring_gperf.c daemon/ext2.c daemon/fallocate.c daemon/file.c @@ -97,6 +98,7 @@ erlang/erl-guestfs.c fish/alloc.c fish/cmds-gperf.c fish/cmds.c +fish/cmds_gperf.c fish/completion.c fish/config.c fish/copy.c @@ -135,6 +137,7 @@ format/format.c fus...

...------------ 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/Makefile.am b/Makefile.am index d3cf64cc1..ec342225a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -320,6 +320,7 @@ docs/C_SOURCE_FILES: configure.ac grep -v -E '/(guestfs|rc)_protocol\.' | \ grep -v -E '.*/errnostring\.' | \ grep -v -E '.*-gperf\.' | \ + grep -v -E '/dummy.c$$' | \ LC_ALL=C sort -u > $@-t mv $@-t $@ diff --git a/docs/C_SOURCE_FILES b/docs/C_SOURCE_FILES index c2d1c3465..c9fc3533e 100644 --- a/docs/C_SOURCE_FILES +++ b/docs/C_SOURCE_FILES @@ -12,21 +12,14 @@ cat/ls....

From: "Richard W.M. Jones" <rjones at redhat.com> --- configure.ac | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test "$gl_gcc_warnings" = yes; then # Work around warning in src/inspect.c. This seems to be a bug in gcc