Libguestfs - May 2019 - Re: [PATCH v4 2/7] common: Bundle the libvirt-ocaml library for use by virt-v2v

So for patches 2, 6 and 7 ...

I think for 2, we really need a plan, written down, about how and when
we're going to remove the bundled library.  It might be included as a
README in the common/mllibvirt/ directory.  But it needs to be clear
about when it goes and how we're going to work towards that.

For patch 6, I really need to either get rid of the test harness or
move it out somewhere, but your change is fine.

Patch 7 is fine, but depends on patch 2.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v

On Wednesday, 10 April 2019 15:19:54 CEST Richard W.M. Jones
wrote:
> I think for 2, we really need a plan, written down, about how and when
> we're going to remove the bundled library.  It might be included as a
> README in the common/mllibvirt/ directory.  But it needs to be clear
> about when it goes and how we're going to work towards that.
Well, I'm not the libvirt-ocaml maintainer, so I cannot pin down
releases, and deadlines for it.

Note a similar situation applies to ocaml-augeas, bundled when the
daemon was partially rewritten in OCaml. In that case, no similar plan
was done, nor though -- but then, it was not me doing those changes...

-- 
Pino Toscano

On Thu, May 09, 2019 at 10:47:45AM +0200, Pino Toscano
wrote:
> On Wednesday, 10 April 2019 15:19:54 CEST Richard W.M. Jones wrote:
> > I think for 2, we really need a plan, written down, about how and when
> > we're going to remove the bundled library.  It might be included
as a
> > README in the common/mllibvirt/ directory.  But it needs to be clear
> > about when it goes and how we're going to work towards that.
> 
> Well, I'm not the libvirt-ocaml maintainer, so I cannot pin down
> releases, and deadlines for it.
Can you add a README containing the text below to common/mllibvirt/
when you push this series.

----------------------------------------------------------------------
This library is a copy of libvirt-ocaml, temporarily bundled with
libguestfs.  The upstream sources are:

https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary

Please use libvirt-ocaml from upstream if possible.

Before libguestfs 1.42 is released we hope to have unbundled this
library and will require that libvirt-ocaml is used instead.
----------------------------------------------------------------------

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html