Hello dovecot users, I have updated the MANAGESIEVE patch to fix the currently known small problems with the protocol implementation. It is designed for rc28, but also compiles cleanly with the current cvs branch_1_0. Change Log V4 ------------- - Added managesieve_implementation_string setting to the managesieve configuration. This can be used to customize the default "IMPLEMENTATION" capability response (as requested by John Peacock). - Denied ANONYMOUS login until proper support is implemented - Fixed problem with authenticate command regarding continued responses. In V3 only initial response would work. Problem was caused by rc2 -> rc28 upgrade. One of the clear reasons why code duplication is a very bad idea. - Fixed readlink bug as indicated by Timo: return value of readlink can also be -1. - Fixed bug in the regular file rescue code, as introduced in the previous version. Used stat instead of lstat. This caused the symlink to be rescued subsequently in the next activation, thus still overwriting the initially rescued script. This patch still includes (yet another) instance of the CMU Sieve source, as explained in one of my previous e-mails (http://dovecot.org/list/dovecot/2006-July/015016.html). It can be downloaded at: http://sinas.rename-it.nl/~sirius/dovecot-1.0.rc28-MANAGESIEVE-v4.diff.gz A design related README is located at src/managesieve after applying the patch. Have fun testing the patch. Notify me when there are problems. Regards, -- Stephan Bosch stephan at rename-it.nl IRC: Freenode, #dovecot, S[r]us
Stephan Bosch schreef:> Change Log V4 > ------------- > > - Denied ANONYMOUS login until proper support is implementedOops, actually it is only not announced anymore. Anonymous login is still possible. Will be fixed properly in next patch. Shouldn't be awake at this hour... Regards, -- Stephan Bosch stephan at rename-it.nl IRC: Freenode, #dovecot, S[r]us
Robert Schetterer
2007-Apr-07 11:28 UTC
[Dovecot] MANAGESIEVE patch v4 for dovecot 1.0.rc28
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stephan Bosch schrieb:> Hello dovecot users, > > I have updated the MANAGESIEVE patch to fix the currently known small > problems with the protocol implementation. It is designed for rc28, but > also compiles cleanly with the current cvs branch_1_0. > > Change Log V4 > ------------- > > - Added managesieve_implementation_string setting to the managesieve > configuration. This can be used to customize the default > "IMPLEMENTATION" capability response (as requested by John Peacock). > - Denied ANONYMOUS login until proper support is implemented > - Fixed problem with authenticate command regarding continued responses. > In V3 only initial response would work. Problem was caused by rc2 -> > rc28 upgrade. One of the clear reasons why code duplication is a very > bad idea. > - Fixed readlink bug as indicated by Timo: return value of readlink can > also be -1. > - Fixed bug in the regular file rescue code, as introduced in the > previous version. Used stat instead of lstat. This caused the symlink to > be rescued subsequently in the next activation, thus still overwriting > the initially rescued script. > > This patch still includes (yet another) instance of the CMU Sieve > source, as explained in one of my previous e-mails > (http://dovecot.org/list/dovecot/2006-July/015016.html). > > It can be downloaded at: > > http://sinas.rename-it.nl/~sirius/dovecot-1.0.rc28-MANAGESIEVE-v4.diff.gz > > A design related README is located at src/managesieve after applying the > patch. > > Have fun testing the patch. Notify me when there are problems. > > Regards, > > -- > Stephan Bosch > stephan at rename-it.nl > IRC: Freenode, #dovecot, S[r]us >Hi Stephan, i have success with patch dovecot with your patch but having problems in understanding how to configure the sieve server in dovecot.conf , do you have some small faqs for me, the readme wasnt enough for me to do this - -- Mit freundlichen Gruessen Best Regards Robert Schetterer https://www.schetterer.org Munich/Bavaria/Germany -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFGF4BdfGH2AvR16oERAoAEAJ40YWzPARtH9SJA+fksKk5PKX2cDACffURP zMBDPCYmlGS6os33C23r/Gc=I0O5 -----END PGP SIGNATURE-----
Stephan Bosch wrote:> Hello dovecot users, > > I have updated the MANAGESIEVE patch to fix the currently known small > problems with the protocol implementation. It is designed for rc28, > but also compiles cleanly with the current cvs branch_1_0. > > Have fun testing the patch. Notify me when there are problems. > > Regards, > > -- > Stephan Bosch > stephan at rename-it.nl > IRC: Freenode, #dovecot, S[r]us >There is problem; after patch dovecot segfaults if you try to dump settings. file: ./src/master/master-stettings.c in "void master_setting_dump ..." const void *sets [4] const char *set_names[4] must be changed to: const void *sets [5] const char *set_names[5] after you added managesieve settings here, settings max count must be increased too:) -------- patch ------- # diff -r -u -N master-settings.c master-settings.c.new --- master-settings.c 2007-04-17 07:48:04.000000000 +0200 +++ master-settings.c.new 2007-04-19 18:33:02.000000000 +0200 @@ -1584,8 +1584,8 @@ void master_settings_dump(struct server_settings *set, bool nondefaults) { - const void *sets[4]; - const char *set_names[4]; + const void *sets[5]; + const char *set_names[5]; unsigned int count; sets[0] = &default_settings; --------------------- Uldis