Hello, When I tested LDAP auth dovecot-auth caught segv, and I found that auth_cache_parse_key() doesn't check query == NULL. I think db-ldap.c/default_ldap_settings.pass_filter should have non-null default value. Please check following patch. regards, -- Kazuo Moriwaka <moriwaka at valinux.co.jp> Index: db-ldap.c ==================================================================RCS file: /home/cvs/dovecot/src/auth/db-ldap.c,v retrieving revision 1.24 diff -r1.24 db-ldap.c 62c62 < MEMBER(pass_filter) NULL, ---> MEMBER(pass_filter) "(&(objectClass=posixAccount)(uid=%u))",
On Thu, 2005-01-13 at 13:03 +0900, Kazuo Moriwaka wrote:> When I tested LDAP auth dovecot-auth caught segv, and I found that > auth_cache_parse_key() doesn't check query == NULL. > > I think db-ldap.c/default_ldap_settings.pass_filter > should have non-null default value. > > Please check following patch.Yes, it's better that way. I did the same for other defaults as well. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20050113/78e13517/attachment-0001.bin>