dovecot - Dec 2004 - header search for splitted word

Hello, 

I wrote a patch for header search about a word over two lines. 
Please check it.

For example, following header string contains a word 
splitted into two mime encoded block. It's normal behavior of 
MUAs in CJK environment.

Subject:
=?ISO-2022-JP?B?Sk1CGyRCJUQlIiE8JUslZSE8JTkhIRsoQkpBTBskQiVBJWMhPCU/GyhC?
=?ISO-2022-JP?B?GyRCITxKWCRHOVQkLxsoQiAbJEI0WjlxGyhCLxskQiVRJWklKhsoQi8bJEIlNSUkJVElcxsoQg==?
And now, dovecot search command miss to search the word.
    word       : "ABCDE" 
    MIMED      : "AB\r\n\tCDE" 
    search(now): "AB CDE"
     this patch: "ABCDE" 

This patch has a bad side effect that in English or other languages,
two words is connected.

For example, 
> This is a
> sample.
matches to "asample".

I think this is not a big problem, but if there is a good solution,
please let me know.

best regards,
-- 
Kazuo Moriwaka 
moriwaka at valinux.co.jp

Index: src/lib-mail/message-header-search.c
==================================================================RCS file:
/home/cvs/dovecot/src/lib-mail/message-header-search.c,v
retrieving revision 1.13
diff -r1.13 message-header-search.c
149c149
< 			chr = ' ';
---
> 			chr = '\t';
153c153
< 		if (chr == '\r' || chr == '\n')
---
> 		if (chr == '\r' || chr == '\n' || chr == '\t')

On Fri, 2004-12-24 at 20:19 +0900, Kazuo Moriwaka wrote:
> I wrote a patch for header search about a word over two lines. 
> Please check it.
> 
> For example, following header string contains a word 
> splitted into two mime encoded block. It's normal behavior of 
> MUAs in CJK environment.
> 
> Subject:
=?ISO-2022-JP?B?Sk1CGyRCJUQlIiE8JUslZSE8JTkhIRsoQkpBTBskQiVBJWMhPCU/GyhC?> 
=?ISO-2022-JP?B?GyRCITxKWCRHOVQkLxsoQiAbJEI0WjlxGyhCLxskQiVRJWklKhsoQi8bJEIlNSUkJVElcxsoQg==?
The way UW-IMAP (and probably others) do it is that they check if MIME
block continues with another MIME block. If it does, the spaces between
them are ignored.

I think I'll do it that way for Dovecot, but with the current code it's
not that simple change. Maybe it's time for larger fixes in searching
code..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20050106/be7fd319/attachment-0001.bin>