search for: auth_cache_parse_key

Hello, When I tested LDAP auth dovecot-auth caught segv, and I found that auth_cache_parse_key() doesn't check query == NULL. I think db-ldap.c/default_ldap_settings.pass_filter should have non-null default value. Please check following patch. regards, -- Kazuo Moriwaka <moriwaka at valinux.co.jp> Index: db-ldap.c ==============================================================...

...orted into -stable yet ? Thank you, -- Thomas Hummel | Institut Pasteur <hummel at pasteur.fr> | P?le informatique - syst?mes et r?seau -- (gdb) n 186 userdb_preinit(); (gdb) n 187 passdb_preinit(); (gdb) n Program received signal SIGSEGV, Segmentation fault. auth_cache_parse_key (query=0x0) at auth-cache.c:39 39 for (; *query != '\0'; query++) { (gdb) bt full #0 auth_cache_parse_key (query=0x0) at auth-cache.c:39 str = (string_t *) 0x806a100 key_seen = '\0' <repeats 255 times> key = 0 '\0' #1 0x08055456 i...

...unsigned mail-transaction-log-file.c: In function `log_file_track_mailbox_sync_offset_hdr': mail-transaction-log-file.c:682: warning: comparison between signed and unsigned passdb-bsdauth.c: In function `bsdauth_preinit': passdb-bsdauth.c:59: warning: implicit declaration of function `auth_cache_parse_key' passdb-bsdauth.c:60: warning: assignment makes pointer from integer without a cast /Peter -- Peter Lindgren http://www.norrskenkonsult.com

...mail.c: In function 'vpopmail_lookup_credentials': passdb-vpopmail.c:71: warning: pointer targets in passing argument 2 of 'callback' differ in signedness passdb-vpopmail.c: In function 'vpopmail_preinit': passdb-vpopmail.c:141: warning: implicit declaration of function 'auth_cache_parse_key' passdb-vpopmail.c:142: warning: assignment makes pointer from integer without a cast Thanks. -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"

..._new(pool, struct pam_passdb_module, 1); @@ -367,9 +381,14 @@ pam_preinit(pool_t pool, const char *args) } } else if (t_args[i+1] == NULL) { module->service_name = p_strdup(pool, t_args[i]); + } else if (strncmp(t_args[i], "username_format=", 16) == 0) { + format = auth_cache_parse_key(pool, t_args[i] + 16); } else { i_fatal("pam: Unknown setting: %s", t_args[i]); } } + + module->username_format = format; + return &module->module; }

I've been doing some stress testing in the last few days and fixing all the errors I saw. I'm hoping that I've finally really fixed all the index/mbox problems. So, again I think the only thing left for v1.0 is the documentation. Please test this nightly snapshot before I'll release rc27 tomorrow: http://dovecot.org/nightly/dovecot-latest.tar.gz If you've seen any of the