Jay Catherwood
2007-Nov-26 12:17 UTC
[PATCH] Don't draw shaded windows about to be destroyed
--- src/paint.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/paint.c b/src/paint.c index 00cbf73..4ddd332 100644 --- a/src/paint.c +++ b/src/paint.c @@ -193,7 +193,12 @@ paintOutputRegion (CompScreen *screen, if (w->destroyed) continue; - if (!w->shaded) + if (w->shaded) + { + if (w->id < 2) + continue; + } + else { if (w->attrib.map_state != IsViewable || !w->damaged) continue; @@ -232,7 +237,12 @@ paintOutputRegion (CompScreen *screen, if (w == fullscreenWindow) continue; - if (!w->shaded) + if (w->shaded) + { + if (w->id < 2) + continue; + } + else { if (w->attrib.map_state != IsViewable || !w->damaged) continue; -- 1.5.2.5 --dDRMvlgZJXvWKvBx Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-Update-client-list-when-destroying-shaded-windows.patch"
Jay Catherwood
2007-Nov-27 03:02 UTC
[compiz] [PATCH] Don't draw shaded windows about to be destroyed
Hi, On both git master and the Ubuntu Gutsy packages, I have a problem with closing shaded windows when the animation plugin is active: (1) Activate the animation plugin (2) Shade a window (3) Close it The shaded window's titlebar does not disappear when the process exits. The only way to get rid of it is to trigger an animation on a different window. The problem is that the plugin does not release the window until the next animation, and core continues drawing the shaded window's titlebar in the meantime. I don't know if this is a bug in Animation, but it seems like core should be able to handle this case. These patches fix the problem for me. The first patch makes sure core doesn't draw a destroyed shaded window. The second patch updates the client list on destruction, instead of waiting for the next animation. The third patch makes sure that destroyed windows don't interfere with the stacking order. Thanks, Jay -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Don-t-draw-shaded-windows-about-to-be-destroyed.patch Type: text/x-diff Size: 0 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20071126/5d5ba39f/attachment.patch