I've attatched a patch to fix a bug in the latest switcher patches that got put into CVS. Basically, window order with minimized windows is undefined, and this fixes it. Also, I notice that in some cases switcher fails to get an icon for a window. Perhaps the icon code is forcing a search for a specific size, rather than 'best-fit'? Also, the patch allows usage of alt+shift+tab (in default keybindings) to initiate switcher as well. --Quinn -------------- next part -------------- A non-text attachment was scrubbed... Name: switch.diff Type: text/x-patch Size: 3391 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20060507/0b360f04/switch.bin
On Sun, 7 May 2006 22:21:04 -0400 Quinn Storm <livinglatexkali@gmail.com> wrote:> I've attatched a patch to fix a bug in the latest switcher patches > that got put into CVS. Basically, window order with minimized > windows is undefined, and this fixes it. > > Also, I notice that in some cases switcher fails to get an icon for a > window. Perhaps the icon code is forcing a search for a specific > size, rather than 'best-fit'? > > Also, the patch allows usage of alt+shift+tab (in default keybindings) > to initiate switcher as well. > > --QuinnOops, I just realized, there was one more fix I forgot to do to this, I've attatched it now, it handles the 'phantom windows' that sometimes show up in switcher (I hope). Also, I couldn't see why you had the test for inShowDesktopMode in there, I never had it and mine worked ok, if you need it, maybe you can figure out how to put it back in? --Quinn -------------- next part -------------- A non-text attachment was scrubbed... Name: switch.diff Type: text/x-patch Size: 3897 bytes Desc: not available Url : http://lists.freedesktop.org/archives/compiz/attachments/20060507/70e1a564/switch.bin
On Sun, 2006-05-07 at 22:21 -0400, Quinn Storm wrote:> I've attatched a patch to fix a bug in the latest switcher patches that > got put into CVS. Basically, window order with minimized windows is > undefined, and this fixes it.Why would it be undefined? The activation number for each window is used to determine the order and there's nothing special with minimized windows. Seems to be working just fine for me.> > Also, I notice that in some cases switcher fails to get an icon for a > window. Perhaps the icon code is forcing a search for a specific size, > rather than 'best-fit'?Well, for non-minimized windows, I'm searching for an icon smaller or equal to 48x48. If the window doesn't have such an icon it usually doesn't have any icons and I'm not using a default icon in that case. For minimized windows I allow larger icons and I fall-back to a default icon when no icon exist so you should always get an icon for these windows.> > Also, the patch allows usage of alt+shift+tab (in default keybindings) > to initiate switcher as well.Good catch, fixed in CVS now. -David