samba - May 2024 - SAMBA_VERSION_VENDOR_SUFFIX in VERSION

Kia Ora Samba packagers,

I just wanted to ask nicely if you could fill
in SAMBA_VERSION_VENDOR_SUFFIX in the VERSION file when you build
Samba?

Debian does it like this:  
https://salsa.debian.org/samba-team/samba/-/blob/master/debian/rules?ref_type=heads#L163

(that is, a simple sed on the VERSION file)

Likewise if you are a Samba user and use a Samba package that doesn't
do this, can you ask them to add it?

This really helps us when debugging, as we know what package you are
using and so what patches might be applied, or if this is just the
upstream tarball.  In particular the version string given in the crash
backtrace will have this info.
Thanks,

Andrew Bartlett
-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/Samba Team Member
(since 2001) https://samba.orgSamba Team Lead               
https://catalyst.net.nz/services/sambaCatalyst.Net Ltd
Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group
company
Samba Development and Support: https://catalyst.net.nz/services/samba
Catalyst IT - Expert Open Source Solutions

29.05.2024 00:42, Andrew Bartlett via samba-technical
wrote:
> Kia Ora Samba packagers,
> 
> I just wanted to ask nicely if you could fill
> in SAMBA_VERSION_VENDOR_SUFFIX in the VERSION file when you build
> Samba?
> 
> Debian does it like this:
>
https://salsa.debian.org/samba-team/samba/-/blob/master/debian/rules?ref_type=heads#L163
That's an ugly hack really.. :)

It'd be much better if samba had supported a way to specify version
suffix at configure time on command line, like, for example,

  ./configure --local-version-suffix="FooBar-432" ...

or something, like many other software packages does.  Or at the very
least, by specifying it in an *optional*, not included in the upstream
source, file.  Changing an upstream source like this is the ugliest
hack debian samba package now has, I'd say.

(This wasn't that ugly before, when we used a patch-based change to this
file in standard-for-debian place, since quite a few fixes to upstream
issues are needed anyway.  This sed-based approach was used in order to
simplify difference between debian and ubuntu samba packages.  It is
ugly because debian/ubuntu needs a way to undo any distribution-specific
changes to the upstream source, so I had to have a way to undo this.
Which can be made less ugly I guess..)

Myself, I dislike to add such "branding" to samba, in my view it shows
a disrespect to samba upstream developers, - it is samba, not debian-samba.
But that's just me it seems.

Thanks

/mjt
-- 
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF
2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044
65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt