David Binderman
2017-May-02 16:05 UTC
[Nouveau] drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c:124:: possible unintended fallthrough ?
Hello there, drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c:124:18: warning: this statement may fall through [-Wimplicit-fallthrough=] Source code is switch (dmaobj->base.access) { case NV_MEM_ACCESS_RO: dmaobj->flags0 |= 0x00004000; break; case NV_MEM_ACCESS_WO: dmaobj->flags0 |= 0x00008000; case NV_MEM_ACCESS_RW: dmaobj->flags2 |= 0x00000002; break; default: return -EINVAL; } Suggest either document the fallthrough or add the missing break. Regards David Binderman
Reasonably Related Threads
- [PATCH][next] drm/nouveau: Use fallthrough pseudo-keyword
- [PATCH] drm/nouveau/nvkm: mark expected switch fall-throughs
- [PATCH] drm/nouveau/nvkm: mark expected switch fall-throughs
- [PATCH][next] drm/nouveau: Use fallthrough pseudo-keyword
- [PATCH] drm/nouveau/nvkm: mark expected switch fall-throughs