Renato Golin via llvm-dev
2016-Jun-26 23:32 UTC
[llvm-dev] Git Move: GitHub+modules proposal
On 26 June 2016 at 23:02, Anton Korobeynikov <anton at korobeynikov.info> wrote:> Does github allow this? IIRC their support for server-side hooks was > very limited due to obvious reasons. And executing hooks e.g. on > llvm.org seems very error-prone.Someone suggested it was possible. I have sent them an email with a draft proposal and they said everything was fine, though they didn't confirm specific support. I can't see shy changing a local auto-increment ID on the repository itself would be a breach of security, so even if there are limitations, I think we can get this done. I'll send them another email to confirm this specific point. cheers, --renato
Matthias Braun via llvm-dev
2016-Jun-27 00:20 UTC
[llvm-dev] Git Move: GitHub+modules proposal
I really liked the the solution proposed earlier in this thread: Do nothing server side, but instead use `git rev-list --count master` on the client side (which takes 0.9s on my machine) to get the number of the commit. So nothing to do on the ID part IMO. As for updating the meta repository: We could disable write access for the normal llvm developer and delegate the submodule bumping to an external server. I believe this would be an easy enough job for buildbot or jenkins. - Matthias> On Jun 26, 2016, at 4:32 PM, Renato Golin via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 26 June 2016 at 23:02, Anton Korobeynikov <anton at korobeynikov.info> wrote: >> Does github allow this? IIRC their support for server-side hooks was >> very limited due to obvious reasons. And executing hooks e.g. on >> llvm.org seems very error-prone. > > Someone suggested it was possible. I have sent them an email with a > draft proposal and they said everything was fine, though they didn't > confirm specific support. > > I can't see shy changing a local auto-increment ID on the repository > itself would be a breach of security, so even if there are > limitations, I think we can get this done. > > I'll send them another email to confirm this specific point. > > cheers, > --renato > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Renato Golin via llvm-dev
2016-Jun-27 10:18 UTC
[llvm-dev] Git Move: GitHub+modules proposal
On 27 June 2016 at 01:20, Matthias Braun <matze at braunis.de> wrote:> I really liked the the solution proposed earlier in this thread: Do nothing server side, but instead use > `git rev-list --count master` on the client side (which takes 0.9s on my machine) to get the number of the commit. So nothing to do on the ID part IMO.Mehdi replied to this proposal: "it does not help to solve the cross-repository problem, we need a "meta integration repository"."> As for updating the meta repository: We could disable write access for the normal llvm developer and delegate the submodule bumping to an external > server. I believe this would be an easy enough job for buildbot or jenkins.The plan is to disable all write access to this repository (otherwise we'll create a nightmare). Having an external counter could be problematic due to synchronisation issues. If the hook doesn't work, we'll have serious problems. cheers, --renato