llvm dev - Nov 2012 - [LLVMdev] [cfe-dev] !!! 3.2 Release RC2 deadline November 29th

Hello,

 Just a quick reminder that the November 29th (10p.m. PST) is the
end of Phase 1 testing and Release Candidate 2 (RC2) deadline.
After RC2 deadline, LLVM-Clang 3.2 release will be considered feature
complete and no new functionality can be added.

 With 2 days left please use following guidelines when
initiating request for patches before RC2 deadline.

 I will be happy to merge *approved* patches for low risk/
crash fixes that merge cleanly and have simple test case or
procedure to verify correctness (aka 1040 EZ Patch).

Patches that do not fall under the above category need to
be classified as either release blocking (discussed below)
or non release blocking and thus not included in this release.


 Code owners

 I need your input on the state of the release blocking issues as
listed in the Bug 13893 - "Umbrella bug for 3.2 release"

http://llvm.org/bugs/show_bug.cgi?id=13893.

Please review the list below and let me know whether the
listed bugs can be (better yet will be!) fixed in the Phase 2.

If there are other release stopping bugs/issues that you
think should be fixed before the final 3.2 release but
are not listed below then please add them to the
Bug 13893 - "Umbrella bug for 3.2 release".



As of today Tuesday Nov 27th following release blocking
bugs are still open:

12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on
mdbx.f90 confuses dragoneg

13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 extract_vector_elt
0x14214b910, 0x142142c10

14116 - Inliner incorrectly combines cleanup and catch landing pads

14279 - mishandling of implicit move in class with copy-only member

14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning
v4f64 on ARM

14429 - Dragonegg fails to build clang


Pawel

On Nov 27, 2012, at 7:35 PM, Pawel Wodnicki <root at 32bitmicro.com>
wrote:
> Hello,
> 
> Just a quick reminder that the November 29th (10p.m. PST) is the
> end of Phase 1 testing and Release Candidate 2 (RC2) deadline.
> After RC2 deadline, LLVM-Clang 3.2 release will be considered feature
> complete and no new functionality can be added.
> 
> With 2 days left please use following guidelines when
> initiating request for patches before RC2 deadline.
> 
> I will be happy to merge *approved* patches for low risk/
> crash fixes that merge cleanly and have simple test case or
> procedure to verify correctness (aka 1040 EZ Patch).
> 
> Patches that do not fall under the above category need to
> be classified as either release blocking (discussed below)
> or non release blocking and thus not included in this release.
> 
> 
> Code owners
> 
> I need your input on the state of the release blocking issues as
> listed in the Bug 13893 - "Umbrella bug for 3.2 release"
> 
> http://llvm.org/bugs/show_bug.cgi?id=13893.
> 
> Please review the list below and let me know whether the
> listed bugs can be (better yet will be!) fixed in the Phase 2.
> 
> If there are other release stopping bugs/issues that you
> think should be fixed before the final 3.2 release but
> are not listed below then please add them to the
> Bug 13893 - "Umbrella bug for 3.2 release".
> 
> 
Just my two cents ;)
> 
> As of today Tuesday Nov 27th following release blocking
> bugs are still open:
> 
> 12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on
> mdbx.f90 confuses dragoneg
> 
> 13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 >
extract_vector_elt 0x14214b910, 0x142142c10
> 
No action on this bug in 4 months. I don't think It shouldn't be a
release blocker either.
> 14116 - Inliner incorrectly combines cleanup and catch landing pads
> 
I think this one can be moved out as a release blocker. Too much debate and no
action on the bug in over a month.
> 14279 - mishandling of implicit move in class with copy-only member
> 
This would be nice to have, but is self-host in C++11 mode currently tested by
the build bots?
> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning
> v4f64 on ARM
> 
A great bug to fix, but ARM is not a supported target for release criteria
unless someone wants to make this happen for 3.3. So unless it gets fixed soon,
it shouldn't block the release.
> 14429 - Dragonegg fails to build clang
> 
Dragonegg is a part of the release, but my question is.. is bootstrap only
tested at release time (seems like some buildbots must test this)? This should
be changed for 3.3. This seems like a more likely candidate to get fixed for 3.2
though.

Thanks for all your hard work with the release!

-Tanya
> 
> Pawel
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

On 28 Nov 2012, at 17:02, Tanya Lattner wrote:
>> 14116 - Inliner incorrectly combines cleanup and catch landing pads
> 
> I think this one can be moved out as a release blocker. Too much debate and
no action on the bug in over a month.
This bug means that we can't compile at anything over -O1, or we get code
that does the wrong thing (e.g. terminate instead of catching an exception) if a
function with a cleanup is inlined into one with a catch (or possibly the other
way around).  I would really like to see it fixed for 3.2, because it results in
some fairly serious miscompilations.  I discussed it with a few people at the
DevMeeting.

David

We have 10 dragonegg builders in the buildbot.
8 of them bootstrap (all are green) but they build dragonegg with
dragonegg. 2 run test-suit.

Building clang with the dragonegg surely is a good test, but is this a
release requirement?
If it is, we need another builder.

-Galina

On Wed, Nov 28, 2012 at 9:02 AM, Tanya Lattner <lattner at apple.com>
wrote:
>> 14429 - Dragonegg fails to build clang
>>
>
> Dragonegg is a part of the release, but my question is.. is bootstrap only
tested at release time (seems like some buildbots must test this)? This should
be changed for 3.3. This seems like a more likely candidate to get fixed for 3.2
though.

Hi Tanya,
>> As of today Tuesday Nov 27th following release blocking
>> bugs are still open:
>>
>> 12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on
>> mdbx.f90 confuses dragoneg
>>
>> 13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 >>
extract_vector_elt 0x14214b910, 0x142142c10
>>
>
> No action on this bug in 4 months. I don't think It shouldn't be a
release blocker either.
I have a fix!
>
>> 14116 - Inliner incorrectly combines cleanup and catch landing pads
>>
>
> I think this one can be moved out as a release blocker. Too much debate and
no action on the bug in over a month.
>
>> 14279 - mishandling of implicit move in class with copy-only member
>>
>
> This would be nice to have, but is self-host in C++11 mode currently tested
by the build bots?
>
>> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning
>> v4f64 on ARM
>>
>
> A great bug to fix, but ARM is not a supported target for release criteria
unless someone wants to make this happen for 3.3. So unless it gets fixed soon,
it shouldn't block the release.
>
>> 14429 - Dragonegg fails to build clang
>>
>
> Dragonegg is a part of the release, but my question is.. is bootstrap only
tested at release time (seems like some buildbots must test this)? This should
be changed for 3.3. This seems like a more likely candidate to get fixed for 3.2
though.
Dragonegg+LLVM+GCC is bootstrapped on every commit.  However the bootstrap
doesn't include clang, which is a mistake.

Ciao, Duncan.
>
> Thanks for all your hard work with the release!
>
> -Tanya
>
>>
>> Pawel
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

Pawel,

Is it still not too late to merge these patches?

r168471
r168460
r168458
r168456
r168455
r168453
r168450
r168448

These patches fix a bug in mips backend's GOT implementation and add
support for big-GOT relocations.

Thank you.

On Tue, Nov 27, 2012 at 7:35 PM, Pawel Wodnicki <root at 32bitmicro.com>
wrote:
> Hello,
>
>  Just a quick reminder that the November 29th (10p.m. PST) is the
> end of Phase 1 testing and Release Candidate 2 (RC2) deadline.
> After RC2 deadline, LLVM-Clang 3.2 release will be considered feature
> complete and no new functionality can be added.
>
>  With 2 days left please use following guidelines when
> initiating request for patches before RC2 deadline.
>
>  I will be happy to merge *approved* patches for low risk/
> crash fixes that merge cleanly and have simple test case or
> procedure to verify correctness (aka 1040 EZ Patch).
>
> Patches that do not fall under the above category need to
> be classified as either release blocking (discussed below)
> or non release blocking and thus not included in this release.
>
>
>  Code owners
>
>  I need your input on the state of the release blocking issues as
> listed in the Bug 13893 - "Umbrella bug for 3.2 release"
>
> http://llvm.org/bugs/show_bug.cgi?id=13893.
>
> Please review the list below and let me know whether the
> listed bugs can be (better yet will be!) fixed in the Phase 2.
>
> If there are other release stopping bugs/issues that you
> think should be fixed before the final 3.2 release but
> are not listed below then please add them to the
> Bug 13893 - "Umbrella bug for 3.2 release".
>
>
>
> As of today Tuesday Nov 27th following release blocking
> bugs are still open:
>
> 12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on
> mdbx.f90 confuses dragoneg
>
> 13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 >
extract_vector_elt 0x14214b910, 0x142142c10
>
> 14116 - Inliner incorrectly combines cleanup and catch landing pads
>
> 14279 - mishandling of implicit move in class with copy-only member
>
> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning
> v4f64 on ARM
>
> 14429 - Dragonegg fails to build clang
>
>
> Pawel
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121129/ef229eaa/attachment.html>

Akira,
> Pawel,
> 
> Is it still not too late to merge these patches?
> 
> r168471
> r168460
> r168458
> r168456
> r168455
> r168453
> r168450
> r168448
> 
> These patches fix a bug in mips backend's GOT implementation and add
> support for big-GOT relocations.
That's quite a list of patches! To get them into the
3.2 release you would first need to get approval from all
the code owners and then we would have to merge and test.
Frankly, I do not see how we could get all that done
without delaying the release, RC2 deadline is today
at 10p.m. PST.

Pawel
> 
> Thank you.
> 
> On Tue, Nov 27, 2012 at 7:35 PM, Pawel Wodnicki <root at
32bitmicro.com> wrote:
> 
>> Hello,
>>
>>  Just a quick reminder that the November 29th (10p.m. PST) is the
>> end of Phase 1 testing and Release Candidate 2 (RC2) deadline.
>> After RC2 deadline, LLVM-Clang 3.2 release will be considered feature
>> complete and no new functionality can be added.
>>
>>  With 2 days left please use following guidelines when
>> initiating request for patches before RC2 deadline.
>>
>>  I will be happy to merge *approved* patches for low risk/
>> crash fixes that merge cleanly and have simple test case or
>> procedure to verify correctness (aka 1040 EZ Patch).
>>
>> Patches that do not fall under the above category need to
>> be classified as either release blocking (discussed below)
>> or non release blocking and thus not included in this release.
>>
>>
>>  Code owners
>>
>>  I need your input on the state of the release blocking issues as
>> listed in the Bug 13893 - "Umbrella bug for 3.2 release"
>>
>> http://llvm.org/bugs/show_bug.cgi?id=13893.
>>
>> Please review the list below and let me know whether the
>> listed bugs can be (better yet will be!) fixed in the Phase 2.
>>
>> If there are other release stopping bugs/issues that you
>> think should be fixed before the final 3.2 release but
>> are not listed below then please add them to the
>> Bug 13893 - "Umbrella bug for 3.2 release".
>>
>>
>>
>> As of today Tuesday Nov 27th following release blocking
>> bugs are still open:
>>
>> 12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on
>> mdbx.f90 confuses dragoneg
>>
>> 13561 -  LLVM ERROR: Cannot select: 0x14214bb10: i16 >>
extract_vector_elt 0x14214b910, 0x142142c10
>>
>> 14116 - Inliner incorrectly combines cleanup and catch landing pads
>>
>> 14279 - mishandling of implicit move in class with copy-only member
>>
>> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning
>> v4f64 on ARM
>>
>> 14429 - Dragonegg fails to build clang
>>
>>
>> Pawel
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>