llvm dev - Apr 2019 - How to submit a change for code review using arc

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick
Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup
reviewers my editor pops up and there is a "Reviewers:" line and but
I'm unable email addresses directly. It seems it wants reviewers
passed on the command line or some how in .arcconfig.

But I haven't been able to find any documentation on how to setup
reviewers so I've guessed you can add it to .git/arc/config:

What I've got now is my .git/arc/config is:
 {
  "editor": "vim",
  "reviewers": {
    "peterc": "peter at pcc.me.uk",
    "evgeniys": "eugeni.stepanov at gmail.com",
    "llvm-commits": "llvm-commits at lists.llvm.org"
   }
 }

My commit message is:
 $ git log -1
 commit f04a938e5ad72afbf64242718d456fa480ad5f6b (HEAD ->
compiler-rt-fix-cmake-warnings)
 Author: Wink Saville <wink at saville.com>
 Date:   Tue Apr 23 16:55:21 2019 -0700

    [compiler-rt] Fix cmake warnings

    Summary:
    - Fix cmake BOOL misspellings
    - Set cmake policy for CMP0075 to NEW

    Reviewers: peterc, evgeniys

    Subscribers: llvm-commits

The result of "arc diff master" is:
 $ arc diff master
 You have untracked files in this working copy.

 Working copy: /home/wink/prgs/llvm/llvm-project/

 Commit message has errors:

      - Error parsing field "Reviewers": The objects you have listed
include
      objects which do not exist (peterc, evgeniys).

 You must resolve these errors to continue.

    Do you want to edit the message? [Y/n] n

 Usage Exception: Message has unresolved errors.

Help appreciated.

[1]: https://llvm.org/docs/Phabricator.html
[2]:
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/
[3]: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/

The username has to exist on phabricator:
https://reviews.llvm.org/p/peterc/   -> 404
https://reviews.llvm.org/p/evgeniys/ -> 404

I'm guessing you want:
https://reviews.llvm.org/p/daemon/ -> Evgeniy
https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne


---------------------------------------
Johannes Doerfert
Researcher

Argonne National Laboratory
Lemont, IL 60439, USA

jdoerfert at anl.gov

________________________________________
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Wink
Saville via llvm-dev <llvm-dev at lists.llvm.org>
Sent: Thursday, April 25, 2019 22:08
To: llvm-dev
Subject: [llvm-dev] How to submit a change for code review using arc

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick
Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup
reviewers my editor pops up and there is a "Reviewers:" line and but
I'm unable email addresses directly. It seems it wants reviewers
passed on the command line or some how in .arcconfig.

But I haven't been able to find any documentation on how to setup
reviewers so I've guessed you can add it to .git/arc/config:

What I've got now is my .git/arc/config is:
 {
  "editor": "vim",
  "reviewers": {
    "peterc": "peter at pcc.me.uk",
    "evgeniys": "eugeni.stepanov at gmail.com",
    "llvm-commits": "llvm-commits at lists.llvm.org"
   }
 }

My commit message is:
 $ git log -1
 commit f04a938e5ad72afbf64242718d456fa480ad5f6b (HEAD ->
compiler-rt-fix-cmake-warnings)
 Author: Wink Saville <wink at saville.com>
 Date:   Tue Apr 23 16:55:21 2019 -0700

    [compiler-rt] Fix cmake warnings

    Summary:
    - Fix cmake BOOL misspellings
    - Set cmake policy for CMP0075 to NEW

    Reviewers: peterc, evgeniys

    Subscribers: llvm-commits

The result of "arc diff master" is:
 $ arc diff master
 You have untracked files in this working copy.

 Working copy: /home/wink/prgs/llvm/llvm-project/

 Commit message has errors:

      - Error parsing field "Reviewers": The objects you have listed
include
      objects which do not exist (peterc, evgeniys).

 You must resolve these errors to continue.

    Do you want to edit the message? [Y/n] n

 Usage Exception: Message has unresolved errors.

Help appreciated.

[1]: https://llvm.org/docs/Phabricator.html
[2]:
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/
[3]: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <jdoerfert at anl.gov>
wrote:
>
> The username has to exist on phabricator:
> https://reviews.llvm.org/p/peterc/   -> 404
> https://reviews.llvm.org/p/evgeniys/ -> 404
>
> I'm guessing you want:
> https://reviews.llvm.org/p/daemon/ -> Evgeniy
> https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne
Thanks, using daemon and pcc worked. I must say the documentation I
found wasn't helpful, so thanks for the prompt reply!!