search for: phabriactor

...update in order to request commit access to the GitHub repository. All you need to do is add a line in the form of $SVN_USERNAME:$GITHUB_USERNAME Please add your information to this file before SVN becomes readonly on October 21 to avoid a gap in commit access. More details can be found in the phabriactor review[2] that updates the developer policy. We will be verifying that the svn committer matches the username in the file, so you can only request access for yourself and not someone else Thanks, Tom [1] https://llvm.org/viewvc/llvm-project/meta/trunk/github-usernames.txt?view=markup [2] https:/...

...b repository. >> All you need to do is add a line in the form of >> $SVN_USERNAME:$GITHUB_USERNAME >> >> Please add your information to this file before SVN becomes readonly >> on October 21 to avoid a gap in commit access. More details can be found in >> the phabriactor review[2] that updates the developer policy. >> >> We will be verifying that the svn committer matches the username in the >> file, so you can only request access for yourself and not someone else >> >> Thanks, >> Tom >> >> [1] https://llvm.org/vie...

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup reviewers my editor pops up and there is a "Reviewers:" line and but I'm unable email addresses directly. It seems it wants reviewers passed on the command line or some how in .arcconfig. But...

...al data, track conversations (including the ability to cross-link), and so on. I think that we should first explore the solution that Facebook uses or used, see: https://github.com/facebook/hhvm/wiki/What-is-Phabricator They had an import system that, when a PR was submitted, would import it into Phabriactor and post a reply providing an explanation and a link to the imported differential. This might be the right balance between ease of use for casual contributors and the needs of the more-regular contributors providing the code review (and, likely, those actually committing changes). Other projects h...

...link), >> and so on. >> >> I think that we should first explore the solution that Facebook uses or >> used, see: https://github.com/facebook/hhvm/wiki/What-is-Phabricator >> >> They had an import system that, when a PR was submitted, would import it >> into Phabriactor and post a reply providing an explanation and a link to >> the imported differential. This might be the right balance between ease of >> use for casual contributors and the needs of the more-regular contributors >> providing the code review (and, likely, those actually committing...

...n. >>> >>> I think that we should first explore the solution that Facebook uses or >>> used, see: https://github.com/facebook/hhvm/wiki/What-is-Phabricator >>> >>> They had an import system that, when a PR was submitted, would import it >>> into Phabriactor and post a reply providing an explanation and a link to >>> the imported differential. This might be the right balance between ease of >>> use for casual contributors and the needs of the more-regular contributors >>> providing the code review (and, likely, those actually...

On Thu, Nov 7, 2019 at 3:09 AM Roman Lebedev via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Strong -1 personally. Likewise, for many of the same reasons detailed below. ~Aaron > * What is the endgoal? To fully kill phab and move to github pullrequests? > it might be best to discuss *that* first. (did i miss an RFC?) > * Separation of attention - does everyone who