llvm dev - Apr 2019 - How to submit a change for code review using arc

On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <jdoerfert at anl.gov>
wrote:
>
> The username has to exist on phabricator:
> https://reviews.llvm.org/p/peterc/   -> 404
> https://reviews.llvm.org/p/evgeniys/ -> 404
>
> I'm guessing you want:
> https://reviews.llvm.org/p/daemon/ -> Evgeniy
> https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne
Thanks, using daemon and pcc worked. I must say the documentation I
found wasn't helpful, so thanks for the prompt reply!!

Hi Wink:

On Fri, Apr 26, 2019 at 10:53 AM Wink Saville via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <jdoerfert at
anl.gov>
> wrote:
> >
> > The username has to exist on phabricator:
> > https://reviews.llvm.org/p/peterc/   -> 404
> > https://reviews.llvm.org/p/evgeniys/ -> 404
> >
> > I'm guessing you want:
> > https://reviews.llvm.org/p/daemon/ -> Evgeniy
> > https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne
>
> Thanks, using daemon and pcc worked. I must say the documentation I
> found wasn't helpful, so thanks for the prompt reply!!
>
While it's still fresh in your mind, you might consider updating
https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst)
based on your experience,
which will make it easier for future contributors.  I guess the main issue
is getting used to the fact that Phabricator user names are independent and
must be looked up on the web site -- at least I haven't found any other way
-- but that isn't spelled out anywhere.

thanks again...
don

> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190427/81746cce/attachment.html>

> While it's still fresh in your mind, you might consider updating
https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst)
based on your experience,
> which will make it easier for future contributors.  I guess the main issue
is getting used to the fact that Phabricator user names are independent and must
be looked up on the web site -- at least I haven't found any other way --
but that isn't spelled out anywhere.
>
> thanks again...
> don
Yes I'll see what I can do to improve the documentation.

Since github seems to be a well known workflow and seems to work OK,
it would be nice if that could be used. Is anyone working on that?

Is there an RFC or some such on what are the requirements for code
reviews/pull requests?

-- Wink