llvm dev - Jun 2018 - [LNT] Tests for web UI/javascript?

Hello.
We've started using LNT and found it very handy. However, we found that LNT
web UI is missing some features to help our use-cases.
We'd like to add them (and already started doing so) but it's hard to
add them without breaking existing features/workflows because while LNT has some
python CLI test coverage the dynamic Web part (mainly JS UI) is not really
tested.
So our question is - are there any plans to introduce testing to this part of
LNT? Were there any discussions on this topic? Maybe the LNT developers has
already decided on the testing framework or have some candidates in mind?
We'd want to help implement this so it's important to use the same
tools.

Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180628/fd3d693e/attachment.html>

For checking HTML output: There are some tests in lnt/tests/server/ui/V4Pages.py
(and similar) that look at the produced html output. I also recommend installing
pytidylib and running the testsuite with --use-tidylib to catch additional html
errors.

I don't think we have anything testing the javascript parts, would be nice
to see some additional test coverage there[1].

- Matthias


[1] I personally am a compiler developer with little experience in web
development. I don't know what strategies exist to test javascript embedded
in a webpage...
> On Jun 28, 2018, at 9:48 AM, Danila Malyutin via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> Hello. 
> We’ve started using LNT and found it very handy. However, we found that LNT
web UI is missing some features to help our use-cases.
> We’d like to add them (and already started doing so) but it’s hard to add
them without breaking existing features/workflows because while LNT has some
python CLI test coverage the dynamic Web part (mainly JS UI) is not really
tested.
> So our question is – are there any plans to introduce testing to this part
of LNT? Were there any discussions on this topic? Maybe the LNT developers has
already decided on the testing framework or have some candidates in mind?
> We’d want to help implement this so it’s important to use the same tools.
> 
> Thanks.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
<http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180628/d8539508/attachment-0001.html>

There was this PR to use Jasmine:

https://reviews.llvm.org/D20161

But I think it did not make it into tree.  Kristof, any update on the issues you
were encountering? We could move forward with that.  I think we were pretty
agnostic to which framework to use as long as it was not hard to install.

JS Testing would be *really* good. I have debugged a lot of issues recently that
ended up in the JS.


> On Jun 28, 2018, at 10:35 AM, Matthias Braun via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> For checking HTML output: There are some tests in
lnt/tests/server/ui/V4Pages.py (and similar) that look at the produced html
output. I also recommend installing pytidylib and running the testsuite with
--use-tidylib to catch additional html errors.
> 
> I don't think we have anything testing the javascript parts, would be
nice to see some additional test coverage there[1].
> 
> - Matthias
> 
> 
> [1] I personally am a compiler developer with little experience in web
development. I don't know what strategies exist to test javascript embedded
in a webpage...
> 
>> On Jun 28, 2018, at 9:48 AM, Danila Malyutin via llvm-dev <llvm-dev
at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
>> 
>> Hello. 
>> We’ve started using LNT and found it very handy. However, we found that
LNT web UI is missing some features to help our use-cases.
>> We’d like to add them (and already started doing so) but it’s hard to
add them without breaking existing features/workflows because while LNT has some
python CLI test coverage the dynamic Web part (mainly JS UI) is not really
tested.
>> So our question is – are there any plans to introduce testing to this
part of LNT? Were there any discussions on this topic? Maybe the LNT developers
has already decided on the testing framework or have some candidates in mind?
>> We’d want to help implement this so it’s important to use the same
tools.
>> 
>> Thanks.
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
<http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180628/92fe8ffa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3391 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180628/92fe8ffa/attachment.bin>