Please add llvm-commits as a subscriber to all of these reviews so everyone has a chance to see/comment on them. Thanks, --paulr> -----Original Message----- > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena > Lepilkina via llvm-dev > Sent: Friday, July 15, 2016 6:05 AM > To: llvm-dev > Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > > Hi all, > > Now all discussed enhancements are divided into separate patches. > Moreover I have found mistake which reduces performance. Now it's fixed. > > List of patches (for those interested): > Repeats in regular expressions - https://reviews.llvm.org/D22342 > Including files - https://reviews.llvm.org/D22344 > Expressions repeat for CHECK and CHECK-NEXT - > https://reviews.llvm.org/D22345 > CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 > CHECK-WORD - https://reviews.llvm.org/D22353 > prefixes-regular expressions - https://reviews.llvm.org/D22401 > pattern templates - https://reviews.llvm.org/D22403. > > Thanks, > Elena. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Nemanja Ivanovic via llvm-dev
2016-Jul-15 16:19 UTC
[llvm-dev] RFC: FileCheck Enhancements
Hi Elena, Sorry if my question is something you've previously addressed. I didn't comment on the reviews themselves as I don't have any expertise with the implementation of FileCheck. However, much like most LLVM developers, I actively use the tool. A brief look at the patches does not show updates to the documentation. I'm sure that many LLVM developers like myself will gladly use new features if they prove useful, but we just need to know about them. Rather than the source, I personally get information about how to use it from here: http://llvm.org/docs/CommandGuide/FileCheck.html. So I would say that for most of us, if the feature is not documented there, it is as if it doesn't exist. Is there a separate patch (or a plan to put one up for review) for the documentation updates? Thanks, Nemanja On Fri, Jul 15, 2016 at 5:58 PM, Robinson, Paul via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Please add llvm-commits as a subscriber to all of these reviews > so everyone has a chance to see/comment on them. > Thanks, > --paulr > > > -----Original Message----- > > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of > Elena > > Lepilkina via llvm-dev > > Sent: Friday, July 15, 2016 6:05 AM > > To: llvm-dev > > Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > > > > Hi all, > > > > Now all discussed enhancements are divided into separate patches. > > Moreover I have found mistake which reduces performance. Now it's fixed. > > > > List of patches (for those interested): > > Repeats in regular expressions - https://reviews.llvm.org/D22342 > > Including files - https://reviews.llvm.org/D22344 > > Expressions repeat for CHECK and CHECK-NEXT - > > https://reviews.llvm.org/D22345 > > CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 > > CHECK-WORD - https://reviews.llvm.org/D22353 > > prefixes-regular expressions - https://reviews.llvm.org/D22401 > > pattern templates - https://reviews.llvm.org/D22403. > > > > Thanks, > > Elena. > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160715/fd3f212d/attachment.html>
> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Please add llvm-commits as a subscriber to all of these reviews > so everyone has a chance to see/comment on them.Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews. If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start. — Mehdi> Thanks, > --paulr > >> -----Original Message----- >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena >> Lepilkina via llvm-dev >> Sent: Friday, July 15, 2016 6:05 AM >> To: llvm-dev >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements >> >> Hi all, >> >> Now all discussed enhancements are divided into separate patches. >> Moreover I have found mistake which reduces performance. Now it's fixed. >> >> List of patches (for those interested): >> Repeats in regular expressions - https://reviews.llvm.org/D22342 >> Including files - https://reviews.llvm.org/D22344 >> Expressions repeat for CHECK and CHECK-NEXT - >> https://reviews.llvm.org/D22345 >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 >> CHECK-WORD - https://reviews.llvm.org/D22353 >> prefixes-regular expressions - https://reviews.llvm.org/D22401 >> pattern templates - https://reviews.llvm.org/D22403. >> >> Thanks, >> Elena. >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> On Jul 15, 2016, at 5:36 PM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > >> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> Please add llvm-commits as a subscriber to all of these reviews >> so everyone has a chance to see/comment on them. > > Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews. > If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start.Ah, oops. I've started reviews of a few of the patches. If you plan on re-creating the reviews, please mark the relevant in-line comments on these as "Done" so it's easier to track what's changed: D22353, D22403, D22344. thanks vedant> > > — > Mehdi > > >> Thanks, >> --paulr >> >>> -----Original Message----- >>> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena >>> Lepilkina via llvm-dev >>> Sent: Friday, July 15, 2016 6:05 AM >>> To: llvm-dev >>> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements >>> >>> Hi all, >>> >>> Now all discussed enhancements are divided into separate patches. >>> Moreover I have found mistake which reduces performance. Now it's fixed. >>> >>> List of patches (for those interested): >>> Repeats in regular expressions - https://reviews.llvm.org/D22342 >>> Including files - https://reviews.llvm.org/D22344 >>> Expressions repeat for CHECK and CHECK-NEXT - >>> https://reviews.llvm.org/D22345 >>> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 >>> CHECK-WORD - https://reviews.llvm.org/D22353 >>> prefixes-regular expressions - https://reviews.llvm.org/D22401 >>> pattern templates - https://reviews.llvm.org/D22403. >>> >>> Thanks, >>> Elena. >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Hi, I thought documentation will be changed after review if some changes are accepted. But as I need to create new patches because of next comments, I’ll add changes in documentation. Thanks, Elena. From: Nemanja Ivanovic [mailto:nemanja.i.ibm at gmail.com] Sent: Friday, July 15, 2016 7:19 PM To: Robinson, Paul <paul.robinson at sony.com> Cc: Elena Lepilkina <Elena.Lepilkina at synopsys.com>; llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] RFC: FileCheck Enhancements Hi Elena, Sorry if my question is something you've previously addressed. I didn't comment on the reviews themselves as I don't have any expertise with the implementation of FileCheck. However, much like most LLVM developers, I actively use the tool. A brief look at the patches does not show updates to the documentation. I'm sure that many LLVM developers like myself will gladly use new features if they prove useful, but we just need to know about them. Rather than the source, I personally get information about how to use it from here: http://llvm.org/docs/CommandGuide/FileCheck.html. So I would say that for most of us, if the feature is not documented there, it is as if it doesn't exist. Is there a separate patch (or a plan to put one up for review) for the documentation updates? Thanks, Nemanja On Fri, Jul 15, 2016 at 5:58 PM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Please add llvm-commits as a subscriber to all of these reviews so everyone has a chance to see/comment on them. Thanks, --paulr> -----Original Message----- > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org<mailto:llvm-dev-bounces at lists.llvm.org>] On Behalf Of Elena > Lepilkina via llvm-dev > Sent: Friday, July 15, 2016 6:05 AM > To: llvm-dev > Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > > Hi all, > > Now all discussed enhancements are divided into separate patches. > Moreover I have found mistake which reduces performance. Now it's fixed. > > List of patches (for those interested): > Repeats in regular expressions - https://reviews.llvm.org/D22342 > Including files - https://reviews.llvm.org/D22344 > Expressions repeat for CHECK and CHECK-NEXT - > https://reviews.llvm.org/D22345 > CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 > CHECK-WORD - https://reviews.llvm.org/D22353 > prefixes-regular expressions - https://reviews.llvm.org/D22401 > pattern templates - https://reviews.llvm.org/D22403. > > Thanks, > Elena. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev_______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/fc531738/attachment.html>
It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually? On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <llvm-dev at lists.llvm.org> wrote:> > On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > Please add llvm-commits as a subscriber to all of these reviews > > so everyone has a chance to see/comment on them. > > Adding llvm-commits after the fact ends up in the mailing list not > archiving the context of the reviews. > If these patches are fresh (no significant review occurred), they should > be closed and new revisions need to be opened, with llvm-commits as a > subscriber from the start. > > > — > Mehdi > > > > Thanks, > > --paulr > > > >> -----Original Message----- > >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of > Elena > >> Lepilkina via llvm-dev > >> Sent: Friday, July 15, 2016 6:05 AM > >> To: llvm-dev > >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > >> > >> Hi all, > >> > >> Now all discussed enhancements are divided into separate patches. > >> Moreover I have found mistake which reduces performance. Now it's fixed. > >> > >> List of patches (for those interested): > >> Repeats in regular expressions - https://reviews.llvm.org/D22342 > >> Including files - https://reviews.llvm.org/D22344 > >> Expressions repeat for CHECK and CHECK-NEXT - > >> https://reviews.llvm.org/D22345 > >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 > >> CHECK-WORD - https://reviews.llvm.org/D22353 > >> prefixes-regular expressions - https://reviews.llvm.org/D22401 > >> pattern templates - https://reviews.llvm.org/D22403. > >> > >> Thanks, > >> Elena. > >> _______________________________________________ > >> LLVM Developers mailing list > >> llvm-dev at lists.llvm.org > >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/451d93f7/attachment.html>