llvm dev - Jun 2016 - Regarding a TODO in InstructionCombining

Hi,

This is regarding a TODO mentioned in getIdentityValue function in
InstructionCombining.cpp file.

//TODO: We can handle other cases e.g. Instruction::And, Instruction::Or
etc.

I wanted to know what could be the use cases of implementing these. When I
tried implementing these and wrote test cases for the same, the test cases
would be optimized in InstructionSimplify before hitting the code in
Instruction Combining. Can anyone suggest me where I might be going wrong.

Thanks,
Mayur
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160612/d12fd9d7/attachment.html>

Ping.

On Sun, Jun 12, 2016 at 9:39 PM, Mayur P <mayur170988 at gmail.com> wrote:
> Hi,
>
> This is regarding a TODO mentioned in getIdentityValue function in
> InstructionCombining.cpp file.
>
> //TODO: We can handle other cases e.g. Instruction::And, Instruction::Or
> etc.
>
> I wanted to know what could be the use cases of implementing these. When I
> tried implementing these and wrote test cases for the same, the test cases
> would be optimized in InstructionSimplify before hitting the code in
> Instruction Combining. Can anyone suggest me where I might be going wrong.
>
> Thanks,
> Mayur
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160624/9511369c/attachment.html>

CC David.

> On Jun 23, 2016, at 9:07 PM, Mayur P via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> Ping.
> 
> On Sun, Jun 12, 2016 at 9:39 PM, Mayur P <mayur170988 at gmail.com
<mailto:mayur170988 at gmail.com>> wrote:
> Hi,
> 
> This is regarding a TODO mentioned in getIdentityValue function in
InstructionCombining.cpp file.
> 
> //TODO: We can handle other cases e.g. Instruction::And, Instruction::Or
etc.
> 
> I wanted to know what could be the use cases of implementing these. When I
tried implementing these and wrote test cases for the same, the test cases would
be optimized in InstructionSimplify before hitting the code in Instruction
Combining. Can anyone suggest me where I might be going wrong.
> 
> Thanks,
> Mayur
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160706/102c48fa/attachment.html>