James Y Knight via llvm-dev
2016-May-19 18:59 UTC
[llvm-dev] Phabricator not getting all comments sent by email?
Does anyone know why phab sometimes misses replies sent by email? Usually they make it through, but sometimes not. For example, a recent email from Rafael (which I got through the llvm-commits list) seems to be addressed to the proper thing @ reviews.llvm.org, yet seems to have never made it onto the website. Not having not seen that response (because I was looking on the website), I ended up writing effectively the same thing a second time. Oops. From: Rafael EspĂndola <llvm-commits at lists.llvm.org> Date: Thu, May 19, 2016 at 7:13 AM Subject: Re: [PATCH] D20337: [MC] Support symbolic expressions in assembly directives To: reviews+D20337+public+c956a2297e76c848 at reviews.llvm.org Cc: llvm-commits <llvm-commits at lists.llvm.org> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160519/16ecd0a4/attachment.html>
Tim Northover via llvm-dev
2016-May-19 19:21 UTC
[llvm-dev] Phabricator not getting all comments sent by email?
On 19 May 2016 at 11:59, James Y Knight via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Does anyone know why phab sometimes misses replies sent by email? Usually > they make it through, but sometimes not.I think I've noticed it dropping e-mails that start with quotes before, and certainly ignoring everything below the first quote line. It seems to assume everyone will be top-posting. Tim.
James Y Knight via llvm-dev
2016-May-19 19:54 UTC
[llvm-dev] Phabricator not getting all comments sent by email?
GAH! Sigh.... :( That is indeed what it does. See stripQuotedText in src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php if anyone's interested in hacking on php code, it looks like it might be fairly straightforward to have it strip only the lines starting with ">" after the "On ... wrote:" line. On Thu, May 19, 2016 at 3:21 PM, Tim Northover <t.p.northover at gmail.com> wrote:> On 19 May 2016 at 11:59, James Y Knight via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > Does anyone know why phab sometimes misses replies sent by email? Usually > > they make it through, but sometimes not. > > I think I've noticed it dropping e-mails that start with quotes > before, and certainly ignoring everything below the first quote line. > It seems to assume everyone will be top-posting. > > Tim. >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160519/058df6af/attachment.html>
Renato Golin via llvm-dev
2016-May-20 18:06 UTC
[llvm-dev] Phabricator not getting all comments sent by email?
On 19 May 2016 at 19:59, James Y Knight via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Does anyone know why phab sometimes misses replies sent by email? Usually > they make it through, but sometimes not.Doesn't seem to be a trivial thing to do: https://secure.phabricator.com/T7358 https://secure.phabricator.com/T5181 cheers, --renato
James Y Knight via llvm-dev
2016-May-25 15:20 UTC
[llvm-dev] Phabricator not getting all comments sent by email?
Just ran into another thread where phabricator is seemingly ignoring replies. This one seems to be a different issue. In the thread "[PATCH] D20337: [MC] Support symbolic expressions in assembly directives", Phabricator seems to have completely ignored all of the replies starting with my (emailed) reply earlier today: "The .s does have a way to carry the location.". Except for the latest "test" email, where I moved the phab address from the "Cc" line to the "To" line. It seems to have gotten that. So maybe it ignores emails unless it sees itself in "To:"??? On Fri, May 20, 2016 at 2:06 PM, Renato Golin <renato.golin at linaro.org> wrote:> On 19 May 2016 at 19:59, James Y Knight via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > Does anyone know why phab sometimes misses replies sent by email? Usually > > they make it through, but sometimes not. > > Doesn't seem to be a trivial thing to do: > > https://secure.phabricator.com/T7358 > > https://secure.phabricator.com/T5181 > > cheers, > --renato >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160525/d9dd2f5b/attachment.html>