Joerg Sonnenberger via llvm-dev
2016-Jan-08 15:39 UTC
[llvm-dev] Phabricator/Arcanist feedback
On Fri, Jan 08, 2016 at 09:29:01AM -0600, Krzysztof Parzyszek via llvm-dev wrote:> On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote: > > > >One thing that bit me a few times is the fact that the Differential > >Revision: line must be the last (non-empty) line in the commit message. > >If you add things like “This fixes …” behind it then it won’t get > >recognized. > > My biggest grievance with Phabricator is that you can't just close a > revision manually. It seems that unless you use arcanist, you need to > resort to some sort of trickery to get your revisions closed.Huh? Under "Leap into action" on the bottom of the page, there is "Close revision". Joerg
Krzysztof Parzyszek via llvm-dev
2016-Jan-08 15:43 UTC
[llvm-dev] Phabricator/Arcanist feedback
On 1/8/2016 9:39 AM, Joerg Sonnenberger via llvm-dev wrote:> > Huh? Under "Leap into action" on the bottom of the page, there is "Close > revision".Hmm. Indeed. I don't know why I didn't notice it before. Oh well, today I learned... Thanks! -Krzysztof -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> On 8 Jan 2016, at 15:43, Krzysztof Parzyszek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 1/8/2016 9:39 AM, Joerg Sonnenberger via llvm-dev wrote: >> >> Huh? Under "Leap into action" on the bottom of the page, there is "Close >> revision". > > Hmm. Indeed. I don't know why I didn't notice it before. Oh well, today I learned…If it’s a revision authored by someone else (even if you are a reviewer), the “Close” doesn’t appear - it’s necessary to first “Comandeer Revision” before the close option shows up. I’ve been confused by that in the past on other projects using Phabricator. Simon