llvm dev - Jan 2016 - Phabricator/Arcanist feedback

> On Jan 7, 2016, at 9:57 AM, Mehdi Amini via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
>> 
>> On Jan 7, 2016, at 9:45 AM, David Blaikie via llvm-dev <llvm-dev at
lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
>> 
>> 
>> 
>> On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev
<llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
wrote:
>> Hi Dan, thanks for the feedback.
>> 
>> On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk
<mailto:dan at su-root.co.uk>> wrote:
>> Hi,
>> 
>> I recently tried reviewing/committing some of my code on
>> Phabricator/Arcanist for the first time and I noticed that the docs
>> [1] ask for feedback, so here it is!
>> 
>> Phabricator functions reasonably well and it is a lot easier to write
>> comments and respond to comments on particular parts of code as
>> opposed to the old way of copy and pasting patches into e-mails sent
>> to llvm-commits. Two minors annoyances:
>> 
>> * IIRC you have to scroll to the bottom of the page and click a submit
>> button to have comments that have just been written accepted. This is
>> really annoying and unintuitive, especially if the patch is large
>> which means lots and lots and lots of scrolling.
>> 
>> * I also have a personal preference for writing review comments in
>> markdown. Phabricator seems to use some other syntax [3] which is not
>> compatible. I'm very used to writing reviews on GitHub which uses
>> GitHub flavoured markdown so I kept accidentaly typing that into the
>> comment boxes.
>> 
>> I came up against a number of issues when it came to actually
>> committing code once it had been reviewed.
>> 
>> # TL;DR
>> 
>> I don't like the arcanist tool at all and we should have a
documented
>> manual way of committing code reviewed on Phabricator.
>> 
>> # Long version
>> 
>> The docs [2] to seem to suggest the **only correct way** (i.e.
>> properly closes the phabriacator review) is to commit your change is
>> via the arcanist command line tool.
>> 
>> Interesting, I don't read it that way :) I personally don't use
arc to commit.
>>  
>> I had/have several problems with the arcanist tool.
>> 
>> * It is written in PHP  (provokes a knee-jerk "kill it with
fire"
>> reaction in me and likely others). IMHO not the most suitable language
>> for writing a command line tool. As the rest of the points below
>> demonstrate
>> 
>> * I suspect that most people don't have (and don't want to
have) the
>> PHP runtime installed just to run a command line tool.
>> 
>> * The tool does not work out of box due PHP's default configuration
>> (5.6.16 on Arch Linux). I see warnings like this.
>> 
>> ```
>> PHP Warning:  ini_set(): open_basedir restriction in effect. File() is
>> not within the allowed path(s):
>> (/srv/http/:/home/:/tmp/:/usr/share/pear/:/usr/share/webapps/) in
>> /home/dan/dev/libphutil/scripts/__init_scr
>> ipt__.php on line 52
>> ```
>> 
>> See the attached ``arc.txt`` for the full output.
>> 
>> I had to remove the ``open_basedir`` setting (making my PHP install
>> less secure) in ``php.ini`` to get the tool to work.
>> 
>> IMHO we should have other documented method(s) of committing the code
>> (that still correctly closes the review in phabricator) without using
>> the arcanist tool. Perhaps the Phabricator web interface should have
>> an option to generate the correctly formatted commit message text
>> which can then be used when committed manually?
>> 
>> You can just write the commit message the way you would write it if you
didn't use phab. There really is no need for arc if you don't like it (I
personally use it for everything but the commit).
>> 
>> Trick is (as mentioned later in the thread) to leave the
"Differential Revision: " tag in there so it'll autoclose the
review (if you like
> 
> This does not work for me, I use "arc diff” to create the patch and
git svn dcommit, and none of my revision are closing automatically. Is there
something else that need to be setup?
One thing that bit me a few times is the fact that the Differential Revision:
line must be the last (non-empty) line in the commit message. If you add things
like “This fixes …” behind it then it won’t get recognized.

- Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160107/9e328e53/attachment.html>

On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote:
>
> One thing that bit me a few times is the fact that the Differential
> Revision: line must be the last (non-empty) line in the commit message.
> If you add things like “This fixes …” behind it then it won’t get
> recognized.
My biggest grievance with Phabricator is that you can't just close a 
revision manually.  It seems that unless you use arcanist, you need to 
resort to some sort of trickery to get your revisions closed.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation

On Fri, Jan 08, 2016 at 09:29:01AM -0600, Krzysztof Parzyszek via llvm-dev
wrote:
> On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote:
> >
> >One thing that bit me a few times is the fact that the Differential
> >Revision: line must be the last (non-empty) line in the commit message.
> >If you add things like “This fixes …” behind it then it won’t get
> >recognized.
> 
> My biggest grievance with Phabricator is that you can't just close a
> revision manually.  It seems that unless you use arcanist, you need to
> resort to some sort of trickery to get your revisions closed.
Huh? Under "Leap into action" on the bottom of the page, there is
"Close
revision".

Joerg