llvm dev - Nov 2017 - Two-stage build w/ ninja - Tests still use stage1 compiler / linker ?

Folks,

I am using a two-stagesimple build like this one:

make -G Ninja -DCLANG_ENABLE_BOOTSTRAP=ON ../src
ninja stage2-check-all

Stage 1 gets built, and when looking at rules.ninja in the stage2-bins I see:

rule CXX_COMPILER_AnalysisTests
  depfile = $DEP_FILE
  deps = gcc
  command = <stage1 build dir>./bin/clang++ $DEFINES $INCLUDES $FLAGS -MMD
-MT $out -MF $DEP_FILE -o $out -c $in

This is just an example, in fact all of the CXX_COMPILER_{unit tests} point to
the the compiler and linker as per above example.

Isn’t that the stage1 compiler that is being used here ? I am pretty sure that I
am just missing something here. Any pointers of how I can convince cmake to use
the just-built (stage2) compiler for the tests ?

Thanks,

/Dirk


-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20171105/07dea59c/attachment.html>

Aren't unit tests always built with the build compiler (which is stage 1 in
your case)?

On Sun, Nov 5, 2017 at 11:53 AM Dirk Schroetter via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Folks,
>
> I am using a two-stagesimple build like this one:
>
> make -G Ninja -DCLANG_ENABLE_BOOTSTRAP=ON ../src
> ninja stage2-check-all
>
> Stage 1 gets built, and when looking at rules.ninja in the stage2-bins I
> see:
>
> rule CXX_COMPILER_AnalysisTests
>   depfile = $DEP_FILE
>   deps = gcc
>   command = <stage1 build dir>./bin/clang++ $DEFINES $INCLUDES $FLAGS
-MMD
> -MT $out -MF $DEP_FILE -o $out -c $in
>
> This is just an example, in fact all of the CXX_COMPILER_{unit tests}
> point to the the compiler and linker as per above example.
>
> Isn’t that the stage1 compiler that is being used here ? I am pretty sure
> that I am just missing something here. Any pointers of how I can convince
> cmake to use the just-built (stage2) compiler for the tests ?
>
> Thanks,
>
> /Dirk
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20171106/268a1806/attachment.html>

Hello Nemanja,

in effect they are. Even in the 2-stage process both ninja and make use the
stage1 compiler (with the caveat that there might be a variable which I am
missing). But shouldn’t they be built using the stage2 compiler instead ? As
that is the compiler we actually will be installing as product of the build and
the one that should be tested ?

Thanks,

/Dirk
> Am 06.11.2017 um 12:26 schrieb Nemanja Ivanovic <nemanja.i.ibm at
gmail.com>:
> 
> Aren't unit tests always built with the build compiler (which is stage
1 in your case)?
> 
> On Sun, Nov 5, 2017 at 11:53 AM Dirk Schroetter via llvm-dev <llvm-dev
at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> Folks,
> 
> I am using a two-stagesimple build like this one:
> 
> make -G Ninja -DCLANG_ENABLE_BOOTSTRAP=ON ../src
> ninja stage2-check-all
> 
> Stage 1 gets built, and when looking at rules.ninja in the stage2-bins I
see:
> 
> rule CXX_COMPILER_AnalysisTests
>   depfile = $DEP_FILE
>   deps = gcc
>   command = <stage1 build dir>./bin/clang++ $DEFINES $INCLUDES $FLAGS
-MMD -MT $out -MF $DEP_FILE -o $out -c $in
> 
> This is just an example, in fact all of the CXX_COMPILER_{unit tests} point
to the the compiler and linker as per above example.
> 
> Isn’t that the stage1 compiler that is being used here ? I am pretty sure
that I am just missing something here. Any pointers of how I can convince cmake
to use the just-built (stage2) compiler for the tests ?
> 
> Thanks,
> 
> /Dirk
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
<http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20171106/aafc8532/attachment.html>