Rails - Dec 2007 - automatic 'verify :xhr => true' for methods ending with _xhr

hey guys,
i am writing a couple of actions which are only used with an xhr. I
''protect'' them all against a direct access with the
''verify'' method in
the controller

verify :only => ..., :xhr => true

it would be cool if the system would automatically recognize the xhr
actions and protect them ... i want to postfix methods with
''_xhr'' and
those should be only accessible with an xhr.

- good for readability
- good for my DRY

does anyone has a tip on how to implement this? i guess it should go
into the ''ApplicationController''
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

A before_filter is all you really need as that''s kinda what verify is
anyway
- a DSL for creating before_filters.

before_filter :protect_xhr_methods


def protect_xhr_methods
  redirect_to :action=>"index" unless
self.action_name.include?("_xhr") &&
request.xhr?
end

(I did not test this, and there''s a better way to test for _xhr in the
action name, but I am really lazy right now :)  )

Is that something close?


On Dec 3, 2007 1:42 PM, Michal Gabrukiewicz <
rails-mailing-list-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:
>
> hey guys,
> i am writing a couple of actions which are only used with an xhr. I
> ''protect'' them all against a direct access with the
''verify'' method in
> the controller
>
> verify :only => ..., :xhr => true
>
> it would be cool if the system would automatically recognize the xhr
> actions and protect them ... i want to postfix methods with
''_xhr'' and
> those should be only accessible with an xhr.
>
> - good for readability
> - good for my DRY
>
> does anyone has a tip on how to implement this? i guess it should go
> into the ''ApplicationController''
> --
> Posted via http://www.ruby-forum.com/.
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

yeah that was exactly what i needed.. thanks..
the only problem i have now is that i have two before_filters:
before_filter :protect_xhr, check_login

and both can do a redirect ... when protect_xhr does one already and 
check_login also wants to do one i get a double response error ...

whats the best solution for this?
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

In a filter, make sure to return false and not just to render / 
redirect. You should always return false in a filter if you want to halt 
the execution chain.

i.e redirect_to my_url and false


Michal Gabrukiewicz wrote:
> yeah that was exactly what i needed.. thanks..
> the only problem i have now is that i have two before_filters:
> before_filter :protect_xhr, check_login
> 
> and both can do a redirect ... when protect_xhr does one already and 
> check_login also wants to do one i get a double response error ...
> 
> whats the best solution for this?
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

@Nathan:

While this is *currently* true, things have changed in Rails 2.0, and
that''s
where I''ve been working a lot lately. Thank you for reminding of this.

In Rails 2.0 you''ll no longer need to worry about that, as redirecting
or
explicitly rendering will stop the filter execution. (Yay!)

http://dev.rubyonrails.org/changeset/7984

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Brian Hogan wrote:
> @Nathan:
> 
> While this is *currently* true, things have changed in Rails 2.0, and 
> that''s
> where I''ve been working a lot lately. Thank you for reminding of
this.
> 
> In Rails 2.0 you''ll no longer need to worry about that, as
redirecting
> or
> explicitly rendering will stop the filter execution. (Yay!)
> 
> http://dev.rubyonrails.org/changeset/7984
hey thats great!! thanks for your participation
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Yea, I am aware that they changed that and I am really glad they did. I 
always thought that the whole "returning false" thing was counter 
intuitive. Everyone coming in expects a render or a redirect to stop the 
execution. I always felt that was the better solution. Glad the rails 
core finally agreed.


Brian Hogan wrote:
> @Nathan:
> 
> While this is *currently* true, things have changed in Rails 2.0, and 
> that''s
> where I''ve been working a lot lately. Thank you for reminding of
this.
> 
> In Rails 2.0 you''ll no longer need to worry about that, as
redirecting
> or
> explicitly rendering will stop the filter execution. (Yay!)
> 
> http://dev.rubyonrails.org/changeset/7984
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

On Dec 3, 2007 11:06 PM, Brian Hogan
<bphogan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:
> While this is *currently* true, things have changed in Rails 2.0, and
that''s
> where I''ve been working a lot lately. Thank you for reminding of
this.
>
> In Rails 2.0 you''ll no longer need to worry about that, as
redirecting or
> explicitly rendering will stop the filter execution. (Yay!)
>
> http://dev.rubyonrails.org/changeset/7984

/me watches his Rails books depreciate even faster than last time


-- 
Greg Donald
http://destiney.com/

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Greg:

Just be glad you aren''t trying to follow the Agile book NOW, when
Rails 2.0is installed when you do a fresh installation :) I feel
really sorry for any
newbies right now.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---