Rails - Sep 2006 - Ticket #4888 - observe_field's :on is ignored - a fix

The only reference I could find to this problem on this forum, where :on 
is ignored in observer_field helper, is this: 
http://www.ruby-forum.com/topic/70935.

After an hour of pulling out my hair trying to figure out how to change 
an observe_field to work with on onKeyUp event (or anything else besides 
the default event), I finally found this patch:

http://dev.rubyonrails.org/ticket/4888

Looked like just what I needed but it didn''t fix the issue. After 
following the javascript logic in the patch, I realized some other code 
needed to be updated too.

See here, lines 1427 - 1430: 
http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_view/helpers/javascripts/prototype.js?rev=3378#L1427

These appear just a handful of lines below the patch mentioned above.

Now, :on => ''keyup'' works!


Should I post a note on Ticket #4888 that the patch is incomplete? Would 
that be the appropriate thing to do? I''m kinda new to all this stuff
and
as such feel a bit timid.

Thanks

-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk
-~----------~----~----~----~------~----~------~--~---

Hi Sean,

Sean O''grady wrote:
> Should I post a note on Ticket #4888 that the patch
> is incomplete? Would that be the appropriate thing to do?
Absolutely.  Even better would be if you would post a test or two that fail 
under the existing patch and pass with your additions.  Welcome to Rails!

Best regards,
Bill 


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk
-~----------~----~----~----~------~----~------~--~---