solojavier
2012-Sep-03 21:43 UTC
time_zone_options_for_select method in ActionView::Helpers is not DST aware
We are using time_zone_options_for_select for the letting the user to select the timezone to assign to an object. But we are having trouble because currently we are on DST period, so in utc -5 but the list is showing utc-6 (the normal offset) As per usage suggested in this issue: https://github.com/rails/rails/issues/7297. I wrote a custom method to solve this temporarily: https://gist.github.com/3613790 Should I open a pull request with this method receiving an option to get the current offset with DST is applied or creating a new method with the expected output ? Thanks in advance for your feedback -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/siWQBEf3F7YJ. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Possibly Parallel Threads
- #3775 - testing helpers which use ActionView methods
- Make `ActionView::Helpers::InstanceTag#tag_id`, `ActionView::Helpers::InstanceTag#tag_id_with_index(index)` public?
- ActionView::Template::Error (undefined method `strftime' for nil:NilClass):
- ActionView::Helpers::FormHelper instance methods should take an object reference rather than an object_name.
- Overriding ActionView::Helpers::InstanceTag::DEFAULT_TEXT_AREA_OPTIONS