R devel - Feb 2008 - bug using matplot (PR#10676)

Full_Name: Anne CORI
Version: 2.6.1
OS: windows
Submission from: (NULL) (134.157.220.19)


let A be a mtrix with n lines and p columns, p>36 ;

matplot(A) will only draw the plot of the first 36 columns of A.

This is due to a bug in the definition of pch in the function : 

pch <- c(paste(c(1:9, 0)), letters)[1:k]

should be replaced by 

pch <- c(paste(c(1:9, 0)), letters)

I hope this is clear, 

All the best, 

Anne

hits=-2.6 tests=BAYES_00
X-USF-Spam-Flag: NO

On Fri, 2008-02-01 at 16:20 +0100, cori at u707.jussieu.fr
wrote:
> Full_Name: Anne CORI
> Version: 2.6.1
> OS: windows
> Submission from: (NULL) (134.157.220.19)
> 
> 
> let A be a mtrix with n lines and p columns, p>36 ;
> 
> matplot(A) will only draw the plot of the first 36 columns of A.
> 
> This is due to a bug in the definition of pch in the function : 
> 
> pch <- c(paste(c(1:9, 0)), letters)[1:k]
You need this here, the issue is that the default is only length 36 and
you aren't warned if you have more variables than that *if* you rely
upon the default and don't specify pch in you call to matplot.

This works fine for example:

dat <- matrix(rnorm(400), ncol = 40)
matplot(dat, pch = c(paste(1:9, 0, letters, LETTERS)))
> 
> should be replaced by 
> 
> pch <- c(paste(c(1:9, 0)), letters)
That won't help. The vector, pch, will get recycled so you won't be able
to tell the difference between vars 1,2,3 etc and 37,38,39 etc. (See the
series of if(length(.....) < k) statements towards the end of the
function definition for matplot.

This is working as documented, although one might consider it an
infelicity in the implementation that it doesn't warn you that k is > 36
and suggest you pass your own set of plotting characters.

G
> 
> I hope this is clear, 
> 
> All the best, 
> 
> Anne
> 
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
-- 
%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%
 Dr. Gavin Simpson             [t] +44 (0)20 7679 0522
 ECRC, UCL Geography,          [f] +44 (0)20 7679 0565
 Pearson Building,             [e] gavin.simpsonATNOSPAMucl.ac.uk
 Gower Street, London          [w] http://www.ucl.ac.uk/~ucfagls/
 UK. WC1E 6BT.                 [w] http://www.freshwaters.org.uk
%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%

>>>>> "GS" == Gavin Simpson <gavin.simpson at
ucl.ac.uk>
>>>>>     on Fri, 01 Feb 2008 18:08:54 +0000 writes:
    GS> On Fri, 2008-02-01 at 16:20 +0100, cori at u707.jussieu.fr
    GS> wrote:
    >> Full_Name: Anne CORI Version: 2.6.1 OS: windows
    >> Submission from: (NULL) (134.157.220.19)
    >> 
    >> 
    >> let A be a mtrix with n lines and p columns, p>36 ;
    >> 
    >> matplot(A) will only draw the plot of the first 36
    >> columns of A.
    >> 
    >> This is due to a bug in the definition of pch in the
    >> function :
    >> 
    >> pch <- c(paste(c(1:9, 0)), letters)[1:k]

    GS> You need this here,

actually not (anymore; porbably it *was* needed in amuch older
version of R),
because of the later  rep(u, length.out=k) which also works when
u is longer than k

    GS> the issue is that the default is only length 36 and you
    GS> aren't warned if you have more variables than that *if*
    GS> you rely upon the default and don't specify pch in you
    GS> call to matplot.

    GS> This works fine for example:

    GS> dat <- matrix(rnorm(400), ncol = 40) 
    GS> matplot(dat, pch = c(paste(1:9, 0, letters, LETTERS)))

yes.

    >> should be replaced by
    >> 
    >> pch <- c(paste(c(1:9, 0)), letters)

    GS> That won't help.

well, it does help insofar as columns (>= 37) are then plotted
at all.

But you are right about this :

    GS>  The vector, pch, will get recycled so
    GS> you won't be able to tell the difference between vars
    GS> 1,2,3 etc and 37,38,39 etc. (See the series of
    GS> if(length(.....) < k) statements towards the end of the
    GS> function definition for matplot.

    GS> This is working as documented, although one might
    GS> consider it an infelicity in the implementation that it
    GS> doesn't warn you that k is > 36 and suggest you pass
    GS> your own set of plotting characters.

yes.

I do agree with Anne that there is a bug.
Following Gavin (and Anne, too),
I'm proposing to do the following :

1) recycle pch when it's too short;  this already happens for
  user specified pch, so should also happen for the default pch.

2) warn then the default pch is too short (and hence recycled by
   "1)"), I wouldn't add an explicit suggestion to use your own.

   My current working proposal would say

 >>   Warning message:
 >>   In matplot(1:100, m, type = "o") :
 >>     default 'pch' is smaller than number of columns and hence
recycled

   and the useR  would understand that she can specify her
   own pch, right?


3) extend the default pch to include LETTERS, i.e., to  
   c(1:9,0, letters, LETTERS)

Thanks to Anne and Gavin for the report and analysis!

Martin