samba - Apr 2007 - Re: Re: Symlinks deletion behaviour

Hi Jeremy,
Thanks for your response, but it doesn't work either with exactly the same
symptoms:

[2007/04/24 09:52:43, 3] smbd/process.c:switch_message(926)
  switch message SMBrmdir (pid 19730) conn 0x80414a30
[2007/04/24 09:52:43, 4] smbd/uid.c:change_to_user(181)
  change_to_user: Skipping user change - already user
[2007/04/24 09:52:43, 5] smbd/filename.c:unix_convert(147)
  unix_convert called on file "my_test_link"
[2007/04/24 09:52:43, 10] smbd/statcache.c:stat_cache_lookup(248)
  stat_cache_lookup: lookup succeeded for name [MY_TEST_LINK] ->
[my_test_link]
[2007/04/24 09:52:43, 3] smbd/reply.c:rmdir_internals(3947)
  rmdir_internals: couldn't remove directory my_test_link : Not a directory
[2007/04/24 09:52:43, 3] smbd/error.c:error_packet_set(106)
  error packet at smbd/reply.c(4001) cmd=1 (SMBrmdir) NT_STATUS_NOT_A_DIRECTORY

Test setup is my_test_link -> my_test. There is a number of files/dirs in
my_test. They are deleted, but not my_test_link. At the same time I can delete
my_test without any problems.

If you wish I can provide you with additional info like strace output or
something.

Regards,
Alexander
> -----Original Message-----
> From: Jeremy Allison [mailto:jra@samba.org] 
> Sent: Tuesday, April 17, 2007 1:50 AM
> To: Alexander
> Cc: samba@lists.samba.org
> Subject: Re: [Samba] Re: Symlinks deletion behaviour
> 
> On Mon, Mar 19, 2007 at 02:36:23PM +0300, Alexander wrote:
> > Hi all,
> > 
> > Further investigation with strace shows that Samba tries to use
> rmdir() syscall to delete the link which naturally fails with "Not a
> directory" as it should according to man.
> > 
> > However, looking at usual "rm -r" behaviour shows that it
uses
> unlink(). Samba does not (while there's some  SMB_VFS_UNLINK) in
> rmdir_internals. Is there any bug or a feature which I don't realize?
> > 
> 
> This should be fixed for 3.0.25rc2, due out this week.
> Please re-test and let me know.
> 
> Jeremy.
>

On Tue, Apr 24, 2007 at 10:10:31AM +0400, Alexander
wrote:
> Hi Jeremy,
> Thanks for your response, but it doesn't work either with exactly the
same symptoms:
> 
> [2007/04/24 09:52:43, 3] smbd/process.c:switch_message(926)
>   switch message SMBrmdir (pid 19730) conn 0x80414a30
> [2007/04/24 09:52:43, 4] smbd/uid.c:change_to_user(181)
>   change_to_user: Skipping user change - already user
> [2007/04/24 09:52:43, 5] smbd/filename.c:unix_convert(147)
>   unix_convert called on file "my_test_link"
> [2007/04/24 09:52:43, 10] smbd/statcache.c:stat_cache_lookup(248)
>   stat_cache_lookup: lookup succeeded for name [MY_TEST_LINK] ->
[my_test_link]
> [2007/04/24 09:52:43, 3] smbd/reply.c:rmdir_internals(3947)
>   rmdir_internals: couldn't remove directory my_test_link : Not a
directory
> [2007/04/24 09:52:43, 3] smbd/error.c:error_packet_set(106)
>   error packet at smbd/reply.c(4001) cmd=1 (SMBrmdir)
NT_STATUS_NOT_A_DIRECTORY
> 
> Test setup is my_test_link -> my_test. There is a number of files/dirs
in my_test. They are deleted, but not my_test_link. At the same time I can
delete my_test without any problems.
> 
> If you wish I can provide you with additional info like strace output or
something.
Please open a bug report at bugzilla.samba.org with *exactly*
the steps you need to do to reproduce this and I'll work on
it.

Thanks,

	Jeremy.