Denis Vlasenko
2004-Oct-05 12:44 UTC
[Samba] [PATCH] 2.2.12: fix support for samba daemons running under daemontools
Hi, One can run samba 2.2.12 daemons (nmbd,smbd,winbindd) under daemontools if they are started with -i option. However, smbd does not handle more than one connection at once in this mode. If one redirects it to pipe/file, logging to stdout is buffered. Log text appears there with inacceptable delay. This patch: * adds option -f to nmbd, smbd and windindd. * for nmbd and winbindd it is identical to -i. * for smbd it is mostly like -i but allows multiple connections to smbd. * usage() text updated accordingly. * smbd help on -i now mentions single threaded behaviour. * getopt in nmbd and smbd source expected -f option with parameter, but there were no other supporting code for it. An oversight? Removed. * stdout set to unbuffered mode if we do logging to it. Run tested. Please review/apply. -- vda
Denis Vlasenko
2004-Oct-05 12:50 UTC
[Samba] [PATCH] 2.2.12: fix support for samba daemons running under daemontools
On Tuesday 05 October 2004 15:45, Denis Vlasenko wrote:> One can run samba 2.2.12 daemons (nmbd,smbd,winbindd) under daemontools if > they are started with -i option. However, smbd does not handle more than > one connection at once in this mode. > > If one redirects it to pipe/file, logging to stdout is buffered. > Log text appears there with inacceptable delay. > > This patch: > > * adds option -f to nmbd, smbd and windindd. > * for nmbd and winbindd it is identical to -i. > * for smbd it is mostly like -i but allows multiple connections to smbd. > * usage() text updated accordingly. > * smbd help on -i now mentions single threaded behaviour. > * getopt in nmbd and smbd source expected -f option with parameter, > but there were no other supporting code for it. An oversight? Removed. > * stdout set to unbuffered mode if we do logging to it. > > Run tested. > > Please review/apply.Available at http://195.66.192.168/linux/fg.patch Is it just me, or attachents are banned/stripped on this list? -- vda