Quick question for the Samba team, Just wondering if there is a reason that a %L substitution changes the WHOLE string after the substitution to lowercase (in standard_sub_basic)? This was causing me a big headache as I was using a %G later in the string, and this was being translated into a %g... Here's the relevant section of code from lib/substitute.c: case 'L' : if (*local_machine) string_sub(p,"%L", local_machine,l); else { char *ns = p; string_sub(p,"%L", global_myname,l); while (*ns) { if (isupper(*ns)) *ns = tolower(*ns); ns++; } } break; Thanks Glen Gibb
Glen Gibb wrote:> > Quick question for the Samba team, > > Just wondering if there is a reason that a %L substitution changes the > WHOLE string after the substitution to lowercase (in standard_sub_basic)?That is most werid! It's also a 2.2 only bug. http://pserver.samba.org/cgi-bin/cvsweb/samba/source/lib/substitute.c.diff?r1=1.8.2.14&r2=1.8.2.15&logsort=rev&f=h Herb: what exactly where you trying to do there? Andrew Bartlett -- Andrew Bartlett abartlet@pcug.org.au Manager, Authentication Subsystems, Samba Team abartlet@samba.org Student Network Administrator, Hawker College abartlet@hawkerc.net http://samba.org http://build.samba.org http://hawkerc.net