rsync - Aug 2006 - DO NOT REPLY [Bug 4037] New: Rsync should obey --keep-dirlinks when searching basis dirs

https://bugzilla.samba.org/show_bug.cgi?id=4037

           Summary: Rsync should obey --keep-dirlinks when searching basis
                    dirs
           Product: rsync
           Version: 2.6.9
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: hashproduct+rsync@gmail.com
         QAContact: rsync-qa@samba.org


Currently, when rsync searches for a basis file in an alternate basis directory
specified with a --*-dest option, it blindly follows the file-list path from
the top of the alternate basis directory.  This might be the wrong thing to do
if the basis directory contains symlinks.  The script that I will soon attach
demonstrates how rsync's behavior might result in a corrupt backup.

I propose that rsync should obey the --keep-dirlinks setting when searching for
basis files.  If --keep-dirlinks is disabled, rsync would have to lstat every
proper prefix of the path under the basis dir to make sure symlinks are not
accidentally being followed.  For efficiency, this check should be done only
once per directory.  It would fit nicely in the per-directory initialization,
near line 911 of generator.c.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4037





------- Comment #1 from hashproduct+rsync@gmail.com  2006-08-20 17:25 MST
-------
Created an attachment (id=2098)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2098&action=view)
Script for a backup scenario that tickles the bug


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4037





------- Comment #2 from matt@mattmccutchen.net  2008-01-24 13:28 CST -------
Note that, in the absence of a proper fix for this issue, symlink munging in
the destination can prevent surprises like the one seen in comment #1.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.