I've pushed 10 commits which just clean up errors found by 'make
syntax-check'. The remaining syntax-check errors are attached below.
I think many of them are false alarms.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
-------------- next part --------------
GFDL_version
0.04 GFDL_version
TAB_in_indentation
0.04 TAB_in_indentation
Wundef_boolean
0.16 Wundef_boolean
avoid_ctype_macros
0.04 avoid_ctype_macros
avoid_if_before_free
0.27 avoid_if_before_free
cast_of_alloca_return_value
0.05 cast_of_alloca_return_value
cast_of_argument_to_free
0.05 cast_of_argument_to_free
cast_of_x_alloc_return_value
0.05 cast_of_x_alloc_return_value
changelog
0.02 changelog
const_long_option
0.04 const_long_option
copyright_check
0.20 copyright_check
cross_check_PATH_usage_in_tests
0.01 cross_check_PATH_usage_in_tests
error_message_period
php/README-PHP:33: echo ("Error: ".guestfs_last_error
($g)."\n");
php/README-PHP:44: echo ("Error: ".guestfs_last_error
($g)."\n");
php/extension/guestfs_php_002.phpt:15: echo ("Error:
".guestfs_last_error ($g)."\n");
php/extension/guestfs_php_002.phpt:19: echo ("Error:
".guestfs_last_error ($g)."\n");
php/extension/guestfs_php_002.phpt:24: echo ("Error:
".guestfs_last_error ($g)."\n");
php/extension/guestfs_php_003.phpt:29: die ("Error:
".guestfs_last_error ($g)."\n");
po-docs/ja.po:1559:"string into an errno, see the function error() in
fuse/guestmount.c."
po-docs/ja.po-25277-"force>)."
po-docs/libguestfs-docs.pot:1500:"string into an errno, see the function
error() in fuse/guestmount.c."
po-docs/libguestfs-docs.pot-24824-"C<--resize-force>)."
maint.mk: found error message ending in period
make: *** [sc_error_message_period] Error 1
error_message_warn_fatal
0.04 error_message_warn_fatal
immutable_NEWS
0.01 immutable_NEWS
m4_quote_check
0.02 m4_quote_check
makefile_TAB_only_indentation
0.02 makefile_TAB_only_indentation
makefile_at_at_check
Makefile.am:104: -e '/@ACTIONS@/rsrc/guestfs-actions.pod' \
Makefile.am:105: -e 's/@ACTIONS@//' \
Makefile.am:106: -e '/@AVAILABILITY@/rsrc/guestfs-availability.pod' \
Makefile.am:107: -e 's/@AVAILABILITY@//' \
Makefile.am:108: -e '/@STRUCTS@/rsrc/guestfs-structs.pod' \
Makefile.am:109: -e 's/@STRUCTS@//' \
Makefile.am:120: -e '/@ACTIONS@/rfish/guestfish-actions.pod' -e
's/@ACTIONS@//' \
fish/Makefile.am:712: -e '/@ACTIONS@/rguestfish-actions.pod' -e
's/@ACTIONS@//' \
po-docs/ja/Makefile.am:1667: -e '/@ACTIONS@/rguestfs-actions.pod' \
po-docs/ja/Makefile.am:1668: -e 's/@ACTIONS@//' \
po-docs/ja/Makefile.am:1669: -e
'/@AVAILABILITY@/rguestfs-availability.pod' \
po-docs/ja/Makefile.am:1670: -e 's/@AVAILABILITY@//' \
po-docs/ja/Makefile.am:1671: -e '/@STRUCTS@/rguestfs-structs.pod' \
po-docs/ja/Makefile.am:1672: -e 's/@STRUCTS@//' \
po-docs/ja/Makefile.am:1683: -e '/@ACTIONS@/rguestfish-actions.pod'
-e 's/@ACTIONS@//' \
src/Makefile.am:2086: -e '/@ACTIONS@/rguestfs-actions.pod' \
src/Makefile.am:2087: -e 's/@ACTIONS@//' \
src/Makefile.am:2088: -e '/@AVAILABILITY@/rguestfs-availability.pod'
\
src/Makefile.am:2089: -e 's/@AVAILABILITY@//' \
src/Makefile.am:2090: -e '/@STRUCTS@/rguestfs-structs.pod' \
src/Makefile.am:2091: -e 's/@STRUCTS@//' \
maint.mk: use $(...), not @...@
make: *** [sc_makefile_at_at_check] Error 1
prohibit_HAVE_MBRTOWC
0.04 prohibit_HAVE_MBRTOWC
prohibit_S_IS_definition
0.05 prohibit_S_IS_definition
prohibit_always-defined_macros
Can't open stat-macros.h: No such file or directory.
daemon/guestfsd.c:# define O_CLOEXEC 0
src/generator.ml:#define PRId64 \"lld\"
src/generator.ml:#define PRIu64 \"llu\"
maint.mk: define the above via some gnulib .h file
make: *** [sc_prohibit_always-defined_macros] Error 1
prohibit_always_true_header_tests
src/guestfs.c:41:#ifdef HAVE_ERRNO_H
src/guestfs.c:53:#ifdef HAVE_SYS_SOCKET_H
src/launch.c:41:#ifdef HAVE_ERRNO_H
src/launch.c:53:#ifdef HAVE_SYS_SOCKET_H
src/proto.c:41:#ifdef HAVE_ERRNO_H
src/proto.c:53:#ifdef HAVE_SYS_SOCKET_H
maint.mk: do not test the above HAVE_<header>_H symbol(s);\n with the
corresponding gnulib module, they are always true
make: *** [sc_prohibit_always_true_header_tests] Error 1
prohibit_argmatch_without_use
0.04 prohibit_argmatch_without_use
prohibit_assert_without_use
0.04 prohibit_assert_without_use
prohibit_backup_files
0.02 prohibit_backup_files
prohibit_c_ctype_without_use
0.04 prohibit_c_ctype_without_use
prohibit_canonicalize_without_use
0.04 prohibit_canonicalize_without_use
prohibit_close_stream_without_use
0.04 prohibit_close_stream_without_use
prohibit_cvs_keyword
0.04 prohibit_cvs_keyword
prohibit_empty_lines_at_EOF
0.03 prohibit_empty_lines_at_EOF
prohibit_error_without_use
0.04 prohibit_error_without_use
prohibit_gethostby
0.05 prohibit_gethostby
prohibit_getopt_without_use
0.04 prohibit_getopt_without_use
prohibit_hash_pjw_without_use
0.04 prohibit_hash_pjw_without_use
prohibit_hash_without_use
0.04 prohibit_hash_without_use
prohibit_have_config_h
0.04 prohibit_have_config_h
prohibit_ignore_value_without_use
0.04 prohibit_ignore_value_without_use
prohibit_intprops_without_use
0.04 prohibit_intprops_without_use
prohibit_inttostr_without_use
0.04 prohibit_inttostr_without_use
prohibit_long_options_without_use
0.04 prohibit_long_options_without_use
prohibit_magic_number_exit
po-docs/ja.po:2456:"might be called indirectly from L<exit(3)>, which
can cause unexpected "
po-docs/libguestfs-docs.pot:2396:"might be called indirectly from
L<exit(3)>, which can cause unexpected "
src/guestfs.pod:1193:L<exit(3)>, which can cause unexpected problems in
higher-level
maint.mk: use EXIT_* values rather than magic number
make: *** [sc_prohibit_magic_number_exit] Error 1
prohibit_openat_without_use
0.04 prohibit_openat_without_use
prohibit_root_dev_ino_without_use
0.04 prohibit_root_dev_ino_without_use
prohibit_safe_read_without_use
0.04 prohibit_safe_read_without_use
prohibit_signal_without_use
0.05 prohibit_signal_without_use
prohibit_strcmp
0.04 prohibit_strcmp
prohibit_strcmp_and_strncmp
0.05 prohibit_strcmp_and_strncmp
prohibit_strings_without_use
0.04 prohibit_strings_without_use
prohibit_test_minus_ao
appliance/init:13:if [ ! -L /etc/init.d/udev -a -x /etc/init.d/udev ]; then
fuse/test-fuse.sh:43:if [ ! -x "$guestfish" -o ! -x
"$guestmount" ]; then
maint.mk: use "test C1 && test C2", not "test C1 -a
C2"; use "test C1 || test C2", not "test C1 -o C2"
make: *** [sc_prohibit_test_minus_ao] Error 1
prohibit_trailing_blank_lines
0.05 prohibit_trailing_blank_lines
prohibit_virBufferAdd_with_string_literal
0.04 prohibit_virBufferAdd_with_string_literal
prohibit_xalloc_without_use
0.04 prohibit_xalloc_without_use
proper_name_utf8_requires_ICONV
0.04 proper_name_utf8_requires_ICONV
redundant_const
0.05 redundant_const
require_config_h
0.03 require_config_h
require_config_h_first
0.30 require_config_h_first
require_test_exit_idiom
0.01 require_test_exit_idiom
texinfo_acronym
0.02 texinfo_acronym
the_the
0.05 the_the
trailing_blank
0.07 trailing_blank
vulnerable_makefile_CVE-2009-4029
0.31 vulnerable_makefile_CVE-2009-4029
make: Target `syntax-check' not remade because of errors.
Richard W.M. Jones wrote:> I've pushed 10 commits which just clean up errors found by 'make > syntax-check'. The remaining syntax-check errors are attached below. > I think many of them are false alarms.Hi Rich, It's about half and half. ...> php/README-PHP:33: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/README-PHP:44: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_002.phpt:15: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_002.phpt:19: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_002.phpt:24: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_003.phpt:29: die ("Error: ".guestfs_last_error ($g)."\n"); > po-docs/ja.po:1559:"string into an errno, see the function error() in fuse/guestmount.c." > po-docs/ja.po-25277-"force>)." > po-docs/libguestfs-docs.pot:1500:"string into an errno, see the function error() in fuse/guestmount.c." > po-docs/libguestfs-docs.pot-24824-"C<--resize-force>)." > maint.mk: found error message ending in period > make: *** [sc_error_message_period] Error 1These are false positives. You can disable this test (or any of them) altogether or add each offending file name (as a regexp) to .x-sc_error_message_period, so that they'll be exempted from the test.> Makefile.am:104: -e '/@ACTIONS@/rsrc/guestfs-actions.pod' \ > Makefile.am:105: -e 's/@ACTIONS@//' \ > Makefile.am:106: -e '/@AVAILABILITY@/rsrc/guestfs-availability.pod' \ > Makefile.am:107: -e 's/@AVAILABILITY@//' \ > Makefile.am:108: -e '/@STRUCTS@/rsrc/guestfs-structs.pod' \ > Makefile.am:109: -e 's/@STRUCTS@//' \ > Makefile.am:120: -e '/@ACTIONS@/rfish/guestfish-actions.pod' -e 's/@ACTIONS@//' \ > fish/Makefile.am:712: -e '/@ACTIONS@/rguestfish-actions.pod' -e 's/@ACTIONS@//' \ > po-docs/ja/Makefile.am:1667: -e '/@ACTIONS@/rguestfs-actions.pod' \ > po-docs/ja/Makefile.am:1668: -e 's/@ACTIONS@//' \ > po-docs/ja/Makefile.am:1669: -e '/@AVAILABILITY@/rguestfs-availability.pod' \ > po-docs/ja/Makefile.am:1670: -e 's/@AVAILABILITY@//' \ > po-docs/ja/Makefile.am:1671: -e '/@STRUCTS@/rguestfs-structs.pod' \ > po-docs/ja/Makefile.am:1672: -e 's/@STRUCTS@//' \ > po-docs/ja/Makefile.am:1683: -e '/@ACTIONS@/rguestfish-actions.pod' -e 's/@ACTIONS@//' \ > src/Makefile.am:2086: -e '/@ACTIONS@/rguestfs-actions.pod' \ > src/Makefile.am:2087: -e 's/@ACTIONS@//' \ > src/Makefile.am:2088: -e '/@AVAILABILITY@/rguestfs-availability.pod' \ > src/Makefile.am:2089: -e 's/@AVAILABILITY@//' \ > src/Makefile.am:2090: -e '/@STRUCTS@/rguestfs-structs.pod' \ > src/Makefile.am:2091: -e 's/@STRUCTS@//' \ > maint.mk: use $(...), not @...@ > make: *** [sc_makefile_at_at_check] Error 1These are false positives, too. You can obfuscate them so that the test no longer spots the "offense" by inserting a pair of single quotes, e.g., after the first @:> src/Makefile.am:2091: -e 's/@''STRUCTS@//' \> Can't open stat-macros.h: No such file or directory. > daemon/guestfsd.c:# define O_CLOEXEC 0 > src/generator.ml:#define PRId64 \"lld\" > src/generator.ml:#define PRIu64 \"llu\" > maint.mk: define the above via some gnulib .h file > make: *** [sc_prohibit_always-defined_macros] Error 1After a change to gnulib just hours ago, O_CLOEXEC is now guaranteed to be defined. Just remove that #if..#define block. Those PRI* symbols are guaranteed to be defined, too.> prohibit_always_true_header_tests > src/guestfs.c:41:#ifdef HAVE_ERRNO_H > src/guestfs.c:53:#ifdef HAVE_SYS_SOCKET_H > src/launch.c:41:#ifdef HAVE_ERRNO_H > src/launch.c:53:#ifdef HAVE_SYS_SOCKET_H > src/proto.c:41:#ifdef HAVE_ERRNO_H > src/proto.c:53:#ifdef HAVE_SYS_SOCKET_H > maint.mk: do not test the above HAVE_<header>_H symbol(s);\n with the corresponding gnulib module, they are always true > make: *** [sc_prohibit_always_true_header_tests] Error 1These are obsolescent #ifdef HAVE_... tests. Gnulib guarantees the presence of those headers, now -- assuming you are using each associated module. Just remove the #ifdefs.> po-docs/ja.po:2456:"might be called indirectly from L<exit(3)>, which can cause unexpected " > po-docs/libguestfs-docs.pot:2396:"might be called indirectly from L<exit(3)>, which can cause unexpected " > src/guestfs.pod:1193:L<exit(3)>, which can cause unexpected problems in higher-level > maint.mk: use EXIT_* values rather than magic number > make: *** [sc_prohibit_magic_number_exit] Error 1False positives. Add regexps to .x-sc_prohibit_magic_number_exit to exempt those files. ...> prohibit_test_minus_ao > appliance/init:13:if [ ! -L /etc/init.d/udev -a -x /etc/init.d/udev ]; then > fuse/test-fuse.sh:43:if [ ! -x "$guestfish" -o ! -x "$guestmount" ]; then > maint.mk: use "test C1 && test C2", not "test C1 -a C2"; use "test C1 || test C2", not "test C1 -o C2" > make: *** [sc_prohibit_test_minus_ao] Error 1Those are legitimate, since the -o and -a options have well-known portability problems.