search for: phpt

Rename the existing tests according to the naming/numbering described in guestfs-hacking(1), and improve the current ones: - guestfs_php_001.phpt: rename to guestfs_020_create.phpt - guestfs_php_003.phpt: rename to guestfs_070_optargs.phpt - guestfs_php_bindtests.phpt: rename to guestfs_090_bindtests.phpt - guestfs_091_version.phpt: new, checks taken from the former guestfs_php_002.phpt - guestfs_100_launch.phpt: new, modelled after the eq...

...), 2 deletions(-) diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index 6f9ae10..e498987 100755 --- a/php/run-php-tests.sh +++ b/php/run-php-tests.sh @@ -44,5 +44,4 @@ printenv | grep -E '^(LIBGUESTFS|LIBVIRT|LIBVIRTD|VIRTLOCKD|LD|MALLOC)_' >> env TESTS=$(echo guestfs_php_*.phpt) echo TESTS: $TESTS -# PHP ignores the result of the tests! -make test TESTS="$TESTS" PHP_EXECUTABLE="$PWD/php-for-tests.sh" +make test TESTS="$TESTS" PHP_EXECUTABLE="$PWD/php-for-tests.sh" REPORT_EXIT_STATUS=1 -- 1.8.3.1

...hanged, 65 insertions(+) diff --git a/.gitignore b/.gitignore index 1b02af0..b165c81 100644 --- a/.gitignore +++ b/.gitignore @@ -387,6 +387,7 @@ Makefile.in /php/extension/php-for-tests.sh /php/extension/php_guestfs_php.h /php/extension/run-tests.php +/php/extension/tests/guestfs_php_bindtests.phpt /php/extension/tmp-php.ini /pick-guests.pl /po-docs/*/*.1 diff --git a/generator/bindtests.ml b/generator/bindtests.ml index b75de15..2e9b6d3 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -909,6 +909,69 @@ and generate_golang_bindtests () = pr " return &s;\n&...

...fail if you do this, but you will be able to see the -# debug output in the '*.out' files. +# so you'd just get failures for every test. So there is no good way +# to debug libguestfs failures in PHP tests, but if an individual test +# fails locally then you can edit the guestfs_php_*.phpt.in and +# uncomment the putenv statement, then look at the output. unset LIBGUESTFS_DEBUG unset LIBGUESTFS_TRACE @@ -47,8 +44,4 @@ printenv | grep -E '^(LIBGUESTFS|LIBVIRT|LIBVIRTD|VIRTLOCKD|LD|MALLOC)_' >> env TESTS=$(echo tests/guestfs_*.phpt) echo TESTS: $TESTS -${MAKE:-mak...

...k cross_check_PATH_usage_in_tests 0.01 cross_check_PATH_usage_in_tests error_message_period php/README-PHP:33: echo ("Error: ".guestfs_last_error ($g)."\n"); php/README-PHP:44: echo ("Error: ".guestfs_last_error ($g)."\n"); php/extension/guestfs_php_002.phpt:15: echo ("Error: ".guestfs_last_error ($g)."\n"); php/extension/guestfs_php_002.phpt:19: echo ("Error: ".guestfs_last_error ($g)."\n"); php/extension/guestfs_php_002.phpt:24: echo ("Error: ".guestfs_last_error ($g)."\n"); php/extension...

...he PHP test script +# mixes stdout and stderr together and compares this to the expected +# output, so you'd just get failures for every test. So there is no +# good way to debug libguestfs failures in PHP tests, but if an +# individual test fails locally then you can edit the +# guestfs_php_*.phpt.in and uncomment the putenv statement, then look +# at the output. + +unset LIBGUESTFS_DEBUG +unset LIBGUESTFS_TRACE + @PHP@ $@ diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index e5cfc0d..0663b19 100755 --- a/php/run-php-tests.sh +++ b/php/run-php-tests.sh @@ -24,18 +24,6 @@ cd extensi...

...10 --------- gobject/bindtests-retvalues.js | 110 +++++++++ gobject/run-tests | 2 - gobject/run-tests-retvalues | 26 +++ perl/t/090-retvalues.t | 125 +++++++++++ php/extension/tests/guestfs_090_retvalues.phpt | 294 +++++++++++++++++++++++++ python/t/090-retvalues.py | 138 ++++++++++++ python/t/900-python-dict.py | 40 ---- ruby/t/tc_090_retvalues.rb | 141 ++++++++++++ 11 files changed, 838 insertions(+), 153 deletions(-) delete mode 100644...

Useful because it tests returning a single structure. --- docs/guestfs-hacking.pod | 1 + ocaml/Makefile.am | 2 ++ ocaml/t/guestfs_080_version.ml | 27 +++++++++++++++++++++++++++ perl/t/080-version.t | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 66 insertions(+) create mode 100644 ocaml/t/guestfs_080_version.ml create mode 100644

...he cast seems necessary in the three cases above. > error_message_period > php/README-PHP:33: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/README-PHP:44: echo ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_002.phpt:30: die ("Error: ".guestfs_last_error ($g)."\n"); > php/extension/guestfs_php_002.phpt:35: echo ("Error: ".guestfs_last_error ($g)."\n"); > po-docs/ja.po-37794-"force>)." > po-docs/libguestfs-docs.pot-33647-"I<--resize-force&gt...

Assorted collection of small improvements in making libguestfs build on non-Linux OSes; most of the changes impact tests though. Thanks, Pino Toscano (7): build: check the path of fuser, and use it in FUSE code tests: move guestfs-md5.sh to test-data v2v: tests: isolate SHA1 calculation in an own shared function v2v: tests: use guestfs-hashsums.sh for MD5 php: pass $(MAKE) to

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.

...B8YUY/D7^CBI0F$ @0B:9(8PU($-=!#! ML-H AX&HZPUFP)U<#GJ7"DU!+WR90PM:(%-.W<BKD-*27Z"$F#QPJ%+[U!*5 M8I9/MKH5KF-\"Z?.4"!YP8M38XCLK_:)F+R0*;&4"9=PYD 8PR"&I&XX <7^ M) :6/ND-GHDL&6P+VLB"U:6[<<Y7P[H=-CB+0Z5)T8TFA5J_K*6D at JE80J$S M)+0DR#,PHPT('-NAN=;5MG-94I+<@"XZ#!98'GH6=,9 APXUBS<(19 <F+:< M'^'&,^Z*#@@*M!<C5>8R:7WN6P4SUN$BIJYC6(.3&O,7$D'*N:T]3'_4=BW6 MAA19#[4,9C3#TI%&1SA[F51C-.RDC,6+#J&%RUXENAH7I"D&<* !JCSSG^L MAB"@>B@<PI#@FX+*-AUS@\5PH]^T0H>ND!E1...

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 Thanks: Tomáš Golembiovský --- v2v/virt-v2v.pod | 38 ++++++++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..0943bf305 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,32 @@ that

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 --- v2v/virt-v2v.pod | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..93d1a9ecd 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,33 @@ that guest through the RHV-M UI,