zfs crypto discuss - May 2008 - [Bug 1975] New: ''key -l'' shouldn''t ask for input if keystatus= available with key formator=prompt

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975

           Summary: ''key -l'' shouldn''t ask for input
if keystatus=available
                    with key formator=prompt
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


build: zfs-crypto-gate-2008-05-15-12:38

# zpool create -o keysource=passphrase,prompt tank /export/home/testfile 
Enter passphrase for ''tank'': 
Enter again: 
# zpool key -l tank
Enter passphrase for ''tank'': 
Enter passphrase for ''tank'': 
Enter passphrase for ''tank'': 
Key error in ''tank'': Key already loaded.

# zfs create -o keysource=passphrase,prompt -o encryption=on -o
keyscope=dataset tank/fs                       
Enter passphrase for ''tank/fs'': 
Enter again: 
# zfs key -l tank/fs
Enter passphrase for ''tank/fs'': 
Key error in ''tank/fs'': Key already loaded.
# zfs key -u tank/fs
# zfs key -l tank/fs
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Key error in ''tank/fs'': Unknown error
#

It should fail directly instead of asking for user interaction and validating
the key value. 

Test case zpool_key_l_004 hangs.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |INCOMPLETE




--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-19 01:50:40 ---
Looks like there are multiple different issues being discussed here:

1) zpool and zfs are inconsistent in what they do when the key is already
present

That is easily resolved.

2) zpool and zfs both prompt for the key when it is already present.

I can see why zpool does this but not zfs.

3) something else with zfs key -l that I don''t understand what is being
asked:

# zfs key -u tank/fs
# zfs key -l tank/fs
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Key error in ''tank/fs'': Unknown error
#

What was entered for the passphrase in this case ?

Depending on what was entered "unknown error" could be correct even if
not
friendly.  Looks like bug  1976 might be logged to address this part though. 
Marking incomplete for now to get confirmation of case 3.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975





--- Comment #2 from Grace <hua.tang at sun.com>  2008-05-19 02:06:52 ---
Yes. For case 3, the entered in passphrase wasn''t correct. I filed bug
1976 to
record it separately. If the entered in is correct, it is:

# zfs key -l tank/fs
Enter passphrase for ''tank/fs'': 
Key error in ''tank/fs'': Key already loaded.

# zpool key -l tank
Enter passphrase for ''tank'': 
Key error in ''tank'': Key already loaded.

If the entered in isn''t crorect, it is:
# zfs key -l tank/fs
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Enter passphrase for ''tank/fs'': 
Key error in ''tank/fs'': Unknown error

# zpool key -l tank
Enter passphrase for ''tank'': 
Enter passphrase for ''tank'': 
Enter passphrase for ''tank'': 
Key error in ''tank'': Unknown error

So ''zpool'' and ''zfs'' are consistent, the
real issues are case 2(prompt for key)
and bug 1976.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|INCOMPLETE                  |FIXINPROGRESS




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ajscarp at yahoo.com




--- Comment #3 from ajscarp at yahoo.com  2008-05-19 14:29:06 ---
I knew this looked familiar, I believe this got broke when fixing 1827 and
1848... So keep those two in mind while fixing this..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1975


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|FIXINPROGRESS               |CLOSED
         Resolution|                            |FIXED




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.