bugzilla-daemon at defect.opensolaris.org
2008-May-19 08:32 UTC
[Bug 1976] New: ''key -l'' error messages can be improved to indicate incorrect key
http://defect.opensolaris.org/bz/show_bug.cgi?id=1976 Summary: ''key -l'' error messages can be improved to indicate incorrect key Classification: Development Product: zfs-crypto Version: unspecified Platform: Other OS/Version: Solaris Status: NEW Severity: minor Priority: P4 Component: other AssignedTo: darrenm at opensolaris.org ReportedBy: hua.tang at sun.com QAContact: hua.tang at sun.com CC: zfs-crypto-discuss at opensolaris.org Estimated Hours: 0.0 # zpool create -o keysource=passphrase,prompt tank /export/home/testfile Enter passphrase for ''tank'': ==> Enter "test" here! Enter again: # zpool key -u tank # zpool key -l tank Enter passphrase for ''tank'': ==> Enter "t" here! Enter passphrase for ''tank'': ==> Enter "t" here! Enter passphrase for ''tank'': ==> Enter "t" here! Key error in ''tank'': Unknown error # ''key -l'' fail if the entered in isn''t correct. But "Unknown error" isn''t friendly. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
bugzilla-daemon at defect.opensolaris.org
2008-May-19 08:40 UTC
[Bug 1976] ''key -l'' error messages can be improved to indicate incorrect key
http://defect.opensolaris.org/bz/show_bug.cgi?id=1976 Darren J Moffat <darrenm at opensolaris.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|darrenm at opensolaris.org |ajscarp at yahoo.com -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
bugzilla-daemon at defect.opensolaris.org
2008-May-19 13:17 UTC
[Bug 1976] ''key -l'' error messages can be improved to indicate incorrect key
http://defect.opensolaris.org/bz/show_bug.cgi?id=1976 Darren J Moffat <darrenm at opensolaris.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darrenm at opensolaris.org --- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 2008-05-19 06:17:58 --- Similarly when the key file isn''t present we should print the name of the missing file: braveheart# zfs key -l t/dsr Key error in ''t/dsr'': No such file or directory Would be easier to understant like this: braveheart# zfs key -l t/dsr Key load failed for ''t/dsr''. ''raw,file:///root/dsr.key'': No such file or directory Or something similar. The current message is to cryptic. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
bugzilla-daemon at defect.opensolaris.org
2008-May-20 16:44 UTC
[Bug 1976] ''key -l'' error messages can be improved to indicate incorrect key
http://defect.opensolaris.org/bz/show_bug.cgi?id=1976 --- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 2008-05-20 09:44:19 --- *** Bug 1657 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
bugzilla-daemon at defect.opensolaris.org
2008-May-21 06:43 UTC
[Bug 1976] ''key -l'' error messages can be improved to indicate incorrect key
http://defect.opensolaris.org/bz/show_bug.cgi?id=1976 ajscarp at yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXINSOURCE --- Comment #3 from ajscarp at yahoo.com 2008-05-20 23:43:31 --- This actually was a large bug.. The 3 attempts that Grace saw was because of the the passphrase entered was below the minimum size. But the error code was returned by zpool, instead of the library. Since the get_passphrase() function is really only for CLI operations, I changed it to send fprintf(stderr) instead of using zfs error functions. With respect to the message Darren saw.. The error msg was suppose to be more clear. The problem was the error handling in the switch() for zfs/zpool_key_load was overwriting the error returned by get_key_material(). By using a logging variable that alerts the code if there is a pending error message, I can skip the generic error message. -- Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.