zfs crypto discuss - May 2008 - [Bug 1974] New: ''zpool key -l'' fails after changing keysource locator by '' zpool set keysource''

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974

           Summary: ''zpool key -l'' fails after changing
keysource locator by
                    ''zpool set keysource''
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


build: zfs-crypto-gate-2008-05-15-12:38

It fails after changing keysource from/to passphrase,prompt to/from
passphrase,file. Changing between hex|raw,prompt and hex|raw,file works fine.

# zpool create -o keysource=passphrase,prompt tank /export/home/testfile 
Enter passphrase for ''tank'': ==> Enter test here!
Enter again: 
# echo test > /export/home/passphrase_file 
# zpool set keysource=passphrase,file:///export/home/passphrase_file tank
# zpool key -u tank
# zpool key -l tank
Key error in ''tank'': Key incorrect.
#

# zpool create -o keysource=passphrase,file:///export/home/passphrase_file tank
/export/home/testfile 
# zpool set keysource=passphrase,prompt tank
# zpool key -u tank
# zpool key -l tank
Enter passphrase for ''tank'': 
Key error in ''tank'': Key incorrect.

Test case zpool_set_keysource_005 fails because of this bug.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |INCOMPLETE




--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-19 12:36:27 ---
Does this only happen with ''zpool key'' or does it happen with
''zfs key'' as well
?

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


Grace <hua.tang at sun.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|''zpool key -l'' fails after  |''key
-l'' fails after
                   |changing keysource locator  |changing keysource locator
                   |by ''zpool set keysource''    |by
''set keysource''




--- Comment #2 from Grace <hua.tang at sun.com>  2008-05-19 19:09:07 ---
The failure also happens to "zfs key", but the error messages are a
little
different.I am changing the bug summary.

# zfs create -o keysource=passphrase,prompt -o encryption=on -o
keyscope=dataset tank/fs
Enter passphrase for ''tank/fs'': 
Enter again: 
# echo test > /export/home/passphrase_file 
# zfs set keysource=passphrase,file:///export/home/passphrase_file tank/fs
# zfs key -u tank
# zfs key -l tank
Key error in ''tank'': Encryption not enabled.
#

# zfs create -o keysource=passphrase,file:///export/home/passphrase_file  -o
encryption=on -o keyscope=dataset tank/fs
# zfs set keysource=passphrase,prompt tank/fs
# zfs key -u tank
# zfs key -l tank
Key error in ''tank'': Encryption not enabled.
#

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ajscarp at yahoo.com




--- Comment #3 from ajscarp at yahoo.com  2008-05-19 23:22:47 ---
My test machine, with post-5-15 bits doesn''t have the zfs problem your
seeing..
I''ll look into this further..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974





--- Comment #4 from ajscarp at yahoo.com  2008-05-20 11:56:48 ---
Comment #2 with the zfs command is invalid..

The ''zfs'' command is using ''tank/fs'' to for
keysource, but you are unloading &
loading ''tank'' the other operation..  ''tank''
does not have any crypto enabled
which is the correct answer here..

# zfs set keysource=passphrase,prompt tank/fs
# zfs key -u tank
# zfs key -l tank
Key error in ''tank'': Encryption not enabled.

I will look at the initial problem with zpool..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974





--- Comment #5 from ajscarp at yahoo.com  2008-05-20 14:05:32 ---
zpool is working fine for me as well.. You may be seeing a problem with your
''echo'' command..

Instead try 
echo -n "test" > /export/home/passphrase_file

I think your echo command is appending a return at the end of the file.. so
your passphrase_file is probably 5 characters long instead of 4..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974





--- Comment #6 from Grace <hua.tang at sun.com>  2008-05-20 19:23:58 ---
You are right. That''s the "Enter" problem.

But I think it''s common for users to add an "Enter" at the
end of a text file,
so it''s better to make "Enter" as a special character and let
validation pass.
Especially when changing a passphrase file to prompt, how to enter an
"Enter"?

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974





--- Comment #7 from ajscarp at yahoo.com  2008-05-20 23:47:09 ---
I think we talked about this in the past.. But I''m a bit hesitant in
making the
code too smart and perhaps breaking something.. Let me think about this
overnight..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|INCOMPLETE                  |CAUSEKNOWN




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1974


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ajscarp at yahoo.com           |
             Status|CAUSEKNOWN                  |RESOLVED
         Resolution|                            |FIXINSOURCE




--- Comment #8 from ajscarp at yahoo.com  2008-05-27 23:26:53 ---
Fix integrated into gate

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.