Ian Campbell
2013-Nov-22 16:24 UTC
[PATCH v2 02/15] xen: arm64: Add Basic Platform support for APM X-Gene Storm.
From: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
This patch adds initial platform stubs for APM X-Gene.
Signed-off-by: Anup Patel <anup.patel@linaro.org>
Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Drop earlyprintk (split into earlier patch). Only build on ARM64.
Drop empty init and reset hooks and enable 1:1 workaround.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
v2: Drop empty hooks, merge the 1:1 workaround patch, drop early_printk.h
---
xen/arch/arm/platforms/Makefile | 1 +
xen/arch/arm/platforms/xgene-storm.c | 52 ++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+)
create mode 100644 xen/arch/arm/platforms/xgene-storm.c
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index f0dd72c..680364f 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -3,3 +3,4 @@ obj-$(CONFIG_ARM_32) += exynos5.o
obj-$(CONFIG_ARM_32) += midway.o
obj-$(CONFIG_ARM_32) += omap5.o
obj-$(CONFIG_ARM_32) += sunxi.o
+obj-$(CONFIG_ARM_64) += xgene-storm.o
diff --git a/xen/arch/arm/platforms/xgene-storm.c
b/xen/arch/arm/platforms/xgene-storm.c
new file mode 100644
index 0000000..727ac2b
--- /dev/null
+++ b/xen/arch/arm/platforms/xgene-storm.c
@@ -0,0 +1,52 @@
+/*
+ * xen/arch/arm/platforms/xgene-storm.c
+ *
+ * Applied Micro''s X-Gene specific settings
+ *
+ * Pranavkumar Sawargaonkar <psawargaonkar@apm.com>
+ * Anup Patel <apatel@apm.com>
+ * Copyright (c) 2013 Applied Micro.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/config.h>
+#include <xen/device_tree.h>
+#include <xen/domain_page.h>
+#include <xen/mm.h>
+#include <xen/vmap.h>
+#include <asm/platform.h>
+
+static uint32_t xgene_storm_quirks(void)
+{
+ return PLATFORM_QUIRK_DOM0_MAPPING_11;
+}
+
+
+static const char const *xgene_storm_dt_compat[] __initdata +{
+ "apm,xgene-storm",
+ NULL
+};
+
+PLATFORM_START(xgene_storm, "APM X-GENE STORM")
+ .compatible = xgene_storm_dt_compat,
+ .quirks = xgene_storm_quirks,
+PLATFORM_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--
1.7.10.4
Julien Grall
2013-Nov-22 16:35 UTC
Re: [PATCH v2 02/15] xen: arm64: Add Basic Platform support for APM X-Gene Storm.
On 11/22/2013 04:24 PM, Ian Campbell wrote:> From: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > > This patch adds initial platform stubs for APM X-Gene. > > Signed-off-by: Anup Patel <anup.patel@linaro.org> > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > > Drop earlyprintk (split into earlier patch). Only build on ARM64. > > Drop empty init and reset hooks and enable 1:1 workaround. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > v2: Drop empty hooks, merge the 1:1 workaround patch, drop early_printk.h > ---[..]> diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c > new file mode 100644 > index 0000000..727ac2b > --- /dev/null > +++ b/xen/arch/arm/platforms/xgene-storm.c > @@ -0,0 +1,52 @@ > +/* > + * xen/arch/arm/platforms/xgene-storm.c > + * > + * Applied Micro''s X-Gene specific settings > + * > + * Pranavkumar Sawargaonkar <psawargaonkar@apm.com> > + * Anup Patel <apatel@apm.com> > + * Copyright (c) 2013 Applied Micro. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <xen/config.h>> +#include <xen/device_tree.h> > +#include <xen/domain_page.h> > +#include <xen/mm.h> > +#include <xen/vmap.h>Do we really need these 4 includes?> +#include <asm/platform.h> > + > +static uint32_t xgene_storm_quirks(void) > +{ > + return PLATFORM_QUIRK_DOM0_MAPPING_11; > +} > + > + > +static const char const *xgene_storm_dt_compat[] __initdataconst char * const ... __initconst Except that: Acked-by: Julien Grall <julien.grall@linaro.org>> +{ > + "apm,xgene-storm", > + NULL > +}; > + > +PLATFORM_START(xgene_storm, "APM X-GENE STORM") > + .compatible = xgene_storm_dt_compat, > + .quirks = xgene_storm_quirks, > +PLATFORM_END > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ >-- Julien Grall
Ian Campbell
2013-Nov-22 16:43 UTC
Re: [PATCH v2 02/15] xen: arm64: Add Basic Platform support for APM X-Gene Storm.
On Fri, 2013-11-22 at 16:35 +0000, Julien Grall wrote:> > On 11/22/2013 04:24 PM, Ian Campbell wrote: > > From: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > > > > This patch adds initial platform stubs for APM X-Gene. > > > > Signed-off-by: Anup Patel <anup.patel@linaro.org> > > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > > > > Drop earlyprintk (split into earlier patch). Only build on ARM64. > > > > Drop empty init and reset hooks and enable 1:1 workaround. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > --- > > v2: Drop empty hooks, merge the 1:1 workaround patch, drop early_printk.h > > --- > > [..] > > > diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c > > new file mode 100644 > > index 0000000..727ac2b > > --- /dev/null > > +++ b/xen/arch/arm/platforms/xgene-storm.c > > @@ -0,0 +1,52 @@ > > +/* > > + * xen/arch/arm/platforms/xgene-storm.c > > + * > > + * Applied Micro''s X-Gene specific settings > > + * > > + * Pranavkumar Sawargaonkar <psawargaonkar@apm.com> > > + * Anup Patel <apatel@apm.com> > > + * Copyright (c) 2013 Applied Micro. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include <xen/config.h> > > > > +#include <xen/device_tree.h> > > +#include <xen/domain_page.h> > > +#include <xen/mm.h> > > +#include <xen/vmap.h> > > Do we really need these 4 includes?No, leftovers from an incomplete attempt to implement the reset hook etc. Nuked.> > +#include <asm/platform.h> > > + > > +static uint32_t xgene_storm_quirks(void) > > +{ > > + return PLATFORM_QUIRK_DOM0_MAPPING_11; > > +} > > + > > + > > +static const char const *xgene_storm_dt_compat[] __initdata > > const char * const ... __initconstDone.> Except that: > Acked-by: Julien Grall <julien.grall@linaro.org>Thanks. Ian.