Xen devel - Nov 2013 - [PATCH] x86/Intel: don't probe CPUID faulting on family 0xf CPUs

These are known to not support the feature, so we can save ourselves
from emitting the resulting #GP fault recovery related message (which
might worry people looking at the logs).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -204,7 +204,7 @@ static void __devinit init_intel(struct 
 		detect_ht(c);
 	}
 
-	if (smp_processor_id() == 0) {
+	if (c == &boot_cpu_data && c->x86 == 6) {
 		if (probe_intel_cpuid_faulting())
 			set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
 	} else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {





_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Jan Beulich wrote:
> These are known to not support the feature, so we can save ourselves
> from emitting the resulting #GP fault recovery related message (which
> might worry people looking at the logs).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -204,7 +204,7 @@ static void __devinit init_intel(struct
>  		detect_ht(c);
>  	}
> 
> -	if (smp_processor_id() == 0) {
> +	if (c == &boot_cpu_data && c->x86 == 6) {
>  		if (probe_intel_cpuid_faulting())
>  			set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
>  	} else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {

Acked-by: Liu Jinsong <jinsong.liu@intel.com>

On 11/11/2013 08:12, "Jan Beulich" <JBeulich@suse.com> wrote:
> These are known to not support the feature, so we can save ourselves
> from emitting the resulting #GP fault recovery related message (which
> might worry people looking at the logs).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -204,7 +204,7 @@ static void __devinit init_intel(struct
> detect_ht(c);
> }
>  
> - if (smp_processor_id() == 0) {
> + if (c == &boot_cpu_data && c->x86 == 6) {
> if (probe_intel_cpuid_faulting())
> set_bit(X86_FEATURE_CPUID_FAULTING, c->x86_capability);
> } else if (boot_cpu_has(X86_FEATURE_CPUID_FAULTING)) {
> 
> 
>