Xen devel - Jan 2011 - Re: pvusb drivers for pvops 2.6.32.x kernel

Hello,

Jeremy: See the included patch. If it''s OK it''d be nice
to get it into xen/stable-2.6.32.x branch.

Thanks Nathanael!

-- Pasi

----- Forwarded message from Nathanael Rensen <nathanael@polymorpheus.com>
-----

From: Nathanael Rensen <nathanael@polymorpheus.com>
To: Pasi Kärkkäinen <pasik@iki.fi>
Cc: n_iwamatsu@jp.fujitsu.com
Date: Mon, 3 Jan 2011 19:32:23 +0800
Subject: Re: pvusb for pvops

On 1 January 2011 23:19, Nathanael Rensen <nathanael@polymorpheus.com>
wrote:
> On 1 January 2011 22:43, Pasi Kärkkäinen <pasik@iki.fi> wrote:
>> On Sat, Jan 01, 2011 at 03:10:58AM +0800, Nathanael Rensen wrote:
>>> Hi Noboru,
>>>
>>> In case it is helpful ...
>>>
>>> I''ve attached a diff that adds the pvusb drivers to the
debian squeeze
>>> 2.6.32 pvops kernel.
>>> So far I''ve only tested with a USB drive on xen 4.0.1
between debian
>>> squeeze pvops dom0 and
>>> debian squeeze pvops domU.
>>>
>>> The diff is based on the SLES SP1 diffs posted here:
>>>   http://code.google.com/p/gentoo-xen-kernel/downloads/list
>>> It almost applies cleanly to xen/stable-2.6.32.x except for the
patch to
>>> include/xen/interface/io/ring.h which is not required for
xen/stable-2.6.32.x.
>>> I haven''t tested the xen/stable-2.6.32.x kernel though.
>>>
>>
>> Great, thanks!
>> Is it OK to forward this email to xen-devel mailinglist?
>>
>> Btw did you check from novell''s kernel git tree if there
>> has been fixes to the pvusb code after that patch on
>> code.google.com was posted?
>>
>> -- Pasi
>
> For sure, you''re welcome to forward it, but maybe hold off a bit
because
> I''ve refactored the pvusb frontend code to be consistent with the
way the
> other frontend drivers are within the pvops tree. I''ll also take a
look at
> Novell''s tree to check for updates.
>
> I''ll do some testing on a kernel built from the pvops
stable-2.6.32.x tree
> and send an updated diff against that tree in the next couple of days.
>
> Nathanael
>
I''ve attached an updated diff against the pvops xen/stable-2.6.32.x
tree.
I''ve tested by attaching an af9015 USB TV tuner to a pvops domu from
a pvops dom0 and recording a few hours of TV.

I also tried to attach various USB devices to a WinXP domu with GPLPV
drivers, but the domu kept crashing. That needs more investigation, but
I suspect a problem with the GPLPV drivers. I''m keen for that to be
fixed,
but I don''t have time immediately to dig into it.

I took a look at the patches at
http://gitorious.org/opensuse/kernel-source/trees/SLE11-SP1/patches.xen
and as far as I can tell, everything that relates to pvusb is included in the
attached patch.

Nathanael



----- End forwarded message -----


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Mon, 2011-01-03 at 11:41 +0000, Pasi Kärkkäinen
wrote:
> Hello,
> 
> Jeremy: See the included patch. If it''s OK it''d be nice
> to get it into xen/stable-2.6.32.x branch.
> 
> Thanks Nathanael!
Yes thanks!

I think the correct path for this functionality is to first get it
accepted into the upstream kernel by working with the USB subsystem
maintainer+list, fixing the issue arising from their review etc.

The stuff necessary to get the frontend upstream has been upstream for
ages. For the backend basic dom0 boot support is in 2.6.37 and the
generic scaffolding for backends is currently in linux-next (via
Konrad''s tree) and is intended to be in the next merge window.

I think the backend just looks like a regular USB driver to the host
system so it probably belongs in drivers/usb/<something>/xen-usbback/
and not drivers/xen. (I''m not sure what the <something> should
be,
perhaps "misc").

IIRC when the PV USB drivers were originally submitted there was no
toolstack support included. Has this since been implemented? Seems to be
missing from libxl at least. Is someone looking into this?

Ian.
> 
> -- Pasi
> 
> ----- Forwarded message from Nathanael Rensen
<nathanael@polymorpheus.com> -----
> 
> From: Nathanael Rensen <nathanael@polymorpheus.com>
> To: Pasi Kärkkäinen <pasik@iki.fi>
> Cc: n_iwamatsu@jp.fujitsu.com
> Date: Mon, 3 Jan 2011 19:32:23 +0800
> Subject: Re: pvusb for pvops
> 
> On 1 January 2011 23:19, Nathanael Rensen
<nathanael@polymorpheus.com> wrote:
> > On 1 January 2011 22:43, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> >> On Sat, Jan 01, 2011 at 03:10:58AM +0800, Nathanael Rensen wrote:
> >>> Hi Noboru,
> >>>
> >>> In case it is helpful ...
> >>>
> >>> I''ve attached a diff that adds the pvusb drivers to
the debian squeeze
> >>> 2.6.32 pvops kernel.
> >>> So far I''ve only tested with a USB drive on xen 4.0.1
between debian
> >>> squeeze pvops dom0 and
> >>> debian squeeze pvops domU.
> >>>
> >>> The diff is based on the SLES SP1 diffs posted here:
> >>>   http://code.google.com/p/gentoo-xen-kernel/downloads/list
> >>> It almost applies cleanly to xen/stable-2.6.32.x except for
the patch to
> >>> include/xen/interface/io/ring.h which is not required for
xen/stable-2.6.32.x.
> >>> I haven''t tested the xen/stable-2.6.32.x kernel
though.
> >>>
> >>
> >> Great, thanks!
> >> Is it OK to forward this email to xen-devel mailinglist?
> >>
> >> Btw did you check from novell''s kernel git tree if there
> >> has been fixes to the pvusb code after that patch on
> >> code.google.com was posted?
> >>
> >> -- Pasi
> >
> > For sure, you''re welcome to forward it, but maybe hold off a
bit because
> > I''ve refactored the pvusb frontend code to be consistent with
the way the
> > other frontend drivers are within the pvops tree. I''ll also
take a look at
> > Novell''s tree to check for updates.
> >
> > I''ll do some testing on a kernel built from the pvops
stable-2.6.32.x tree
> > and send an updated diff against that tree in the next couple of days.
> >
> > Nathanael
> >
> 
> I''ve attached an updated diff against the pvops
xen/stable-2.6.32.x tree.
> I''ve tested by attaching an af9015 USB TV tuner to a pvops domu
from
> a pvops dom0 and recording a few hours of TV.
> 
> I also tried to attach various USB devices to a WinXP domu with GPLPV
> drivers, but the domu kept crashing. That needs more investigation, but
> I suspect a problem with the GPLPV drivers. I''m keen for that to
be fixed,
> but I don''t have time immediately to dig into it.
> 
> I took a look at the patches at
> http://gitorious.org/opensuse/kernel-source/trees/SLE11-SP1/patches.xen
> and as far as I can tell, everything that relates to pvusb is included in
the
> attached patch.
> 
> Nathanael
> 
> 
> 
> ----- End forwarded message -----


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Jan 04, 2011 at 09:33:39AM +0000, Ian Campbell
wrote:
> On Mon, 2011-01-03 at 11:41 +0000, Pasi Kärkkäinen wrote:
> > Hello,
> > 
> > Jeremy: See the included patch. If it''s OK it''d be
nice
> > to get it into xen/stable-2.6.32.x branch.
> > 
> > Thanks Nathanael!
> 
> Yes thanks!
> 
Added Nathanael to CC, I forgot him earlier.. doh.
> I think the correct path for this functionality is to first get it
> accepted into the upstream kernel by working with the USB subsystem
> maintainer+list, fixing the issue arising from their review etc.
> 
Ok.
> The stuff necessary to get the frontend upstream has been upstream for
> ages. For the backend basic dom0 boot support is in 2.6.37 and the
> generic scaffolding for backends is currently in linux-next (via
> Konrad''s tree) and is intended to be in the next merge window.
> 
> I think the backend just looks like a regular USB driver to the host
> system so it probably belongs in drivers/usb/<something>/xen-usbback/
> and not drivers/xen. (I''m not sure what the <something>
should be,
> perhaps "misc").
> 
Yeah, maybe the USB maintainers can suggest proper location.
> IIRC when the PV USB drivers were originally submitted there was no
> toolstack support included. Has this since been implemented? Seems to be
> missing from libxl at least. Is someone looking into this?
> 
Xen 4.0.0 added pvusb toolstack support to xm/xend.

This driver is ported (by Nathanael) from Novell SLES11SP1 2.6.32 Xenlinux
kernel,
where it works with xm/xend.

Some info here:
http://wiki.xen.org/xenwiki/XenUSBPassthrough

and:
http://wiki.xen.org/xenwiki/Xen4.0

-- Pasi
> Ian.
> 
> > 
> > -- Pasi
> > 
> > ----- Forwarded message from Nathanael Rensen
<nathanael@polymorpheus.com> -----
> > 
> > From: Nathanael Rensen <nathanael@polymorpheus.com>
> > To: Pasi Kärkkäinen <pasik@iki.fi>
> > Cc: n_iwamatsu@jp.fujitsu.com
> > Date: Mon, 3 Jan 2011 19:32:23 +0800
> > Subject: Re: pvusb for pvops
> > 
> > On 1 January 2011 23:19, Nathanael Rensen
<nathanael@polymorpheus.com> wrote:
> > > On 1 January 2011 22:43, Pasi Kärkkäinen <pasik@iki.fi>
wrote:
> > >> On Sat, Jan 01, 2011 at 03:10:58AM +0800, Nathanael Rensen
wrote:
> > >>> Hi Noboru,
> > >>>
> > >>> In case it is helpful ...
> > >>>
> > >>> I''ve attached a diff that adds the pvusb drivers
to the debian squeeze
> > >>> 2.6.32 pvops kernel.
> > >>> So far I''ve only tested with a USB drive on xen
4.0.1 between debian
> > >>> squeeze pvops dom0 and
> > >>> debian squeeze pvops domU.
> > >>>
> > >>> The diff is based on the SLES SP1 diffs posted here:
> > >>>  
http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > >>> It almost applies cleanly to xen/stable-2.6.32.x except
for the patch to
> > >>> include/xen/interface/io/ring.h which is not required for
xen/stable-2.6.32.x.
> > >>> I haven''t tested the xen/stable-2.6.32.x kernel
though.
> > >>>
> > >>
> > >> Great, thanks!
> > >> Is it OK to forward this email to xen-devel mailinglist?
> > >>
> > >> Btw did you check from novell''s kernel git tree if
there
> > >> has been fixes to the pvusb code after that patch on
> > >> code.google.com was posted?
> > >>
> > >> -- Pasi
> > >
> > > For sure, you''re welcome to forward it, but maybe hold
off a bit because
> > > I''ve refactored the pvusb frontend code to be consistent
with the way the
> > > other frontend drivers are within the pvops tree. I''ll
also take a look at
> > > Novell''s tree to check for updates.
> > >
> > > I''ll do some testing on a kernel built from the pvops
stable-2.6.32.x tree
> > > and send an updated diff against that tree in the next couple of
days.
> > >
> > > Nathanael
> > >
> > 
> > I''ve attached an updated diff against the pvops
xen/stable-2.6.32.x tree.
> > I''ve tested by attaching an af9015 USB TV tuner to a pvops
domu from
> > a pvops dom0 and recording a few hours of TV.
> > 
> > I also tried to attach various USB devices to a WinXP domu with GPLPV
> > drivers, but the domu kept crashing. That needs more investigation,
but
> > I suspect a problem with the GPLPV drivers. I''m keen for that
to be fixed,
> > but I don''t have time immediately to dig into it.
> > 
> > I took a look at the patches at
> >
http://gitorious.org/opensuse/kernel-source/trees/SLE11-SP1/patches.xen
> > and as far as I can tell, everything that relates to pvusb is included
in the
> > attached patch.
> > 
> > Nathanael
> > 
> > 
> > 
> > ----- End forwarded message -----
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Jan 04, 2011 at 09:33:39AM +0000, Ian Campbell
wrote:
>
> I think the correct path for this functionality is to first get it
> accepted into the upstream kernel by working with the USB subsystem
> maintainer+list, fixing the issue arising from their review etc.
I''m happy to have a shot at that. I don''t imagine it will be a
quick
process so in the meantime I think there is value in supporting pvusb
in stable/2.6.32.x to encourage people to test and identify issues,
and also to make it easier to track the maintenance.
> The stuff necessary to get the frontend upstream has been upstream for
> ages. For the backend basic dom0 boot support is in 2.6.37 and the
> generic scaffolding for backends is currently in linux-next (via
> Konrad''s tree) and is intended to be in the next merge window.
>
> I think the backend just looks like a regular USB driver to the host
> system so it probably belongs in drivers/usb/<something>/xen-usbback/
> and not drivers/xen. (I''m not sure what the <something>
should be,
> perhaps "misc").
I agree that the frontend driver looks like a regular USB host
controller driver and belongs in drivers/usb/host. From the dom0
perspective the backend driver is a consumer of USB services rather
than a provider so my inclination is that the proper place for the
backend is drivers/xen along with blkback, netback and pciback. Much
the same way as I would expect to find a USB TV tuner driver in
drivers/media rather than drivers/usb. I would prefer to remain
consistent with the model established by the block, net and pci
drivers, but I am happy to adopt whatever convention is acceptable to
upstream.

Nathanael
> Ian.
>> > ----- Forwarded message from Nathanael Rensen
<nathanael@polymorpheus.com> -----
>> >
>> > From: Nathanael Rensen <nathanael@polymorpheus.com>
>> > To: Pasi Kärkkäinen <pasik@iki.fi>
>> > Cc: n_iwamatsu@jp.fujitsu.com
>> > Date: Mon, 3 Jan 2011 19:32:23 +0800
>> > Subject: Re: pvusb for pvops
>> >
>> > On 1 January 2011 23:19, Nathanael Rensen
<nathanael@polymorpheus.com> wrote:
>> > > On 1 January 2011 22:43, Pasi Kärkkäinen <pasik@iki.fi>
wrote:
>> > >> On Sat, Jan 01, 2011 at 03:10:58AM +0800, Nathanael
Rensen wrote:
>> > >>> Hi Noboru,
>> > >>>
>> > >>> In case it is helpful ...
>> > >>>
>> > >>> I''ve attached a diff that adds the pvusb
drivers to the debian squeeze
>> > >>> 2.6.32 pvops kernel.
>> > >>> So far I''ve only tested with a USB drive on
xen 4.0.1 between debian
>> > >>> squeeze pvops dom0 and
>> > >>> debian squeeze pvops domU.
>> > >>>
>> > >>> The diff is based on the SLES SP1 diffs posted here:
>> > >>>  
http://code.google.com/p/gentoo-xen-kernel/downloads/list
>> > >>> It almost applies cleanly to xen/stable-2.6.32.x
except for the patch to
>> > >>> include/xen/interface/io/ring.h which is not required
for xen/stable-2.6.32.x.
>> > >>> I haven''t tested the xen/stable-2.6.32.x
kernel though.
>> > >>>
>> > >>
>> > >> Great, thanks!
>> > >> Is it OK to forward this email to xen-devel mailinglist?
>> > >>
>> > >> Btw did you check from novell''s kernel git tree
if there
>> > >> has been fixes to the pvusb code after that patch on
>> > >> code.google.com was posted?
>> > >>
>> > >> -- Pasi
>> > >
>> > > For sure, you''re welcome to forward it, but maybe
hold off a bit because
>> > > I''ve refactored the pvusb frontend code to be
consistent with the way the
>> > > other frontend drivers are within the pvops tree.
I''ll also take a look at
>> > > Novell''s tree to check for updates.
>> > >
>> > > I''ll do some testing on a kernel built from the
pvops stable-2.6.32.x tree
>> > > and send an updated diff against that tree in the next couple
of days.
>> > >
>> > > Nathanael
>> > >
>> >
>> > I''ve attached an updated diff against the pvops
xen/stable-2.6.32.x tree.
>> > I''ve tested by attaching an af9015 USB TV tuner to a
pvops domu from
>> > a pvops dom0 and recording a few hours of TV.
>> >
>> > I also tried to attach various USB devices to a WinXP domu with
GPLPV
>> > drivers, but the domu kept crashing. That needs more
investigation, but
>> > I suspect a problem with the GPLPV drivers. I''m keen for
that to be fixed,
>> > but I don''t have time immediately to dig into it.
>> >
>> > I took a look at the patches at
>> >
http://gitorious.org/opensuse/kernel-source/trees/SLE11-SP1/patches.xen
>> > and as far as I can tell, everything that relates to pvusb is
included in the
>> > attached patch.
>> >
>> > Nathanael
>> >
>> >
>> >
>> > ----- End forwarded message -----
>>
>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Jan 05, 2011 at 09:07:49PM +0800, Nathanael Rensen
wrote:
> On Tue, Jan 04, 2011 at 09:33:39AM +0000, Ian Campbell wrote:
> >
> > I think the correct path for this functionality is to first get it
> > accepted into the upstream kernel by working with the USB subsystem
> > maintainer+list, fixing the issue arising from their review etc.
> 
> I''m happy to have a shot at that. I don''t imagine it will
be a quick
> process so in the meantime I think there is value in supporting pvusb
> in stable/2.6.32.x to encourage people to test and identify issues,
> and also to make it easier to track the maintenance.
> 
Yeah, at least earlier Jeremy said he''s happy to take most patches for
xen/stable-2.6.32.x :)
> > The stuff necessary to get the frontend upstream has been upstream for
> > ages. For the backend basic dom0 boot support is in 2.6.37 and the
> > generic scaffolding for backends is currently in linux-next (via
> > Konrad''s tree) and is intended to be in the next merge
window.
> >
> > I think the backend just looks like a regular USB driver to the host
> > system so it probably belongs in
drivers/usb/<something>/xen-usbback/
> > and not drivers/xen. (I''m not sure what the <something>
should be,
> > perhaps "misc").
> 
> I agree that the frontend driver looks like a regular USB host
> controller driver and belongs in drivers/usb/host. From the dom0
> perspective the backend driver is a consumer of USB services rather
> than a provider so my inclination is that the proper place for the
> backend is drivers/xen along with blkback, netback and pciback. Much
> the same way as I would expect to find a USB TV tuner driver in
> drivers/media rather than drivers/usb. I would prefer to remain
> consistent with the model established by the block, net and pci
> drivers, but I am happy to adopt whatever convention is acceptable to
> upstream.
> 
Something I noticed about the pvusb backend..
Should the name of the driver be xen-usbbk instead of just usbbk ?

The other backend driver modules seem to have xen- prefix.

-- Pasi

> Nathanael
> 
> > Ian.
> 
> >> > ----- Forwarded message from Nathanael Rensen
<nathanael@polymorpheus.com> -----
> >> >
> >> > From: Nathanael Rensen <nathanael@polymorpheus.com>
> >> > To: Pasi Kärkkäinen <pasik@iki.fi>
> >> > Cc: n_iwamatsu@jp.fujitsu.com
> >> > Date: Mon, 3 Jan 2011 19:32:23 +0800
> >> > Subject: Re: pvusb for pvops
> >> >
> >> > On 1 January 2011 23:19, Nathanael Rensen
<nathanael@polymorpheus.com> wrote:
> >> > > On 1 January 2011 22:43, Pasi Kärkkäinen
<pasik@iki.fi> wrote:
> >> > >> On Sat, Jan 01, 2011 at 03:10:58AM +0800, Nathanael
Rensen wrote:
> >> > >>> Hi Noboru,
> >> > >>>
> >> > >>> In case it is helpful ...
> >> > >>>
> >> > >>> I''ve attached a diff that adds the
pvusb drivers to the debian squeeze
> >> > >>> 2.6.32 pvops kernel.
> >> > >>> So far I''ve only tested with a USB
drive on xen 4.0.1 between debian
> >> > >>> squeeze pvops dom0 and
> >> > >>> debian squeeze pvops domU.
> >> > >>>
> >> > >>> The diff is based on the SLES SP1 diffs posted
here:
> >> > >>>  
http://code.google.com/p/gentoo-xen-kernel/downloads/list
> >> > >>> It almost applies cleanly to xen/stable-2.6.32.x
except for the patch to
> >> > >>> include/xen/interface/io/ring.h which is not
required for xen/stable-2.6.32.x.
> >> > >>> I haven''t tested the
xen/stable-2.6.32.x kernel though.
> >> > >>>
> >> > >>
> >> > >> Great, thanks!
> >> > >> Is it OK to forward this email to xen-devel
mailinglist?
> >> > >>
> >> > >> Btw did you check from novell''s kernel git
tree if there
> >> > >> has been fixes to the pvusb code after that patch on
> >> > >> code.google.com was posted?
> >> > >>
> >> > >> -- Pasi
> >> > >
> >> > > For sure, you''re welcome to forward it, but
maybe hold off a bit because
> >> > > I''ve refactored the pvusb frontend code to be
consistent with the way the
> >> > > other frontend drivers are within the pvops tree.
I''ll also take a look at
> >> > > Novell''s tree to check for updates.
> >> > >
> >> > > I''ll do some testing on a kernel built from the
pvops stable-2.6.32.x tree
> >> > > and send an updated diff against that tree in the next
couple of days.
> >> > >
> >> > > Nathanael
> >> > >
> >> >
> >> > I''ve attached an updated diff against the pvops
xen/stable-2.6.32.x tree.
> >> > I''ve tested by attaching an af9015 USB TV tuner to a
pvops domu from
> >> > a pvops dom0 and recording a few hours of TV.
> >> >
> >> > I also tried to attach various USB devices to a WinXP domu
with GPLPV
> >> > drivers, but the domu kept crashing. That needs more
investigation, but
> >> > I suspect a problem with the GPLPV drivers. I''m keen
for that to be fixed,
> >> > but I don''t have time immediately to dig into it.
> >> >
> >> > I took a look at the patches at
> >> >
http://gitorious.org/opensuse/kernel-source/trees/SLE11-SP1/patches.xen
> >> > and as far as I can tell, everything that relates to pvusb is
included in the
> >> > attached patch.
> >> >
> >> > Nathanael
> >> >
> >> >
> >> >
> >> > ----- End forwarded message -----
> >>
> >>
> >
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 7 January 2011 02:55, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> Something I noticed about the pvusb backend..
> Should the name of the driver be xen-usbbk instead of just usbbk ?
>
> The other backend driver modules seem to have xen- prefix.
>
> -- Pasi
Good point - although I think xen-usbback would better match
xen-blkback, xen-netback, xen-pciback.

For consistency the config options should probably be
CONFIG_XEN_USBDEV_BACKEND and CONFIG_XEN_USBDEV_FRONTEND (the previous
patch had CONFIG_XEN_USB_...).

I also noticed the frontend driver was producing a warning when
loading which is resolved by setting the module owner.

I''ve placed an updated diff here:
http://members.iinet.net.au/~nathanael/pvusb.diff

Nathanael


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, 2011-01-06 at 18:55 +0000, Pasi Kärkkäinen
wrote:
> On Wed, Jan 05, 2011 at 09:07:49PM +0800, Nathanael Rensen wrote:
> > On Tue, Jan 04, 2011 at 09:33:39AM +0000, Ian Campbell wrote:
> > >
> > > I think the correct path for this functionality is to first get
it
> > > accepted into the upstream kernel by working with the USB
subsystem
> > > maintainer+list, fixing the issue arising from their review etc.
> > 
> > I''m happy to have a shot at that. I don''t imagine it
will be a quick
> > process so in the meantime I think there is value in supporting pvusb
> > in stable/2.6.32.x to encourage people to test and identify issues,
> > and also to make it easier to track the maintenance.
> > 
> 
> Yeah, at least earlier Jeremy said he''s happy to take most patches
for xen/stable-2.6.32.x :)
I have fewer objections if Nathanael is stepping up to maintain the
functionality and to take on the upstreaming work etc (thanks
Nathanael!). The existing maintainers mostly have their plates full.
(I''m assuming the original author/maintainer of this code is no longer
active in the area, otherwise we really ought to be hearing from them
about this).

However what we need to avoid is having this conversation again WRT
xen/stable-2.6.{38,39,40,41,...}.x and so on for every stable (or long
term stable) branch.

I didn''t review the code in details but checkpatch.pl says:
total: 7 errors, 104 warnings, 4226 lines checked

The majority look to be trivial to resolve whitespace or new typedef
issues. There''s a bunch of 80-character line warnings but personally
I''d
encourage using your own judgement on a case by case basis for those
rather than blindly following checkpatch.pl (applies in general too but
specifically wrt line length).

Also the patch needs a suitable commit message and a signed-off-by per
the D.C.O in Documentation/SubmittingPatches.
> > > The stuff necessary to get the frontend upstream has been
upstream for
> > > ages. For the backend basic dom0 boot support is in 2.6.37 and
the
> > > generic scaffolding for backends is currently in linux-next (via
> > > Konrad''s tree) and is intended to be in the next merge
window.
> > >
> > > I think the backend just looks like a regular USB driver to the
host
> > > system so it probably belongs in
drivers/usb/<something>/xen-usbback/
> > > and not drivers/xen. (I''m not sure what the
<something> should be,
> > > perhaps "misc").
> > 
> > I agree that the frontend driver looks like a regular USB host
> > controller driver and belongs in drivers/usb/host. From the dom0
> > perspective the backend driver is a consumer of USB services rather
> > than a provider so my inclination is that the proper place for the
> > backend is drivers/xen along with blkback, netback and pciback. Much
> > the same way as I would expect to find a USB TV tuner driver in
> > drivers/media rather than drivers/usb. I would prefer to remain
> > consistent with the model established by the block, net and pci
> > drivers,
A fair point.
>  but I am happy to adopt whatever convention is acceptable to
> > upstream.
That''s probably the best approach to take.
> Something I noticed about the pvusb backend..
> Should the name of the driver be xen-usbbk instead of just usbbk ?
> 
> The other backend driver modules seem to have xen- prefix.
xen-usbback please but, yes, this is a good change to make which
happened to the other drivers in the pvops tree sometime ago e.g.:
a84aa84cd0db4dd6a1a911f2263846c9b6f30a49 xen: rename netbk module xen-netback.
e762bd5145e59c043e47228fe1a6c1eebef07c0c xen: rename blkbk module xen-blkback.

Skimming "git log --pretty=oneline --no-merges xen/xen/stable-2.6.32.x
-- drivers/xen/{blk,net}back drivers/net/xen-netfront.c
drivers/block/xen-blkfront.c" for other generic changes which would be
worth propagating gives:
71133087313f15db44ffb6ea802e5bdb2479a600 xen: use less generic names in blkfront
driver.
9c9c87f53f87d0368ef04207cce4c92884f4ae3d xen: use less generic names in netfront
driver.
0c989045948320d583a190b75a12ba0ec556b804 Fix compile warnings: ignoring return
value of ''xenbus_register_backend'' ..
d2748d40e3e8a14706d0f3a378160def877aa222 xen/netback: don''t include
xen/evtchn.h
d3d3c63ce04b34ad6b45ed6da12d2be012861622 xen/blkback: don''t include
xen/evtchn.h

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Jan 07, 2011 at 05:56:28PM +0800, Nathanael Rensen
wrote:
> On 7 January 2011 02:55, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> 
> > Something I noticed about the pvusb backend..
> > Should the name of the driver be xen-usbbk instead of just usbbk ?
> >
> > The other backend driver modules seem to have xen- prefix.
> >
> > -- Pasi
> 
> Good point - although I think xen-usbback would better match
> xen-blkback, xen-netback, xen-pciback.
> 
Yeah, yesterday I tried porting PVSCSI drivers to pvops,
and I used xen-scsiback and xen-scsifront there aswell.
> For consistency the config options should probably be
> CONFIG_XEN_USBDEV_BACKEND and CONFIG_XEN_USBDEV_FRONTEND (the previous
> patch had CONFIG_XEN_USB_...).
> 
I''ll have to check these for PVSCSI aswell.
> I also noticed the frontend driver was producing a warning when
> loading which is resolved by setting the module owner.
> 
> I''ve placed an updated diff here:
> http://members.iinet.net.au/~nathanael/pvusb.diff
> 
Great, thanks.

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen
wrote:
> 
> > I also noticed the frontend driver was producing a warning when
> > loading which is resolved by setting the module owner.
> > 
> > I''ve placed an updated diff here:
> > http://members.iinet.net.au/~nathanael/pvusb.diff
> > 
> 
> Great, thanks.
> 
Hello again,

Nathanael: Did you have time to take a look at upstreaming xen pvusb drivers ?

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Mar 23, 2011 at 04:42:57PM +0200, Pasi Kärkkäinen
wrote:
> On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen wrote:
> > 
> > > I also noticed the frontend driver was producing a warning when
> > > loading which is resolved by setting the module owner.
> > > 
> > > I''ve placed an updated diff here:
> > > http://members.iinet.net.au/~nathanael/pvusb.diff
> > > 
> > 
> > Great, thanks.
> > 
> 
> Hello again,
> 
> Nathanael: Did you have time to take a look at upstreaming xen pvusb
drivers ?
> 
Hello,

Now there''s actually LinuxCon Vancouver event coming up,
where Linux USB virtualization is going to be discussed:
http://marc.info/?l=linux-kernel&m=130766622608800&w=2

So people interested in Xen PVUSB might want to attend/contribute..
http://events.linuxfoundation.org/events/linuxcon

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Feb 08, 2012 at 08:56:22AM +0800, Nathanael Rensen
wrote:
> Hi Pasi,
> 
Hello,

(I added Konrad and xen-devel to CC list, hopefully that''s ok..)
> It''s been a very long time since we discussed PVUSB - I
haven''t given
> up, just been caught up with other things.
> 
Great! Really nice to hear from you again..

Just last weekend I fetched the opensuse Linux 3.2 kernel-xen src.rpm,
extracted the xen patches, and started preparing to re-port the driver to pvops.
So now I don''t have to finish that :)
> I''ve updated the PVUSB patch, done some refactoring and cleaned up
the
> checkpatch warnings.
> The patch is targetted at linux-next, but it also applies cleanly to
> Konrad''s linux-next branch:
> 
> http://members.iinet.net.au/~nathanael/0001-pvusb-driver.linux-next.patch
> 
> I haven''t done a lot of testing, but it does work for my basic
test
> (USB TV-tuner). My next step is to get in contact with the USB
> maintainer and see what further changes are required in order to get
> this work upstreamed. In the meantime, the more testing and exposure
> the patch gets the better.
> 
I''m sure we can get people testing this patch. Many people have been
asking
for USB passthru solution for Linux 3.x.

> Thanks,
> 
Thanks a lot!


-- Pasi
> Nathanael
> 
> On 23 March 2011 22:42, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> > On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen wrote:
> >>
> >> > I also noticed the frontend driver was producing a warning
when
> >> > loading which is resolved by setting the module owner.
> >> >
> >> > I''ve placed an updated diff here:
> >> > http://members.iinet.net.au/~nathanael/pvusb.diff
> >> >
> >>
> >> Great, thanks.
> >>
> >
> > Hello again,
> >
> > Nathanael: Did you have time to take a look at upstreaming xen pvusb
drivers ?
> >
> > -- Pasi
> >

On Wed, Feb 08, 2012 at 08:59:30AM +0200, Pasi Kärkkäinen
wrote:
> On Wed, Feb 08, 2012 at 08:56:22AM +0800, Nathanael Rensen wrote:
> > Hi Pasi,
> > 
> 
> Hello,
> 
> (I added Konrad and xen-devel to CC list, hopefully that''s ok..)
> 
> > It''s been a very long time since we discussed PVUSB - I
haven''t given
> > up, just been caught up with other things.
> > 
> 
> Great! Really nice to hear from you again..
> 
> Just last weekend I fetched the opensuse Linux 3.2 kernel-xen src.rpm,
> extracted the xen patches, and started preparing to re-port the driver to
pvops.
> So now I don''t have to finish that :)
> 
> > I''ve updated the PVUSB patch, done some refactoring and
cleaned up the
> > checkpatch warnings.
> > The patch is targetted at linux-next, but it also applies cleanly to
> > Konrad''s linux-next branch:
> > 
> >
http://members.iinet.net.au/~nathanael/0001-pvusb-driver.linux-next.patch
Nice job (I took a brief look at it). I see you handled those m2p_override
nicely.
> > 
> > I haven''t done a lot of testing, but it does work for my
basic test
> > (USB TV-tuner). My next step is to get in contact with the USB
> > maintainer and see what further changes are required in order to get
> > this work upstreamed. In the meantime, the more testing and exposure
> > the patch gets the better.
OK. Well let me stick on my #testing branch which is a kitchensink of things
and play with a bit.
> > 
> 
> I''m sure we can get people testing this patch. Many people have
been asking
> for USB passthru solution for Linux 3.x.
> 
> 
> > Thanks,
> > 
> 
> Thanks a lot!
> 
> 
> -- Pasi
> 
> > Nathanael
> > 
> > On 23 March 2011 22:42, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> > > On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen wrote:
> > >>
> > >> > I also noticed the frontend driver was producing a
warning when
> > >> > loading which is resolved by setting the module owner.
> > >> >
> > >> > I''ve placed an updated diff here:
> > >> > http://members.iinet.net.au/~nathanael/pvusb.diff
> > >> >
> > >>
> > >> Great, thanks.
> > >>
> > >
> > > Hello again,
> > >
> > > Nathanael: Did you have time to take a look at upstreaming xen
pvusb drivers ?
> > >
> > > -- Pasi
> > >

On Wed, Feb 08, 2012 at 08:59:30AM +0200, Pasi Kärkkäinen
wrote:
> On Wed, Feb 08, 2012 at 08:56:22AM +0800, Nathanael Rensen wrote:
> > Hi Pasi,
> > 
> 
> Hello,
> 
> (I added Konrad and xen-devel to CC list, hopefully that''s ok..)
And let me add James Harper here since he was doing some testing with
the Windows GPL PV USB driver as well

> 
> > It''s been a very long time since we discussed PVUSB - I
haven''t given
> > up, just been caught up with other things.
> > 
> 
> Great! Really nice to hear from you again..
> 
> Just last weekend I fetched the opensuse Linux 3.2 kernel-xen src.rpm,
> extracted the xen patches, and started preparing to re-port the driver to
pvops.
> So now I don''t have to finish that :)
> 
> > I''ve updated the PVUSB patch, done some refactoring and
cleaned up the
> > checkpatch warnings.
> > The patch is targetted at linux-next, but it also applies cleanly to
> > Konrad''s linux-next branch:
> > 
> >
http://members.iinet.net.au/~nathanael/0001-pvusb-driver.linux-next.patch
> > 
> > I haven''t done a lot of testing, but it does work for my
basic test
> > (USB TV-tuner). My next step is to get in contact with the USB
> > maintainer and see what further changes are required in order to get
> > this work upstreamed. In the meantime, the more testing and exposure
> > the patch gets the better.
> > 
> 
> I''m sure we can get people testing this patch. Many people have
been asking
> for USB passthru solution for Linux 3.x.
> 
> 
> > Thanks,
> > 
> 
> Thanks a lot!
> 
> 
> -- Pasi
> 
> > Nathanael
> > 
> > On 23 March 2011 22:42, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> > > On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen wrote:
> > >>
> > >> > I also noticed the frontend driver was producing a
warning when
> > >> > loading which is resolved by setting the module owner.
> > >> >
> > >> > I''ve placed an updated diff here:
> > >> > http://members.iinet.net.au/~nathanael/pvusb.diff
> > >> >
> > >>
> > >> Great, thanks.
> > >>
> > >
> > > Hello again,
> > >
> > > Nathanael: Did you have time to take a look at upstreaming xen
pvusb drivers ?
> > >
> > > -- Pasi
> > >
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

On Wed, Feb 08, 2012 at 12:40:59PM -0500, Konrad Rzeszutek Wilk
wrote:
> On Wed, Feb 08, 2012 at 08:59:30AM +0200, Pasi Kärkkäinen wrote:
> > On Wed, Feb 08, 2012 at 08:56:22AM +0800, Nathanael Rensen wrote:
> > > Hi Pasi,
> > > 
> > 
> > Hello,
> > 
> > (I added Konrad and xen-devel to CC list, hopefully that''s
ok..)
> 
> And let me add James Harper here since he was doing some testing with
> the Windows GPL PV USB driver as well
> 
And let''s modify the subject aswell :) 

-- Pasi
> 
> > 
> > > It''s been a very long time since we discussed PVUSB - I
haven''t given
> > > up, just been caught up with other things.
> > > 
> > 
> > Great! Really nice to hear from you again..
> > 
> > Just last weekend I fetched the opensuse Linux 3.2 kernel-xen src.rpm,
> > extracted the xen patches, and started preparing to re-port the driver
to pvops.
> > So now I don''t have to finish that :)
> > 
> > > I''ve updated the PVUSB patch, done some refactoring and
cleaned up the
> > > checkpatch warnings.
> > > The patch is targetted at linux-next, but it also applies cleanly
to
> > > Konrad''s linux-next branch:
> > > 
> > >
http://members.iinet.net.au/~nathanael/0001-pvusb-driver.linux-next.patch
> > > 
> > > I haven''t done a lot of testing, but it does work for my
basic test
> > > (USB TV-tuner). My next step is to get in contact with the USB
> > > maintainer and see what further changes are required in order to
get
> > > this work upstreamed. In the meantime, the more testing and
exposure
> > > the patch gets the better.
> > > 
> > 
> > I''m sure we can get people testing this patch. Many people
have been asking
> > for USB passthru solution for Linux 3.x.
> > 
> > 
> > > Thanks,
> > > 
> > 
> > Thanks a lot!
> > 
> > 
> > -- Pasi
> > 
> > > Nathanael
> > > 
> > > On 23 March 2011 22:42, Pasi Kärkkäinen <pasik@iki.fi>
wrote:
> > > > On Fri, Jan 07, 2011 at 12:28:19PM +0200, Pasi Kärkkäinen
wrote:
> > > >>
> > > >> > I also noticed the frontend driver was producing a
warning when
> > > >> > loading which is resolved by setting the module
owner.
> > > >> >
> > > >> > I''ve placed an updated diff here:
> > > >> > http://members.iinet.net.au/~nathanael/pvusb.diff
> > > >> >
> > > >>
> > > >> Great, thanks.
> > > >>
> > > >
> > > > Hello again,
> > > >
> > > > Nathanael: Did you have time to take a look at upstreaming
xen pvusb drivers ?
> > > >
> > > > -- Pasi
> > > >
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel