Stefano Stabellini
2010-Aug-27 11:18 UTC
[Xen-devel] [PATCH 4 of 8] libxl: introduce the concept of dom0 minimum memory
libxl: introduce the concept of dom0 minimum memory
Introduce a minimum value for the memory assigned to dom0.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff -r 1276830b845f tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Thu Aug 26 18:55:46 2010 +0100
+++ b/tools/libxl/libxl.c Thu Aug 26 18:56:16 2010 +0100
@@ -2841,6 +2841,12 @@ int libxl_set_memory_target(libxl_ctx *c
char *uuid;
xs_transaction_t t;
+ if (!domid && target_memkb < LIBXL_MIN_DOM0_MEM) {
+ XL_LOG(ctx, XL_LOG_ERROR,
+ "new target for dom0 is below the minimum
threshold\n");
+ return ERROR_NOMEM;
+ }
+
retry_transaction:
t = xs_transaction_start(ctx->xsh);
@@ -2948,6 +2954,12 @@ retry_transaction:
abort = 1;
goto out;
}
+ if (!domid && new_target_memkb < LIBXL_MIN_DOM0_MEM) {
+ XL_LOG(ctx, XL_LOG_ERROR,
+ "new target for dom0 is below the minimum
threshold\n");
+ abort = 1;
+ goto out;
+ }
videoram_s = libxl_xs_read(&gc, t, libxl_sprintf(&gc,
"%s/memory/videoram", dompath));
videoram = videoram_s ? atoi(videoram_s) : 0;
diff -r 1276830b845f tools/libxl/libxl_internal.h
--- a/tools/libxl/libxl_internal.h Thu Aug 26 18:55:46 2010 +0100
+++ b/tools/libxl/libxl_internal.h Thu Aug 26 18:56:16 2010 +0100
@@ -43,6 +43,7 @@
#define LIBXL_MAXMEM_CONSTANT 1024
#define LIBXL_PV_EXTRA_MEMORY 1024
#define LIBXL_HVM_EXTRA_MEMORY 2048
+#define LIBXL_MIN_DOM0_MEM (128*1024)
#define QEMU_SIGNATURE "QemuDeviceModelRecord"
#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Jackson
2010-Aug-31 17:29 UTC
Re: [Xen-devel] [PATCH 4 of 8] libxl: introduce the concept of dom0 minimum memory
Stefano Stabellini writes ("[Xen-devel] [PATCH 4 of 8] libxl: introduce the
concept of dom0 minimum memory"):> libxl: introduce the concept of dom0 minimum memory
I like this. We can introduce a global config file to adjust the
setting, later.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel