Xen devel - Aug 2010 - [PATCH 3/7] vtpm Mini-Os domain: mini-os defines

Signed-off-by: Matthew Fioravante <Matthew.Fioravante@jhuapl.edu>

This patch adds some #defines to mini-os
NO_BLKFRONT
NO_FSFRONT
NO_NETFRONT
NO_FBFRONT
NO_PCIFRONT

These disable their respective drivers if defined. The vtpm domain does 
not need a framebuffer, network, fsfront, or pci so I added these to 
disable unneeded drivers.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

The principle is probably useful indeed.

Matthew Fioravante, le Wed 25 Aug 2010 11:15:04 -0400, a écrit
:
> This patch adds some #defines to mini-os
> NO_BLKFRONT
I tend to frown upon "negative" flags, as they''re less
readable. I know
that using "positive" will require adding them to all other stubdom
projects, but it''s probably still better that way: we''ll
realize for
instance that pv-grub doesn''t actually need pcifront :)

samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, 25 Aug 2010, Samuel Thibault wrote:
> The principle is probably useful indeed.
> 
> Matthew Fioravante, le Wed 25 Aug 2010 11:15:04 -0400, a ??crit :
> > This patch adds some #defines to mini-os
> > NO_BLKFRONT
> 
> I tend to frown upon "negative" flags, as they''re less
readable. I know
> that using "positive" will require adding them to all other
stubdom
> projects, but it''s probably still better that way: we''ll
realize for
> instance that pv-grub doesn''t actually need pcifront :)
> 
 
I agree, also all those ifdef''s make the code difficult to read.
Wouldn''t it be possible to enable/disable the compilation of those
files
altogether and provide stubs for the export functions instead?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel