Andre Przywara
2010-Aug-09 13:55 UTC
[Xen-devel] [PATCH 2/3]: xl: tell the user non-existent domain er
Hi, the error message when one wants to list a non-existent domain is at best misleading (libxl_domain_info failed (code -5)). Attached patch catches this specific error and tells the user that the requested domain does not exist: # xl list 42 Error: Domain ''42'' does not exist. I am not sure whether one should change the default error message in find_domain(), too, which currently reads: # xl list foo foo is an invalid domain identifier (rc=-1) Regards, Andre. Signed-off-by: Andre Przywara <andre.przywara@amd.com> -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448-3567-12 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2010-Aug-09 16:12 UTC
Re: [Xen-devel] [PATCH 2/3]: xl: tell the user non-existent domain er
On Mon, 9 Aug 2010, Andre Przywara wrote:> Hi, > > the error message when one wants to list a non-existent domain is at > best misleading (libxl_domain_info failed (code -5)). Attached patch > catches this specific error and tells the user that the requested domain > does not exist: > # xl list 42 > Error: Domain ''42'' does not exist. >applied, thanks.> I am not sure whether one should change the default error message in > find_domain(), too, which currently reads: > # xl list foo > foo is an invalid domain identifier (rc=-1) >I think the error message for find_domain is not too bad _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel