Andres Lagar-Cavilla
2009-Nov-30 19:15 UTC
[Xen-devel] [PATCH 09/14]: libxenlight, domain resume
Added libxenlight implementation for resume domain. This brings back a domain from the shutdown state after save, enabling checkpointing. Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2009-Dec-01 06:18 UTC
Re: [Xen-devel] [PATCH 09/14]: libxenlight, domain resume
On Mon, Nov 30, 2009 at 07:15:16PM +0000, Andres Lagar-Cavilla wrote:> Added libxenlight implementation for resume domain. > This brings back a domain from the shutdown state > after save, enabling checkpointing.(I haven''t looks at resume stuff for age ..) I think this only works if the domain is cooperative, if it isn''t you need to a callback in the middle of the calls to do devices related unplugging/plugging. If that still true, I would prefer to have a "if (pv)" around the code since pv are always suppose to be cooperative -- Vincent _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andres Lagar-Cavilla
2009-Dec-01 14:20 UTC
Re: [Xen-devel] [PATCH 09/14]: libxenlight, domain resume
I know little of hvm. I believe the *right* approach is to parse an elf note of the guest kernel. The hvm "kernel" is the hvmloader, so that would render hvm non-cooperative. The caller will have to provide the kernel path though, since we forget about it. Andres Vincent Hanquez wrote:> On Mon, Nov 30, 2009 at 07:15:16PM +0000, Andres Lagar-Cavilla wrote: > >> Added libxenlight implementation for resume domain. >> This brings back a domain from the shutdown state >> after save, enabling checkpointing. >> > > (I haven''t looks at resume stuff for age ..) > > I think this only works if the domain is cooperative, if it isn''t you need to a > callback in the middle of the calls to do devices related unplugging/plugging. > > If that still true, I would prefer to have a > "if (pv)" around the code since pv are always suppose to be cooperative > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel