Andres Lagar-Cavilla
2009-Nov-30 19:09 UTC
[Xen-devel] [PATCH 01/14]: libxenlight, refactore device destroy code
Refactor libxl device destroy code. Abstract function waiting for the watch on the state node to fire. Create a generic device delete function. Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2009-Dec-01 11:35 UTC
[Xen-devel] Re: [PATCH 01/14]: libxenlight, refactore device destroy code
On Mon, 30 Nov 2009, Andres Lagar-Cavilla wrote:> Refactor libxl device destroy code. Abstract function > waiting for the watch on the state node to fire. > Create a generic device delete function. > > Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.com> >while I appreciate the general idea, every time you call wait_for_dev_destroy you reset the timeout to LIBXL_DESTROY_TIMEOUT while in the current code the timeout for the select is only set once at the beginning, so that the global wait time it is going to be LIBXL_DESTROY_TIMEOUT. Could you please resend the patch adding an additional timeout param to wait_for_dev_destroy, set to LIBXL_DESTROY_TIMEOUT before the while loop in libxl_devices_destroy? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel