Kouya Shimura
2009-Nov-27 05:16 UTC
[Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error
set_p2m_entry() ignores halfway errors. It should return 0 on error, shouldn''t it? Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Nov-27 08:07 UTC
Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error
On 27/11/2009 05:16, "Kouya Shimura" <kouya@jp.fujitsu.com> wrote:> set_p2m_entry() ignores halfway errors. > It should return 0 on error, shouldn''t it? > > Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>Needs an Ack from Tim. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2009-Nov-27 10:43 UTC
Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error
At 05:16 +0000 on 27 Nov (1259298997), Kouya Shimura wrote:> set_p2m_entry() ignores halfway errors. > It should return 0 on error, shouldn''t it?Since all of its callers discard the return value, it hardly matters. :( But yes, this patch makes the semantics more sensible.> Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>Acked-by: Tim Deegan <Tim.Deegan@citrix.com> -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, UK.] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel