In xenstore_parse_domain_config(), ''any_hdN'' is overridden by
local version
accidentally.
diff --git a/xenstore.c b/xenstore.c
index b5a791e..8ac478b 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -357,7 +357,7 @@ void xenstore_parse_domain_config(int hvm_domid)
char *buf = NULL;
char *fpath = NULL, *bpath = NULL,
*dev = NULL, *params = NULL, *drv = NULL;
- int i, any_hdN = 0, ret;
+ int i, ret;
unsigned int len, num, hd_index, pci_devid = 0;
BlockDriverState *bs;
BlockDriver *format;
Signed-off-by: Yang Xiaowei <xiaowei.yang@intel.com>
Thanks,
Xiaowei
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name
parsing"):> In xenstore_parse_domain_config(), ''any_hdN'' is
overridden by local version
> accidentally.
Thanks for spotting this. You''re right that it''s a bug.
I''ve applied
your patch (although really I think this whole area is pretty grotty
and could do with substantial rework).
Two comments though about the formatting of your patch:
* It didn''t apply cleanly because it had different whitespace to
that in the actual code. Your mailer must have done something to
it I think. Best practice seems to be (if you can''t make your
mailer reliably not mangle the body of the message) to provide each
patch _both_ as an attachment (for application) _and_ by including
it in the body (for readable review).
* You forgot the Signed-off-By line, by which you would certify that
the code copyright and so forth status was appropriate (according
to the Developer''s Certificate of Origin). I applied your patch
anyway because it''s a one-line change (which most authorities think
makes it too small for copyright to apply) but you should make sure
to appropriately certify your code in future.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
> Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"): > > In xenstore_parse_domain_config(), ''any_hdN'' is overridden by local version > > accidentally. > > Thanks for spotting this. You''re right that it''s a bug. I''ve applied > your patch (although really I think this whole area is pretty grotty > and could do with substantial rework). > > Two comments though about the formatting of your patch: > > * It didn''t apply cleanly because it had different whitespace to > that in the actual code. Your mailer must have done something toThere must be something wrong when I did the paste.> it I think. Best practice seems to be (if you can''t make your > mailer reliably not mangle the body of the message) to provide each > patch _both_ as an attachment (for application) _and_ by including > it in the body (for readable review).Thanks for the advice. I''ll attach the patch also next time.> > * You forgot the Signed-off-By line, by which you would certify thatI added the signed-off-by line at the bottom!:) Thanks, xiaowei> the code copyright and so forth status was appropriate (according > to the Developer''s Certificate of Origin). I applied your patch > anyway because it''s a one-line change (which most authorities think > makes it too small for copyright to apply) but you should make sure > to appropriately certify your code in future. >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yang, Xiaowei writes ("RE: [Xen-devel][PATCH] ioemu: fix drive name
parsing"):> I added the signed-off-by line at the bottom!:)
So you did, sorry!
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel